From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] arm: qcom: Split Qualcomm support into legacy and multiplatform
Date: Fri, 31 Jan 2014 20:34:46 +0100 [thread overview]
Message-ID: <3511712.H3ChLoqCm7@wuerfel> (raw)
In-Reply-To: <2B2190A4-6689-40D8-A3D7-BD2D882A2CF6@codeaurora.org>
On Friday 31 January 2014 13:25:25 Kumar Gala wrote:
> > The hotplug.c change sticks out as something that isn't just a move
> > of code to another place, but deletion of unused code. It would
> > be nice to split that out into a separate change, possibly together
> > with the trivial board.c and smp.c changes.
>
> That?s not 100% true, the hotplug.c code implemented msm_cpu_die, which moved into smp.c
>
> I can split out scm*/smp* into a patch to enable smp if that is really desired, but not exactly sure what it gets us.
>
It's not extremely important, I just prefer splitting patches
that have any kind of functional change from trivial moves.
If something happens to break for an unforseen reason, it's
easier to bisect to the patch that does the change.
Arnd
next prev parent reply other threads:[~2014-01-31 19:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 18:36 [PATCH 0/4] Split mach-msm into legacy and mach-qcom (multiplatform) Kumar Gala
2014-01-30 18:36 ` [PATCH 1/4] clocksource: qcom: Move clocksource code out of mach-msm Kumar Gala
2014-01-30 18:36 ` [PATCH 2/4] arm: qcom: Split Qualcomm support into legacy and multiplatform Kumar Gala
2014-01-31 19:10 ` Olof Johansson
2014-01-31 19:20 ` Arnd Bergmann
2014-01-31 19:25 ` Kumar Gala
2014-01-31 19:34 ` Arnd Bergmann [this message]
2014-01-31 19:45 ` Kumar Gala
2014-01-31 20:11 ` Rob Herring
2014-02-26 14:22 ` Kevin Hilman
2014-02-26 17:22 ` Kumar Gala
2014-02-26 23:03 ` Kevin Hilman
2014-01-30 18:36 ` [PATCH 3/4] clocksource: qcom: split building of legacy vs multiplatform support Kumar Gala
2014-01-31 19:11 ` [PATCH 0/4] Split mach-msm into legacy and mach-qcom (multiplatform) Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3511712.H3ChLoqCm7@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).