From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1889C43381 for ; Thu, 14 Mar 2019 19:21:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DC212082F for ; Thu, 14 Mar 2019 19:21:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EEu8s0r5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DC212082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rBWZuf3Xr/nv1UYxvCQ2QZdC4iIFAvXuulQn809iquY=; b=EEu8s0r5HpvZBI Sp32zXGEzEuQ61/cQ3UVsCs7f/3Z3ZtdpJcd0NUkCbl/loZivQ3+jCq+P1bBLryEKm2icvmOzMh76 Pr2DHnHe9W+Ul1EX96+dg/fitES2CVq+3/yGM2ABOYg7kZCJwVmpISwGIASJgDNmq0huk4WUDLAZe bW+PSUmY2almNUDxYrZZWqJ0tPKj5ziubbumf7GyS+et5OG7NArAwjZXN9cDb8O5rJvniYYFnwf7G rkmzXpqFzYNnTP7AvcwYJu8Km8oWn6upZWUp0Xx3bs99FeXe8b+B2b+UFuVmLP+FIECxUlfI0gWf5 nsCCGbwwMZ5gdc6I0Y4g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4Vur-0007lP-M0; Thu, 14 Mar 2019 19:21:21 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4Vuo-0007kk-Km; Thu, 14 Mar 2019 19:21:20 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h4Vuj-0007Gz-Aw; Thu, 14 Mar 2019 20:21:13 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: "Leonidas P. Papadakos" Subject: Re: [PATCH] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs Date: Thu, 14 Mar 2019 20:21:12 +0100 Message-ID: <3517438.8SjcAmMXWL@diego> In-Reply-To: <1552590510.1381.1@gmail.com> References: <20190314182035.7101-1-papadakospan@gmail.com> <5530020.nRYjYCbPGH@diego> <1552590510.1381.1@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_122118_830900_F6644EE5 X-CRM114-Status: GOOD ( 13.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , william.wu@rock-chips.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi again :-) Am Donnerstag, 14. M=E4rz 2019, 20:08:30 CET schrieb Leonidas P. Papadakos: > I must say with my testing, I never really have any disconnects. My > drive generally works It's not any disconnects, it is really when you unplug the device from the root port that the = > Surely it's better that it works somewhat than not at all. > Maybe we could include the patches and revert them later if a solution > arrises? > = > Or is that against the Linux way of doing things? The main issue is compatible =3D "rockchip,rk3328-dwc3", "rockchip,rk3399-dwc3= "; because: (1) On the devicetree-side you declare that they are compatible which may or may not conflict with needed later changes (2) On the kernel-driver-side with the current status the rk3328-dwc3 will get ignored and rk3399-dwc3 used to bind to the generic dt-dwc3 driver. From looking at the Rockchip code in the vendor kernel we may very well need a separate driver to handle the big issue which creates the issue which driver will bind to the dt-node. It will be either the generic one binding to the rk3399-dwc3 or the special one binding to rk3328-dwc3. And sadly it will probably depend on which module gets loaded first. And devicetrees are supposed to be backwards compatible so a newer kernel should keep working with an old devicetree. A possible way forward would be to introduce a separate compatible for rk3328 (both in the binding doc and the generic dwc3 driver), so that we get only a compatible =3D "rockchip,rk3328-dwc3"; Which then even can move easily into a new driver if necessary without causing issues for existing devicetrees. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel