From: Andrew Davis <afd@ti.com>
To: Nishanth Menon <nm@ti.com>, Julien Panis <jpanis@baylibre.com>
Cc: <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved
Date: Thu, 3 Nov 2022 17:36:26 -0500 [thread overview]
Message-ID: <35284213-db06-8b6d-8c94-4279f61d6296@ti.com> (raw)
In-Reply-To: <20221103214754.5feylk5sfem2lvhf@magnetize>
On 11/3/22 4:47 PM, Nishanth Menon wrote:
> On 19:14-20221103, Julien Panis wrote:
>> MCU wdt is typically used by M4F.
>> Wake up wdt is typically used by DM (R5) firmware.
>>
>> Signed-off-by: Julien Panis <jpanis@baylibre.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am625-sk.dts | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> index 93a5f0817efc..9ade591ef563 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts
>> @@ -503,6 +503,16 @@ &main_mcan0 {
>> status = "disabled";
>> };
>>
>> +&mcu_rti0 {
>> + /* MCU RTI0 is used by M4F firmware */
>> + status = "reserved";
>> +};
>> +
>> +&wkup_rti0 {
>> + /* WKUP RTI0 is used by DM firmware */
>> + status = "reserved";
>> +};
>> +
>
> If this is the typical usage, should'nt we do this in soc.dtsi than
> sprinkle this through various boards?
>
> Andrew: ?
These are only "reserved" for certain firmware, you choose your RPROCs
and firmware down at the bottom level in board DTs. So I'd say these
statuses should be set at this same level here.
DM firmware might be the exception as it should always be present,
but for M4F firmware, meh, leave it here.
Andrew
>> &epwm0 {
>> status = "disabled";
>> };
>> --
>> 2.37.3
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-03 22:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 18:14 [PATCH v2 0/2] AM62x watchdog support Julien Panis
2022-11-03 18:14 ` [PATCH v2 1/2] arm64: dts: ti: k3-am62: add watchdog nodes Julien Panis
2022-11-03 18:14 ` [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: mark MCU and WKUP watchdogs as reserved Julien Panis
2022-11-03 21:47 ` Nishanth Menon
2022-11-03 22:36 ` Andrew Davis [this message]
2022-11-03 23:10 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35284213-db06-8b6d-8c94-4279f61d6296@ti.com \
--to=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jpanis@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox