From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/7] irqchip: gic: Support hierarchy irq domain.
Date: Mon, 13 Oct 2014 11:27:01 +0200 [thread overview]
Message-ID: <3536113.xYztHpGTJM@wuerfel> (raw)
In-Reply-To: <543B93B4.3040404@arm.com>
On Monday 13 October 2014 09:56:20 Marc Zyngier wrote:
> if (irq_domain_is_hierarchy(domain)) {
> + if (domain->ops->xlate) {
> + /*
> + * If we've already configured this interrupt,
> + * don't do it again, or hell will break loose.
> + */
> + if (domain->ops->xlate(domain, irq_data->np,
> + irq_data->args,
> + irq_data->args_count,
> + &hwirq, &type))
> + return 0;
> +
> + virq = irq_find_mapping(domain, hwirq);
> + if (virq)
> + return virq;
> + }
> virq = irq_domain_alloc_irqs(domain, 1, NUMA_NO_NODE, irq_data);
> return virq <= 0 ? 0 : virq;
> }
>
> Thoughts?
Using irq_find_mapping() first is probably the right approach, that
is what irq_create_mapping() does too, and I suppose we want those
to be symmetric.
mt_sysirq_domain_alloc() in patch 4 has the irq_find_domain check
in it, which I guess we can remove when it has moved to the common
code.
I don't see irq_domain_alloc_irqs() in linux-next or older kernels, where
does that get introduced?
Arnd
next prev parent reply other threads:[~2014-10-13 9:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 14:29 [PATCH v3 0/7] ARM: mediatek: Add support for interrupt polarity Joe.C
2014-10-09 14:29 ` [PATCH v3 1/7] irqdomain: Fix irq_domain_alloc_irqs return check Joe.C
2014-10-13 12:11 ` Marc Zyngier
2014-10-13 14:13 ` Jiang Liu
2014-10-09 14:29 ` [PATCH v3 2/7] genirq: Add more helper functions to support stacked irq_chip Joe.C
2014-10-09 14:29 ` [PATCH v3 3/7] irqchip: gic: Support hierarchy irq domain Joe.C
2014-10-09 16:59 ` Marc Zyngier
2014-10-09 17:22 ` Arnd Bergmann
2014-10-13 10:43 ` Joe.C
2014-10-13 12:10 ` Marc Zyngier
2014-10-13 19:51 ` Arnd Bergmann
2014-10-13 8:56 ` Marc Zyngier
2014-10-13 9:25 ` Marc Zyngier
2014-10-13 9:27 ` Arnd Bergmann [this message]
2014-10-13 9:44 ` Marc Zyngier
2014-10-09 14:29 ` [PATCH v3 4/7] ARM: mediatek: Add sysirq interrupt polarity support Joe.C
2014-10-09 14:37 ` Arnd Bergmann
2014-10-09 14:53 ` Joe.C
2014-10-13 13:43 ` Matthias Brugger
2014-10-13 14:14 ` Matthias Brugger
2014-10-09 14:29 ` [PATCH v3 5/7] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi Joe.C
2014-10-09 14:29 ` [PATCH v3 6/7] dt-bindings: add irq domain parent binding Joe.C
2014-10-09 14:57 ` Mark Rutland
2014-10-09 14:29 ` [PATCH v3 7/7] dt-bindings: add bindings for mediatek sysirq Joe.C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3536113.xYztHpGTJM@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox