From: Markus Elfring <Markus.Elfring@web.de>
To: Luo Jie <quic_luoj@quicinc.com>, cocci@inria.fr
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
Andrew Lunn <andrew@lunn.ch>,
Catalin Marinas <catalin.marinas@arm.com>,
Joey Gouly <joey.gouly@arm.com>,
Julia Lawall <Julia.Lawall@inria.fr>,
"Kiran Kumar C.S.K" <quic_kkumarcs@quicinc.com>,
Lei Wei <quic_leiwei@quicinc.com>, Marc Zyngier <maz@kernel.org>,
Nicolas Palix <nicolas.palix@imag.fr>,
Oliver Upton <oliver.upton@linux.dev>,
Pavithra R <quic_pavir@quicinc.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Suruchi Agarwal <quic_suruchia@quicinc.com>,
Suzuki Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>, Yury Norov <yury.norov@gmail.com>,
Zenghui Yu <yuzenghui@huawei.com>,
quic_linchen@quicinc.com
Subject: Re: [cocci] [PATCH v4 2/5] arm64: tlb: Convert the opencoded field modify
Date: Thu, 12 Jun 2025 22:15:10 +0200 [thread overview]
Message-ID: <3537a4ce-b5e8-44d5-a884-70a81562068d@web.de> (raw)
In-Reply-To: <20250612-field_modify-v4-2-ae4f74da45a6@quicinc.com>
I see further refinement possibilities for such a change description.
> Replace below code with the wrapper FIELD_MODIFY(MASK, ®, val)
> - reg &= ~MASK;
> - reg |= FIELD_PREP(MASK, val);
* How do you think about to omit leading minus characters?
* Subsequent blank line?
> More information about semantic patching is available at
> http://coccinelle.lip6.fr/
I suggest to omit this information here (and in similar patches).
Regards,
Markus
next prev parent reply other threads:[~2025-06-12 20:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 13:46 [PATCH v4 0/5] Add FIELD_MODIFY() helper Luo Jie
2025-06-12 13:46 ` [PATCH v4 1/5] coccinelle: misc: Add field_modify script Luo Jie
2025-06-12 16:48 ` [cocci] " Markus Elfring
2025-06-16 10:28 ` Luo Jie
2025-06-12 13:46 ` [PATCH v4 2/5] arm64: tlb: Convert the opencoded field modify Luo Jie
2025-06-12 20:15 ` Markus Elfring [this message]
2025-06-16 10:37 ` [cocci] " Luo Jie
2025-06-16 10:41 ` Will Deacon
2025-06-16 16:19 ` Luo Jie
2025-06-16 13:52 ` [cocci] [v4 " Markus Elfring
2025-06-16 16:19 ` Luo Jie
2025-06-12 13:46 ` [PATCH v4 3/5] arm64: nvhe: " Luo Jie
2025-06-12 13:46 ` [PATCH v4 4/5] arm64: kvm: " Luo Jie
2025-06-12 13:46 ` [PATCH v4 5/5] arm64: mm: " Luo Jie
2025-06-12 14:11 ` [PATCH v4 0/5] Add FIELD_MODIFY() helper Marc Zyngier
2025-06-16 10:06 ` Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3537a4ce-b5e8-44d5-a884-70a81562068d@web.de \
--to=markus.elfring@web.de \
--cc=Julia.Lawall@inria.fr \
--cc=andrew@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=cocci@inria.fr \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=maz@kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=oliver.upton@linux.dev \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yury.norov@gmail.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).