From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74217C4345F for ; Fri, 26 Apr 2024 15:38:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X3oPSTnyvN0UKJ9u2T4AZqDNapx1MW+l7YfpGBV9/A0=; b=nDBknfw3/8AMCt U3SVzddly9tQszzqAkd0XGVIuJnihcf2ZcC6UkAwKcVb/FTrcIIaJ+4V3TBlAKBFpisd7INNc+wBx Yjb4o2Fj/T5rntWPojIm+cJ4am3FoqqntDQ6lvNF7+oUrtnLn6NCdS6pFkUs4zCn1gY3iOTOiNhPZ ljofT4ZVR44G0ag45/TvRal+lzxzqMtekKTau023zYdZ2toIzzOi7zaXH2TdP/Y4cz5zklPFTN4AJ rNz3sDtheuJX+VKPTVHtOLvSJLknHkOMd8EOfzmqWM/ngZKxNz8l50hef7OZRM/GiQgrDErbhvAx6 wzW+3ePHTt3YMhZGPBmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0Ne1-0000000D5OV-2jPH; Fri, 26 Apr 2024 15:37:49 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0Ndy-0000000D5Nr-22UC for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2024 15:37:48 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-41a72f3a1edso18705575e9.2 for ; Fri, 26 Apr 2024 08:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714145863; x=1714750663; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0fnllMvw5rV4aVeEqjprC/GqDGLK/jA5NIktH0d4s7A=; b=Dly3nxMnvko86a4u7V3u2C1iO+p4W8ADNdXcLP+aBFM7BDfYt+yoeHOJ1CX3ord/hS 6rbWI4TwDZY/yxU/PXO49Z4I2I/yoINp2Jk+evL6y7e2nMslQkv1lmV6VoQm1LYnUSme 1hEL6RG+AUve3kPSTRS00KCFwTWHkB5FouyN3mB5B+31eyQuGLo6Aq+gFYr2vujvsr7f nL//tlIRe0C3CINau6OsMsgYfxa5td9Fi0hmRDoNVUMlHie+2mgA//yzHNmk5vLvDOKR rwZ/qDbNfEIsE9evtRE/JZwcLK4cGlnAUu6zeJxl9Rs4Jm4SzssOsm8+1yCjcSNnG2FA OnCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714145863; x=1714750663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0fnllMvw5rV4aVeEqjprC/GqDGLK/jA5NIktH0d4s7A=; b=GQNazJtX3J+nWF1cKdnCYCoPDqXL6pBcVsjQ+5CCZBLNPVpRWv6mIe9ZYGej2qC2gK XLHf1xqatpfJcD17jlQn5dH3ZzNHleJJWsQwHaxoJ0KB7ykhz6iLzG8zhG1cD3f2TK0z P8XLgDTGP0QhqAMzkSAiOqBF/SZKMJ3TMG/v/4Qbe4/AcKB+bOuJmLZPVuhpqcSKjzsU QLNNhQuaOkG6zrZeA1gKYGzxksOYxkC9wZjUUYrqCksXuLDBG6XCv88tyGkVIfPxYLHG bGUoomFM4+nEqD83BXEzy2klNgbmESB5fMUiFn2prEDAxAekowtigxBhiAtObr0ABxai xxMA== X-Forwarded-Encrypted: i=1; AJvYcCVPTZ2CAip0IEasWADIAwRhsuZvs2DMyhI2n1r99IYEhiVJBcMq/4Gx8ZSgfnqSYI67yzuN0r2s2Xnb6FqM3ytwErT5Z1r9RRcIBvSrpzFuYcDM/aI= X-Gm-Message-State: AOJu0YwDnKW8ibIzbwFkKFIqFLdNW0B8b34MK1bbXKM7E9fWbStSxCs6 xQi02x+qyOL+RgjzhrTUwjBuMWhyPE9A4JW6O+fHllXrdF/A7+O9 X-Google-Smtp-Source: AGHT+IF86aCF2y03zjD72DabiUs318EzT1BZ/WTa9OJV2HjgTF93fx7CNQA08TDph3S28W4TYeipuA== X-Received: by 2002:a05:600c:1988:b0:41a:7ab1:fd98 with SMTP id t8-20020a05600c198800b0041a7ab1fd98mr2473420wmq.21.1714145863392; Fri, 26 Apr 2024 08:37:43 -0700 (PDT) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id w17-20020a05600c475100b004162d06768bsm35189838wmo.21.2024.04.26.08.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 08:37:43 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Samuel Holland , Andy Shevchenko , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Andy Shevchenko Cc: Pavel Machek , Lee Jones , Chen-Yu Tsai Subject: Re: [PATCH v1 1/1] leds: sun50i-a100: Use match_string() helper to simplify the code Date: Fri, 26 Apr 2024 17:37:42 +0200 Message-ID: <3557566.iIbC2pHGDl@jernej-laptop> In-Reply-To: <20240426152515.872917-1-andriy.shevchenko@linux.intel.com> References: <20240426152515.872917-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240426_083746_596159_09247554 X-CRM114-Status: GOOD ( 19.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne petek, 26. april 2024 ob 17:25:15 GMT +2 je Andy Shevchenko napisal(a): > match_string() returns the array index of a matching string. > Use it instead of the open-coded implementation. > > Signed-off-by: Andy Shevchenko > --- > drivers/leds/leds-sun50i-a100.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/leds/leds-sun50i-a100.c b/drivers/leds/leds-sun50i-a100.c > index 62d21c3a3575..119eff9471f0 100644 > --- a/drivers/leds/leds-sun50i-a100.c > +++ b/drivers/leds/leds-sun50i-a100.c > @@ -252,18 +252,16 @@ static int sun50i_a100_ledc_parse_format(struct device *dev, > struct sun50i_a100_ledc *priv) > { > const char *format = "grb"; > - u32 i; > + int i; > > device_property_read_string(dev, "allwinner,pixel-format", &format); > > - for (i = 0; i < ARRAY_SIZE(sun50i_a100_ledc_formats); i++) { > - if (!strcmp(format, sun50i_a100_ledc_formats[i])) { > - priv->format = i; > - return 0; > - } > - } > + i = match_string(sun50i_a100_ledc_formats, ARRAY_SIZE(sun50i_a100_ledc_formats), format); > + if (i < 0) > + return dev_err_probe(dev, i, "Bad pixel format '%s'\n", format); I know that old code used dev_err_probe() without reason, but could you change it to ordinary dev_err()? dev_err_probe() is useful only when return code could be -EPROBE_DEFER. This is clearly not the case here. Best regards, Jernej > > - return dev_err_probe(dev, -EINVAL, "Bad pixel format '%s'\n", format); > + priv->format = i; > + return 0; > } > > static void sun50i_a100_ledc_set_format(struct sun50i_a100_ledc *priv) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel