From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: remove tautologic #ifdefs in proc-v7-3level.S
Date: Tue, 29 Mar 2016 10:05:58 +0200 [thread overview]
Message-ID: <3570872.7QPkonuD2y@wuerfel> (raw)
In-Reply-To: <1459237071-13842-1-git-send-email-jonas.rabenstein@studium.uni-erlangen.de>
On Tuesday 29 March 2016 09:37:51 Jonas Rabenstein wrote:
> The file arch/arm/mm/proc-v7-3level.S is only used by the #include
> directive in arch/arm/mm/proc-v7.S:23. This #include is conditional and
> depends on CONFIG_ARM_LPAE (otherwise proc-v7-2level.S is used).
> CONFIG_ARM_LPAE has a dependency on CONFIG_MMU defined in Kconfig.
> Consequently, checks for CONFIG_MMU in proc-v7-3level.S are superfluous.
>
> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
> ---
> I detected the issue with chimaera, a tool I currently develop for my bachelor
> thesis extending the undertaker tool suite (https://undertaker.cs.fau.de).
Nice catch!
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
I guess you should submit the same thing for the other file as well,
either in the same patch or as a series.
You can also add
Fixes: 8d2cd3a38fd6 ("ARM: LPAE: Factor out classic-MMU specific code into proc-v7-2level.S")
to mark the commit that led to the situation.
Arnd
next prev parent reply other threads:[~2016-03-29 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 7:37 [PATCH] arm: remove tautologic #ifdefs in proc-v7-3level.S Jonas Rabenstein
2016-03-29 8:05 ` Arnd Bergmann [this message]
2016-03-29 8:29 ` Jonas Rabenstein
2016-03-29 8:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3570872.7QPkonuD2y@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox