From: marvin24@gmx.de (Marc Dietrich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/9] Migrate Tegra to common clock framework
Date: Fri, 11 Jan 2013 20:52:39 +0100 [thread overview]
Message-ID: <35738737.tYpi2RKzkU@ax5200p> (raw)
In-Reply-To: <50F058BC.9090909@wwwdotorg.org>
On Friday 11 January 2013 11:23:56 Stephen Warren wrote:
> On 01/11/2013 08:59 AM, Marc Dietrich wrote:
> > On Friday 11 January 2013 13:40:03 Prashant Gaikwad wrote:
> >> On Thursday 10 January 2013 02:14 AM, Stephen Warren wrote:
> >>> On 01/09/2013 10:34 AM, Stephen Warren wrote:
> ...
>
> >>> Your changes don't actually cause the driver to break though, since it
> >>> abuses clk_get_sys() to retrieve clocks under a different driver name,
> >>> which matches what the clock driver provides. However, I think you
> >>> should also include the following patch at the end of your series to fix
> >>>
> >>> this up, so the clock looking happens through device tree:
> >>>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> >>>> index d8826ed..6d44076 100644
> >>>> --- a/drivers/staging/nvec/nvec.c
> >>>> +++ b/drivers/staging/nvec/nvec.c
> >>>> @@ -770,7 +770,7 @@ static int tegra_nvec_probe(struct platform_device
> >>>> *pdev)>>
> >>>>
> >>>> return -ENODEV;
> >>>>
> >>>> }
> >>>>
> >>>> - i2c_clk = clk_get_sys("tegra-i2c.2", "div-clk");
> >>>> + i2c_clk = clk_get(&pdev->dev, "div-clk");
> >>>>
> >>>> if (IS_ERR(i2c_clk)) {
> >>>>
> >>>> dev_err(nvec->dev, "failed to get controller
> >>>> clock\n");
> >>>> return -ENODEV;
> >>
> >> Included in the latest patches sent.
> >
> > em, not yet in V4.
>
> It's in V2 of the other series Prashant posted which sits on top of the
> CCF rework series.
ahh, sorry - I didn't see it because of the changed subject line.
> > Maybe you can also adjust the TODO (2nd entry) file now
> > that this issue is fixed.
>
> I'll try to remember to repost an updated version of the patch which
> does that...
no need if it just adds this change. I'll need to update the file anyway soon.
Thanks
Marc
next prev parent reply other threads:[~2013-01-11 19:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 9:40 [PATCH v3 0/9] Migrate Tegra to common clock framework Prashant Gaikwad
2013-01-04 9:40 ` [PATCH v3 1/9] ARM: tegra: Add function to read chipid Prashant Gaikwad
2013-01-04 9:40 ` [PATCH v3 2/9] clk: tegra: Add tegra specific clocks Prashant Gaikwad
2013-01-04 9:40 ` [PATCH v3 3/9] arm: tegra: Move tegra_cpu_car.h to linux/clk/tegra.h Prashant Gaikwad
2013-01-04 9:40 ` [PATCH v3 4/9] ARM: tegra: Define Tegra20 CAR binding Prashant Gaikwad
2013-01-04 9:40 ` [PATCH v3 5/9] ARM: Tegra: Define Tegra30 " Prashant Gaikwad
2013-01-04 9:40 ` [PATCH v3 6/9] clk: tegra: add clock support for tegra20 Prashant Gaikwad
2013-01-04 9:40 ` [PATCH v3 7/9] clk: tegra: add clock support for tegra30 Prashant Gaikwad
2013-01-04 9:40 ` [PATCH v3 8/9] arm: tegra: Migrate to new clock code Prashant Gaikwad
2013-01-04 9:40 ` [PATCH v3 9/9] arm: tegra: Remove legacy " Prashant Gaikwad
2013-01-04 11:20 ` [PATCH v3 0/9] Migrate Tegra to common clock framework Joseph Lo
2013-01-04 17:22 ` Stephen Warren
2013-01-08 0:10 ` Stephen Warren
2013-01-08 13:19 ` Prashant Gaikwad
2013-01-08 18:49 ` Stephen Warren
2013-01-08 21:01 ` Stephen Warren
2013-01-09 10:59 ` Prashant Gaikwad
2013-01-09 17:34 ` Stephen Warren
2013-01-09 20:44 ` Stephen Warren
2013-01-11 8:10 ` Prashant Gaikwad
2013-01-11 15:59 ` Marc Dietrich
2013-01-11 18:23 ` Stephen Warren
2013-01-11 19:52 ` Marc Dietrich [this message]
2013-01-11 8:12 ` Prashant Gaikwad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35738737.tYpi2RKzkU@ax5200p \
--to=marvin24@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).