From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53E45C54EBC for ; Wed, 11 Jan 2023 02:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:From:References:Cc:To: Subject:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vFQJOyfuL7kJ8Xj9RdBtl0C+1yIFL0CN3AQ65o30c2Y=; b=V9+m2JWuTa8TdZ3F1T+eH1bPbD 3zot8cSlNqzRCaxv1znEl+n23rRv3ZMRA1YsedGvTVrbvxFq26ctzeRkvmhXxg7zu6SVvI1/XW5el PtKyKkdGg+J5BrNUasPMO0Oq3FC3+GudBrvVcBYV/28srQdFgWVZ6zXzVGRJc5SKCZQSOce7NiPrr Geyf29XMpuiU0P7SeUnPI7Z98yl7RVUpnmEYhEKUusVV5gIedkJ0v3tt4ew/5lipUjNRmcS22DRoz iFfXyv92gj2jrXYnJKAHRYKD4kY6tkJeX83WXwc0wXNRKT6kR+ZUlqje4KhJnXpYdI5uh13tYYZS1 E/VyYSnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFRJb-009LiU-0o; Wed, 11 Jan 2023 02:58:11 +0000 Received: from mail-db5eur01on2052.outbound.protection.outlook.com ([40.107.15.52] helo=EUR01-DB5-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFRJX-009Lh5-QW for linux-arm-kernel@lists.infradead.org; Wed, 11 Jan 2023 02:58:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JU1HzZJ4u0HQbLKTuf6D93VIj6hfqGuRDQfw6/dnOyLIdKSPe7TwK5KOJvnMTY3Y6leqsNogSjI4/cQc6WVJo+yrHZogeJZM26IqwzFlcxGHilFwXfVO+rq7CamcrVOmNU/sxL+bQO1hVLGaJQxEaurzWE7Xkpkv8172yXtMERPqXDCOOPRFWhc0c2RGQwAlfhQvmxlUnPknazUv8D4RsqabyfSRlgipclG7iTUPUuQ4cknvR7pqEObWh+fMUltKyAc+kegli1nqDDYZ6sMtiT2ZE7pJlkeAUU6RFeZK0NsKXovKutOnK38pF2JzpD3i7vjhFqEhybOpL5rPJa97Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1jsG26pRDO/ffUUKEjdtkvf81ijDIKSnk2bBszx061w=; b=nO2/pTybxF4bNmw+AqxvNI8KSBZ0AqNS1rfWyTy70d5bf12RL5xcVR8CQFkZkSIj7q9x5Bx01rDFOGjZ2KKySOXKBIRpLWdM3aqHoYQboDShuWTD0IRQkNqIPnAb7B4WVd/+ss7XfeuvVpYtfxOyOszPEpsuXUurh0DVwKyhBs5Ws2VjEJzLr1YFbhL0wH58oNVBfLBeQFKeE+vb21oE1sh5ZBcPyyR8SCjObXIH66ZWAofGGPKjPTQPEzPPf5b97x2wqtnmWrvtVwtHe0lxmtT4G4FPRWKlsk/N5cr0WF5ZwTTtfLs8kG5JYJtV0/9W7blrF8TXt0+5PUeY3jsRdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1jsG26pRDO/ffUUKEjdtkvf81ijDIKSnk2bBszx061w=; b=k8N5yUHpbUD5pysgvISukOQR1ICqwrGLJXcImUrmYNh3zwzAm1iEIevNOZ0ruuFIfxA4qwubtWpMxwvCLdqxQbpUWX98dBTtAISehrubW+j/oqiCzNJQo2C6KAS+y326J5gEWrl5r+TdYuUYLHZBGaJXJWbSyRLFWitruD36hkM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by VI1PR04MB7022.eurprd04.prod.outlook.com (2603:10a6:800:126::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Wed, 11 Jan 2023 02:57:58 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::e203:47be:36e4:c0c3]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::e203:47be:36e4:c0c3%7]) with mapi id 15.20.6002.012; Wed, 11 Jan 2023 02:57:58 +0000 Message-ID: <358c5e71-cae7-cec4-7689-e74c8bdaa288@oss.nxp.com> Date: Wed, 11 Jan 2023 10:57:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0 Subject: Re: [PATCH] soc: imx: imx8mp-blk-ctrl: set HDMI LCDIF panic read hurry level Content-Language: en-US To: Lucas Stach , Shawn Guo , sandor.yu@nxp.com Cc: Pengutronix Kernel Team , NXP Linux Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org, patchwork-lst@pengutronix.de References: <20230109161242.54620-1-l.stach@pengutronix.de> <9fadd80c-c867-714c-20a3-48cac2390fa4@oss.nxp.com> <6b9a0836ea1fc7ef4d430f41e0a1e330e636e6f7.camel@pengutronix.de> From: Peng Fan In-Reply-To: <6b9a0836ea1fc7ef4d430f41e0a1e330e636e6f7.camel@pengutronix.de> X-ClientProxiedBy: ME2PR01CA0175.ausprd01.prod.outlook.com (2603:10c6:220:20::19) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|VI1PR04MB7022:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f555947-48a4-435b-1d10-08daf37fa4e8 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5lYY2vJOxwC9vEsru87YRsZBw9KyhQt2TyCsYVPjnk8FHKxjikD+vBC48i+bRuIAAkNPnDCaXbK4hlEFuWlBjjTkeHSoiUvQBgv/0lHZfuSlYENg6QjniqIustOMCocl90LWBrJIoKYEICeNb5g9LsQe73ell2ONOOoqHxexmmEUSwnhX3mQ8vXsEYt1k4KAPzUU0FiUEsNiDJGQZ9nzW/rPGURIk59MBrn7iDXgBpxckXxmuiuu34ThEj4vyDVFELdOXW7kePePhCBacvkS7g9EMOXBPXC/j2jmZd4y6cTLhCApBTgmZlXW9hHdikL7sXwBKdA6+LK7BB1oyUz+zFRzF5Iw/JWGXyv/981+QQnWtbjzibhJSi4t4OL66UsYYMPcGarnLfTbNY5+Nh6q/TT6DJXedGxxV07jftjaZ04bhQWwSF3HgDHpJ/qO1/xmFkOMP0u7rOlcsG8lhB14vxyGmDk9hx59NQ/h3vIaXoTpXVX/UrQ1ga//BE8dUxbHNI3UjAVlvpGexahp1jMTHPVfmtbOQ9dJYsRSFkmgFoPieywzqRsFKfe0rWA5HmXodWrtT5UfO4hijHboDtdlQdyq6FIg3ai/ASt8Lxcl5sshNC7LkPr/oGPX0RnLgFN1X0yIVy78Tb5IHbgyiIIyfW6CMcB+qwjF+4y1kWUWB2zY/qEx+x6Lk/AQKWGwOMWAmMmF3GZea2Jcj4FuZ37YjcmeHVeOubG5ussHfzJRAFcngmql76HO7fRIcdCKHajSDUyUdFbYMv0TEgPzoUUZfExS/UGWOFpZIyiYCvAncodzlhQrNLOYZ70bAtAyOZRJ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(346002)(366004)(396003)(451199015)(53546011)(6506007)(6486002)(478600001)(6666004)(2616005)(4326008)(26005)(186003)(6512007)(66556008)(316002)(8676002)(66476007)(52116002)(110136005)(54906003)(86362001)(38100700002)(38350700002)(31696002)(41300700001)(66946007)(31686004)(5660300002)(2906002)(8936002)(44832011)(21023001)(32563001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTRETThpUXBYNXJOOFZTMXRwMEVhdkVoYjZ4cW1CMzFlQm1EWVpBNmM5TGRL?= =?utf-8?B?d2VrRHFDbnFBWE9LOVVxa0RETTc1WTRpckl1NmExbnRFV2dBRi96cVRVOTJk?= =?utf-8?B?Q3FjMFNQWG9qWW9JNnJSc29JVVpYd2tIYTd3NTRzTmZnMk8vREJZMVVFQ1A3?= =?utf-8?B?WmRDdm1MZWw0a2FrRWs5M2JSTUxLQm9EQlpkQjU3Nm83VytJb2R6a1lQcTNM?= =?utf-8?B?WDlaQkFFNk1OdlBMdTljb3RyZmdXTmV4TysycW50WE84Rnl0SDN3WmRBdCtl?= =?utf-8?B?WExRVjMxeG0yZS9WL0tWSkQyOUtDMDhBYkpWNzA5R1ZGaCtxODFONG8wNFRr?= =?utf-8?B?d3UxeVVVVEJ1UzVjb3BxY3hJVUpzUUY4T0lobVhJZVFMd0h5QVpka1hIcjZs?= =?utf-8?B?dFE4L1RRaVJEeDVucVRqdG8xNHB4S3oza002d1ZhV2FSTWNGazBURDJpR0ZP?= =?utf-8?B?ekxtTG1sVnVOWngyRkZjWUZvcnN5c0NsOHFBZ0d3Z0poVUsrVW93MDY4RE1E?= =?utf-8?B?ajYwSVBCb1ZoOG9ZOWIydXEwcmo5TnliUDZjbCtDa3lseUMwejJWOVJhUmt3?= =?utf-8?B?Z3FUT2RnY2dPUlFySnBFR0JacWZmWHYwY0FQZFdXNm54RFBGd1JBUGlHa3NQ?= =?utf-8?B?dGtuL2lueTNuQ0NiQlc3Yy9SWmdwMU1sbHZwckNKVVErZEp5ZkUybjBnWkRh?= =?utf-8?B?MHpFZndnekV3RDVnVnY5N1JKZDEybUQ5YXVNQWtmVlViMkQ3a1hFOEhMWEIr?= =?utf-8?B?WG9zcmxKcWJOUy9Vb3N4R0cyZFVSR1d2S1QxYnpVM20rWGExbDFiSGFCTXp6?= =?utf-8?B?TmN2cHlCdU1DNnRCZ1k3UFVieU9OTzl4eHAvSFBqZDh3M2xlWTBicVZQcmZW?= =?utf-8?B?cmkzQkJiMVNGVWh0RHBPMnhJZncydHFlb2VwbERBblZUUXhWbmxxNm5YS2M2?= =?utf-8?B?UHNNMkxGWGJWdVZIdHpnd0lmbG9MTmZTUGYzYzlDOWwveTV3SW5WdlgyQ29p?= =?utf-8?B?eVNlbllHZEN0K08yODdyUFRFREg3dElSbllNQVJTMXprRXpzVEpTazBPbnpr?= =?utf-8?B?NnZ5TVhDOWdJVzJzVkZESDBRQS9QRGJWcFVMZ2k0QkJ2YXpWS3ZKOXVPcm1Y?= =?utf-8?B?VXlxbjZmQ2R0YVNJeWQ5aXhiRmtqTHIzSmQxd3VPMWs1SWViWlk0Si9QeFlw?= =?utf-8?B?Z0pHUmw4UEN0aEpuZG9GMVRzcFZWSDdDZDBKUXJzdWF5TkhtZzNKcWdnM2hq?= =?utf-8?B?YTJWSU9wS2s2cVVLa2dEWVZZNEV1NHZIbXIzcGdSVDJqN3dQQ1B5Q1A0cUgv?= =?utf-8?B?WllQYWdXOGh5UldDMWQ4V1puSTNQN3dLMlZ2cE1sSUQ1RTJMZDBvNjU4MG9z?= =?utf-8?B?azVpR01Ic1IvU1I0dWNlMWtXMVZMTytmZDZWYnMySDRxaWJ5VTIya2NPTita?= =?utf-8?B?ZVEwbVJaRWlrdGZ2UXJ0TE5HNk5xSWRHWE9kaTYzd0EvQStjR3d5VjVRTDR2?= =?utf-8?B?Y0NjMlN2SGF4aUJoTkVxZHVONUtYa0h5WUdLZHVJT3hIS0NHdFNXNjJaZEdR?= =?utf-8?B?RkhFVlFIS25FWHFtL0FBRURiL2phVlVxZGVwdU5kMFhGUGRSRkEvRmRhajFi?= =?utf-8?B?V05RRnNOeTRwU0xFQklzTy9PY0wzdWxwaUxnUzIxLzg1eG1vYUxsc2g3WlhY?= =?utf-8?B?V1NUVk5CaS9lejRURGlBeVdlOGVDOWRES1FReTNvQ3MwaUNRMXUxRXp5UDMw?= =?utf-8?B?enA4QWVzcFFqUFNYUHBoT05kekhLTytRdG1EYzZWNU4yM1l5aWlvaTc0VHBx?= =?utf-8?B?UFhNQzFQcHMzR29MZ1ZoajU3ZUtnLzBnaGszTHhEcWtIaTNXSUdGWlJyZ2s4?= =?utf-8?B?aHJrMHhpL2kxdHk3djZNU2RKWkhGOU9aNlVMUW5mWWhZcHpZQ0NyUUVSNmUr?= =?utf-8?B?cEEwczgzWEFnWVNyYWNIZisrS1VhMG1VVFUyMThUV1lOdFh0NnFrNDgzUGZu?= =?utf-8?B?Q2JDWTdXYncvMDdIamRGK3IzaCtxK01TV05ZWi90Q3d4dmdrb0gxZGFLNEZS?= =?utf-8?B?R3g1cEVtSFRsV2gvN2E0TzFBWlhyMVhjY1NkMWRISmp1OW1rM0prcmkzdTZJ?= =?utf-8?Q?PmKeV7f9ZtIPIXlwQ9yLrLMSi?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f555947-48a4-435b-1d10-08daf37fa4e8 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2023 02:57:58.1760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9DKOwpt7IFBFYcYpNTfcK2fW7EY2xLKiOGz3lYNp9yHUGQxbGuGTScO4/xNBHz6kq9yRfQcaX4EVQC4kF7HRlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7022 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_185807_917413_F17C4C4E X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org +Sandor On 1/10/2023 5:39 PM, Lucas Stach wrote: > Hi Peng, > > Am Dienstag, dem 10.01.2023 um 10:25 +0800 schrieb Peng Fan: >> >> On 1/10/2023 12:12 AM, Lucas Stach wrote: >>> Same as done for both LCDIF interfaces in the MEDIA domain, set >>> the panic priority of the LCDIF instance in the HDMI domain to >>> the maximium NoC priority of 7 to minimize chances of display >>> underflows. >>> >>> Signed-off-by: Lucas Stach >>> --- >>> drivers/soc/imx/imx8mp-blk-ctrl.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/soc/imx/imx8mp-blk-ctrl.c b/drivers/soc/imx/imx8mp-blk-ctrl.c >>> index 0629f64ef4f1..28458ed1793b 100644 >>> --- a/drivers/soc/imx/imx8mp-blk-ctrl.c >>> +++ b/drivers/soc/imx/imx8mp-blk-ctrl.c >>> @@ -300,6 +300,7 @@ static const struct imx8mp_blk_ctrl_data imx8mp_hsio_blk_ctl_dev_data = { >>> #define HDMI_RTX_CLK_CTL3 0x70 >>> #define HDMI_RTX_CLK_CTL4 0x80 >>> #define HDMI_TX_CONTROL0 0x200 >>> +#define HDMI_LCDIF_NOC_HURRY_MASK GENMASK(14, 12) >>> >>> static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc, >>> struct imx8mp_blk_ctrl_domain *domain) >>> @@ -316,6 +317,8 @@ static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc, >>> regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(11)); >>> regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, >>> BIT(4) | BIT(5) | BIT(6)); >>> + regmap_set_bits(bc->regmap, HDMI_TX_CONTROL0, >>> + FIELD_PREP(HDMI_LCDIF_NOC_HURRY_MASK, 7)); >>> break; >>> case IMX8MP_HDMIBLK_PD_PAI: >>> regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(17)); >> >> For the LCDIF, Reviewed-by: Peng Fan >> >> BTW: will you also add HRV hurry level? If not, I could also post a patch. >> > Sure, I can post a patch for that. However, I would really appreciate > if NXP made some information available on how HRV is actually > working/used. The reference manual is lacking a lot in that regard. I know little about HDMI, loop HDMI SW owner Sandor to help. Regards, Peng. > > Regards, > Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel