public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] of/fdt: factor out assignment of initrd_start/initrd_end
Date: Thu, 11 Feb 2016 23:12:18 +0100	[thread overview]
Message-ID: <3591081.dypcHcG82d@wuerfel> (raw)
In-Reply-To: <1455209282-9596-2-git-send-email-ard.biesheuvel@linaro.org>

On Thursday 11 February 2016 17:48:00 Ard Biesheuvel wrote:
> 
>  #ifdef CONFIG_BLK_DEV_INITRD
> +void __weak __early_init_dt_declare_initrd(unsigned long start,
> +                                          unsigned long end)
> +{
> +       initrd_start = (unsigned long)__va(start);
> +       initrd_end = (unsigned long)__va(end);
> +       initrd_below_start_ok = 1;
> +}
> +
> 

I find __weak functions particularly hard to follow, I think a Kconfig
symbols or a function you can override by defining a macro in asm/memory.h
would be nicer.

	Arnd

  reply	other threads:[~2016-02-11 22:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 16:47 [PATCH v2 0/3] arm64: avoid early __va translations Ard Biesheuvel
2016-02-11 16:48 ` [PATCH v2 1/3] of/fdt: factor out assignment of initrd_start/initrd_end Ard Biesheuvel
2016-02-11 22:12   ` Arnd Bergmann [this message]
2016-02-12  8:08     ` Ard Biesheuvel
2016-02-11 16:48 ` [PATCH v2 2/3] arm64: defer __va translation of initrd_start and initrd_end Ard Biesheuvel
2016-02-11 16:48 ` [PATCH v2 3/3] arm64: prevent __va() translations before memstart_addr is assigned Ard Biesheuvel
2016-02-12 11:49   ` Will Deacon
2016-02-12 11:51     ` Ard Biesheuvel
2016-02-12 12:09       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3591081.dypcHcG82d@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox