From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gary Yang <gary.yang@cixtech.com>,
Peter Chen <peter.chen@cixtech.com>,
Fugang Duan <fugang.duan@cixtech.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
cix-kernel-upstream <cix-kernel-upstream@cixtech.com>
Subject: Re: 回复: [PATCH] arm64: dts: cix: Add scmi powerdomain nodes for sky1
Date: Mon, 9 Mar 2026 08:11:15 +0100 [thread overview]
Message-ID: <35d95042-62dc-467b-b9f4-012ed0cd76f8@kernel.org> (raw)
In-Reply-To: <PUZPR06MB58876D6D6752128F8F0154B7EF79A@PUZPR06MB5887.apcprd06.prod.outlook.com>
On 09/03/2026 02:56, Gary Yang wrote:
> Hi Krzysztof:
>
> Thanks for your comments
>
>> EXTERNAL EMAIL
>>
>> On 06/03/2026 10:06, Gary Yang wrote:
>>> Add a second SCMI channel using SMC transport to communicate with TF-A
>>> for power domain management on the Sky1 SoC.
>>>
>>> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
>>> ---
>>> arch/arm64/boot/dts/cix/sky1-power.h | 34
>>> ++++++++++++++++++++++++++++
>>
>> Why do you add dead code?
>>
>
> The power domain serves as the foundation for serval modules with independent power domains.
So you add dead code because power domains are foundation? No. Dead code
is still dead code.
> For example, you will see GPU patch based on this patch soon. SKY1_PD_GPU is used in its dts node.
There is no such patch.
>
> If take any mistakes or miss any information, please let us know.
Don't ever add dead code.
>
Best regards,
Krzysztof
prev parent reply other threads:[~2026-03-09 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 9:06 [PATCH] arm64: dts: cix: Add scmi powerdomain nodes for sky1 Gary Yang
2026-03-07 15:23 ` Krzysztof Kozlowski
2026-03-09 1:56 ` 回复: " Gary Yang
2026-03-09 7:11 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35d95042-62dc-467b-b9f4-012ed0cd76f8@kernel.org \
--to=krzk@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=gary.yang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox