From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>,
p.zabel@pengutronix.de, mchehab@kernel.org, heiko@sntech.de
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v6] media: verisilicon: Create AV1 helper library
Date: Thu, 19 Nov 2026 16:45:25 -0500 [thread overview]
Message-ID: <3611eee93f6d48bbe7de642abd238c7da147eaa2.camel@collabora.com> (raw)
In-Reply-To: <ac588bfc-94f3-4ad7-9808-92ea0db1d017@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 1630 bytes --]
Hi,
Le lundi 16 novembre 2026 à 14:33 +0100, Benjamin Gaignard a écrit :
> Le 10/09/2026 à 11:20, Benjamin Gaignard a écrit :
> > Regroup all none hardware related AV1 functions into a helper library.
> > The goal is to avoid code duplication for future AV1 codecs.
> >
> > Tested on rock 5b board Fluster score remains the same 204/241.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> > Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
>
> Gentle ping on this patch.
Nice ping, but it does not apply. I've manually applied it, but will leave to
you to retest.
https://gitlab.freedesktop.org/linux-media/users/ndufresne/-/commit/c98580a49562a26d2cfc11fc0eb88e6e75f329d8
While doing so I notice few hidden changes:
rockchip_vpu981_av1_dec_luma_size -> hantro_av1_luma_size:
- return ctx->dst_fmt.width * ctx->dst_fmt.height * ctx->bit_depth / 8;
+ return ctx->ref_fmt.plane_fmt[0].bytesperline * ctx->ref_fmt.height;
Change is really good, and it allows for padding, but totally undocumented, and
would be better placed in its own commit. And then couple of bound check, which:
int hantro_av1_get_frame_index(struct hantro_ctx *ctx, int ref):
+ if (ref < 0 || ref >= V4L2_AV1_REFS_PER_FRAME)
+ return AV1_INVALID_IDX;
void hantro_av1_set_prob(struct hantro_ctx *ctx):
} else {
+ if (frame->primary_ref_frame < 0 ||
+ frame->primary_ref_frame >= V4L2_AV1_REFS_PER_FRAME)
+ return;
These should clearly be prepend patches with Fixes tag for backport, and not
hidden in the rework. Looking for your v7.
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-11-19 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 9:20 [PATCH v6] media: verisilicon: Create AV1 helper library Benjamin Gaignard
[not found] ` <ac588bfc-94f3-4ad7-9808-92ea0db1d017@collabora.com>
2026-11-19 21:45 ` Nicolas Dufresne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3611eee93f6d48bbe7de642abd238c7da147eaa2.camel@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox