From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8F67C04AAF for ; Sat, 18 May 2019 15:07:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E23120848 for ; Sat, 18 May 2019 15:07:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HrE2r+hs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E23120848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jzJ1MfOkdzggGtl/voNUhLdYd8soykXW32Um8YRBl7Q=; b=HrE2r+hsp0gDau Wb4XfjvbvsKzHyPzvTXqvjBPxR8wmZkYq/bmNCIRw2axPG+Z/trjYPnuRAuDFy6qMZ0WaT4hrlFx7 lMULFWm82xAetleL/EbUBWZcIWP8FDP/OX6wF8UmeM0551HoxLEZLnIUB8ZEsJ30xKvqiLdyAnmlr r7uHffbYbWGZWhhLqZk69mzIeVU+ShyZzT1w+ZgZcVYm2te7Ui4BQ/ju4xaCdWIBOw9UHRwDvTTOg hL7zuIbVjZCgA7uDuN5L0+6fZ+M9dFjPPlH3m7UQ6UzwDrbq2LwtEdSHaEcEY9lfLBcx7aRm3MTLo lftEHeuXpfv97uhnh0wA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hS0vn-0006bz-Qr; Sat, 18 May 2019 15:07:27 +0000 Received: from mailoutvs18.siol.net ([185.57.226.209] helo=mail.siol.net) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hS0vk-0006b9-3o for linux-arm-kernel@lists.infradead.org; Sat, 18 May 2019 15:07:26 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 0CAD3520CA6; Sat, 18 May 2019 17:07:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 5YviEmiBTKUs; Sat, 18 May 2019 17:07:12 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id B1759520CBE; Sat, 18 May 2019 17:07:12 +0200 (CEST) Received: from jernej-laptop.localnet (cpe-86-58-52-202.static.triera.net [86.58.52.202]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id E64AC520CA6; Sat, 18 May 2019 17:07:11 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard Subject: Re: [PATCH] ARM: dts: sun8i-h3: Fix wifi in Beelink X2 DT Date: Sat, 18 May 2019 17:07:11 +0200 Message-ID: <36237813.UWQAqNRFN9@jernej-laptop> In-Reply-To: <20190517073048.y6mzgbhhryfmuckl@flea> References: <20190516161039.18534-1-jernej.skrabec@siol.net> <20190517073048.y6mzgbhhryfmuckl@flea> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190518_080724_317470_D43C8D3A X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne petek, 17. maj 2019 ob 09:30:48 CEST je Maxime Ripard napisal(a): > Hi, > > On Thu, May 16, 2019 at 06:10:39PM +0200, Jernej Skrabec wrote: > > mmc1 node where wifi module is connected doesn't have properly defined > > power supplies so wifi module is never powered up. Fix that by > > specifying additional power supplies. > > > > Additionally, this STB may have either Realtek or Broadcom based wifi > > module. One based on Broadcom module also needs external clock to work > > properly. Fix that by adding clock property to wifi_pwrseq node. > > > > Fixes: e582b47a9252 ("ARM: dts: sun8i-h3: Add dts for the Beelink X2 STB") > > Signed-off-by: Jernej Skrabec > > --- > > > > arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts > > b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts index > > 6277f13f3eb3..6a0ac85b4616 100644 > > --- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts > > +++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts > > @@ -89,7 +89,10 @@ > > > > wifi_pwrseq: wifi_pwrseq { > > > > compatible = "mmc-pwrseq-simple"; > > > > + pinctrl-names = "default"; > > pinctrl-names only make sense with another pinctrl-[0-255] > property. Did you forgot something here? No, I just took BananaPi M2+ as a example, which has pinctrl-names property too and no "pinctrl-*". But digging through history of this DT, it seems that this is just leftover which somebody forgot to remove. I'll send v2. Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel