From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFD95606A32C for ; Wed, 18 Nov 2026 16:46:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=tFPfQve0; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=M1H70kVD DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=7vXdMQjHN2tTjiwu1xZjW5W55857Pr3ga74FJdrpcT4=; b=tFPfQve0pp6GFN czJXEzDbvXZaABAxgymsFmOoMOPsGAgSfizn4lQOm/coMk4OapEOp3uW8rHGBo6QYz5Y6hYFvD0ld 7z88xJqPrfghnScJVPxOhxxETbIoXjZ/4Qax1Gc5ec7jNdl2trT6jcoaRmY1uSPKEnpFvxsfQoKGX YVYf1wMmJGXczsKNBglCYxOShUonwmknuvOUnv1vGb1E27v2mf0ysgBD/stY/8Qo1fKE7oTtqToX/ pf/8aINbsQO3M/oHbnAD1E+cgRbLf8xQ7i5/suURqcCNBRZaweLdgAEvSA1Ey5riGe25JcmbwStDf FoRttBZsmdCWt2yRVJbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTinP-00000009ZAV-1i3g; Wed, 18 Nov 2026 16:46:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTinN-00000009ZAB-0yxF for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2026 16:46:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BB298143D; Wed, 18 Nov 2026 08:46:00 -0800 (PST) Received: from [10.2.212.8] (e134344.arm.com [10.2.212.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A83AC3F673; Wed, 18 Nov 2026 08:46:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1795020363; bh=+PGfD/kjAVlPKhwHC0ibkDnGPTsKDJpyDcno2kNuw1Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=M1H70kVDxTMmz35+x9UnmPHajhkSeQKmH8+tgplZBxaWRm3/nE7C4Ph5OlqTlqXUO jqO8sdiI53wrJSvPpAir4RX8ksqh7sYUDwm+xhWkZ2qr6vtag6fhGgTFnA/bbWXhPl 4P0BnCcX3JuYGxCqsFl76gsRqnAbcX+i9Ny3Fe0g= Message-ID: <36314b21-6471-4e27-af4e-957c4eab0505@arm.com> Date: Wed, 18 Nov 2026 16:46:00 +0000 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/8] arm_mpam: resctrl: Use find_component() when allocating a domain To: Reinette Chatre , james.morse@arm.com, Dave.Martin@arm.com, fenghuay@nvidia.com, ruanjinjie@huawei.com Cc: tony.luck@intel.com, yu.c.chen@intel.com, babu.moger@amd.com, fustini@kernel.org, tan.shaopeng@fujitsu.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev References: Content-Language: en-US From: Ben Horgan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261118_084605_339732_2A976DD9 X-CRM114-Status: GOOD ( 19.18 ) X-Spam-Score: -4.4 (----) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Hi Reinette, On 10/11/2026 04:19, Reinette Chatre wrote: > mpam_resctrl_alloc_domain() starts by checking that the resource's > class has a component whose CPU affinity includes the CPU, and fails the > domain allocation otherwise. When the resource supports allocation, that > component also backs the control domain. The check uses an open-coded > walk of the class's component list, while the same function uses > find_component() to find the component backing each monitoring event. > > The open-coded walk duplicates find_component(). It also holds the SRCU > read lock until mpam_resctrl_alloc_domain() returns. However, the SRCU > read lock is only needed while walking the component list, and > find_component() holds it for that walk. > > Replace the open-coded walk with find_component(). > > Signed-off-by: Reinette Chatre > Tested-by: Jinjie Ruan > Reviewed-by: Jinjie Ruan Looks good to me. Reviewed-by: Ben Horgan > --- > Changes since RFC v2: > - Add Jinjie's Reviewed-by tag. > - Add Jinjie's Tested-by tag. > - Shorten changelog. (Ben) > --- > drivers/resctrl/mpam_resctrl.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/resctrl/mpam_resctrl.c b/drivers/resctrl/mpam_resctrl.c > index 1b1e724ae040..a75f653031fd 100644 > --- a/drivers/resctrl/mpam_resctrl.c > +++ b/drivers/resctrl/mpam_resctrl.c > @@ -1648,21 +1648,12 @@ mpam_resctrl_alloc_domain(unsigned int cpu, struct mpam_resctrl_res *res) > struct rdt_l3_mon_domain *mon_d; > struct rdt_ctrl_domain *ctrl_d; > struct mpam_class *class = res->class; > - struct mpam_component *comp_iter, *ctrl_comp; > + struct mpam_component *ctrl_comp; > struct rdt_resource *r = &res->resctrl_res; > > lockdep_assert_held(&domain_list_lock); > > - ctrl_comp = NULL; > - guard(srcu)(&mpam_srcu); > - list_for_each_entry_srcu(comp_iter, &class->components, class_list, > - srcu_read_lock_held(&mpam_srcu)) { > - if (cpumask_test_cpu(cpu, &comp_iter->affinity)) { > - ctrl_comp = comp_iter; > - break; > - } > - } > - > + ctrl_comp = find_component(class, cpu); > /* class has no component for this CPU */ > if (WARN_ON_ONCE(!ctrl_comp)) > return ERR_PTR(-EINVAL);