public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] oxnas: select reset controller framework
Date: Wed, 06 Jul 2016 15:21:40 +0200	[thread overview]
Message-ID: <3635781.NJKnVkuV7s@wuerfel> (raw)
In-Reply-To: <CAA3gFWsg7E3tczzroQfNLayiUQhdoWxa-rYJys83Z5saJ6kMaw@mail.gmail.com>

On Wednesday, July 6, 2016 3:04:25 PM CEST Neil Armstrong wrote:
> 2016-07-06 14:48 GMT+02:00 Arnd Bergmann <arnd@arndb.de>:
> > For unknown reasons, we have to enable three symbols for a platform
> > to use a reset controller driver, otherwise we get a Kconfig
> > warning:
> >
> > warning: (MACH_OX810SE) selects RESET_OXNAS which has unmet direct dependencies (RESET_CONTROLLER)
> >
> > This selects the other two symbols for oxnas.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  arch/arm/mach-oxnas/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/mach-oxnas/Kconfig b/arch/arm/mach-oxnas/Kconfig
> > index 2dde0acf01fd..b6a36d660e6f 100644
> > --- a/arch/arm/mach-oxnas/Kconfig
> > +++ b/arch/arm/mach-oxnas/Kconfig
> > @@ -11,11 +11,13 @@ if ARCH_OXNAS
> >
> >  config MACH_OX810SE
> >         bool "Support OX810SE Based Products"
> > +       select ARCH_HAS_RESET_CONTROLLER
> 
> This is strange since this is selected by CONFIG_ARCH_OXNAS !
> 

You are right, this one is not needed.

> >         select ARM_TIMER_SP8
> >         select COMMON_CLK_OXNAS
> >         select CPU_ARM926T
> >         select MFD_SYSCON
> >         select PINCTRL_OXNAS
> > +       select RESET_CONTROLLER
> 
> Same here, it should be selected by ARCH_HAS_RESET_CONTROLLER

I actually did a patch at one point to kill off ARCH_HAS_RESET_CONTROLLER
completely, it's not really needed at all, but that is a larger rework
so (I think) I never submitted it.

	Arnd

      reply	other threads:[~2016-07-06 13:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06 12:48 [PATCH] oxnas: select reset controller framework Arnd Bergmann
2016-07-06 13:04 ` Neil Armstrong
2016-07-06 13:21   ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3635781.NJKnVkuV7s@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox