From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C85DAC3B187 for ; Wed, 12 Feb 2020 22:36:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DA9521569 for ; Wed, 12 Feb 2020 22:36:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sGfRihj1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DA9521569 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ulHMpRB7HTj9/zerIwmw7HzCiUBj2NEl2lX5UcfN95A=; b=sGfRihj15cWS1w RybJT+Zdy8COlzKx3n37kk1J6a7WTn28fqMf0ytYG6NjigKFV7aS/wf1b3nXq+iT8SPUPUhC6NOID lWRbOFdocpu2hnDMUUpD955jWSe+tCaTC9f2aX7AKV5lxSt0ZwqvuPgzhWsXercNOQkZeahEmyIb2 oCNQj10+C48+X0RgDz8juyW+yrfMuDLck+UX1WSgFKGuxZoJO6gx81AL/c6IhP75Al3Me95mm/Sdz /XLQx1cFbE4FfIRcKjOtXAOVq+yPgmKuLgYm36GWGA/Poes8TuPEtZBhj+oLiajzwwHn2/WOHus1p A+2ET+HEfzJ4DMWWo1vQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j20cM-000738-GI; Wed, 12 Feb 2020 22:36:26 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j20cK-00072A-2g; Wed, 12 Feb 2020 22:36:25 +0000 Received: from p508fd8fe.dip0.t-ipconnect.de ([80.143.216.254] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1j20cF-0001ua-8B; Wed, 12 Feb 2020 23:36:19 +0100 From: Heiko Stuebner To: Justin Swartz Subject: Re: [PATCH] clk: rockchip: fix incorrect configuration of rk3228 aclk_gpu* clocks Date: Wed, 12 Feb 2020 23:36:18 +0100 Message-ID: <3638560.bLjz2vc75D@phil> In-Reply-To: <20200114162503.7548-1-justin.swartz@risingedge.co.za> References: <20200114162503.7548-1-justin.swartz@risingedge.co.za> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200212_143624_271515_34ED52BB X-CRM114-Status: GOOD ( 11.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Michael Turquette , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Justin, Am Dienstag, 14. Januar 2020, 17:25:02 CET schrieb Justin Swartz: > The following changes prevent the unrecoverable freezes and rcu_sched > stall warnings experienced in each of my attempts to take advantage of > lima. > > Replace the COMPOSITE_NOGATE definition of aclk_gpu_pre with a > COMPOSITE that retains the selection of HDMIPHY as the PLL source, but > instead makes uses of the aclk_gpu PLL source gate and parent names > defined by mux_pll_src_4plls_p rather than mux_aclk_gpu_pre_p. > > Remove the now unused mux_aclk_gpu_pre_p and the four named but also > unused definitions (cpll_gpu, gpll_gpu, hdmiphy_gpu and usb480m_gpu) > of the aclk_gpu PLL source gate. > > Use the correct gate offset for aclk_gpu and aclk_gpu_noc. > > Signed-off-by: Justin Swartz thanks a lot for diving through the clock controller and fixing the issues. I've checked against the TRM as well and the previous state was quite wrong and your changes match the hardware manual. I've applied it as fix for 5.6 now. Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel