public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: Samsung: add missing I2C/SPI dependencies
Date: Thu, 29 Jan 2015 15:23:33 +0100	[thread overview]
Message-ID: <3641576.5ROmxlmVfH@wuerfel> (raw)
In-Reply-To: <20150129114134.GC21293@sirena.org.uk>

On Thursday 29 January 2015 11:41:34 Mark Brown wrote:
> On Wed, Jan 28, 2015 at 10:28:55PM +0100, Arnd Bergmann wrote:
> > The SND_SOC_ARNDALE_RT5631_ALC5631 selects the rt5631 codec
> > that requires I2C to work, so we get a build error if I2C
> > is disabled:
> 
> You rather buried the lead about there being other drivers in this
> changelog, makes the code a bit surprising when you find it.
> 
> >  config SND_SOC_SPEYSIDE
> >  	tristate "Audio support for Wolfson Speyside"
> > -	depends on SND_SOC_SAMSUNG && MACH_WLF_CRAGG_6410
> > +	depends on SND_SOC_SAMSUNG && MACH_WLF_CRAGG_6410 && SPI_MASTER
> >  	select SND_SAMSUNG_I2S
> >  	select SND_SOC_WM8996
> >  	select SND_SOC_WM9081
> 
> Why only add a dependency on SPI here?

I don't know, definitely my mistake. I had squashed three older patches
together here, which resulted in the slightly strange changelog (I
picked the one that explained it best and then tried to modify it
to cover all changes) as well as the missing I2C dependency.

I'll re-check all other drivers in this directory too and then send
a new patch.

	Arnd

      reply	other threads:[~2015-01-29 14:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 21:28 [PATCH] ASoC: Samsung: add missing I2C/SPI dependencies Arnd Bergmann
2015-01-29 11:41 ` Mark Brown
2015-01-29 14:23   ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3641576.5ROmxlmVfH@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox