From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mvebu: fix compilation warning on Armada 370 (i.e. non-SMP)
Date: Mon, 20 Jan 2014 21:18:11 +0100 [thread overview]
Message-ID: <3644485.dCdZFrR2be@wuerfel> (raw)
In-Reply-To: <87r48276ne.fsf@natisbad.org>
On Monday 20 January 2014 21:14:13 Arnaud Ebalard wrote:
> diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c
> index 433cc8568dec..499c5070f841 100644
> --- a/drivers/irqchip/irq-armada-370-xp.c
> +++ b/drivers/irqchip/irq-armada-370-xp.c
> @@ -59,7 +59,9 @@
> #define PCI_MSI_DOORBELL_END (32)
> #define PCI_MSI_DOORBELL_MASK 0xFFFF0000
>
> +#ifdef CONFIG_SMP
> static DEFINE_RAW_SPINLOCK(irq_controller_lock);
> +#endif
>
> static void __iomem *per_cpu_
How about moving it inside of the existing #ifdef?
That also brings it closer to the one place it's used.
Arnd
next prev parent reply other threads:[~2014-01-20 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 20:14 [PATCH] ARM: mvebu: fix compilation warning on Armada 370 (i.e. non-SMP) Arnaud Ebalard
2014-01-20 20:18 ` Arnd Bergmann [this message]
2014-01-20 21:42 ` Arnaud Ebalard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3644485.dCdZFrR2be@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).