From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 916F6EB64D7 for ; Wed, 14 Jun 2023 02:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zhzDHrb/cBIcznOyUjV2r4IrefuFZs41YUypdpLXjug=; b=hEUIjBJ5w6sxQz cp+D2flkJ7nSIGk9wcYoCFl4+PlH9ii8qrkSNOAEC6gDzhLLHVHyQwb/a0szpduqvNAcLH/EOYBGK vmF1gcQX5mM8b4RjZ+F2V80WgIzZ8vqRdefBUlsoTgxVIQIYx3/K7eVv2uAuu13jQ2bIT/P/D4GMS 1TjFaECFRn4AGVGAOrGD+RVqPSwoZS48mDRF5BuxxPxEeg1dQpwTismqFxY6hTRdh6c7Bum1eLCwr m8/jmI9QdCowmtuQO5M7g2GTke/+HzSBUx5kohwPRD/+q2IyfNnzqoTlY5cJmd7nKYgTjwrmaY7Vk e1M8QpWvuc1eVTZ59rgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9GjN-009mg5-2O; Wed, 14 Jun 2023 02:59:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9GjG-009me9-0z for linux-arm-kernel@lists.infradead.org; Wed, 14 Jun 2023 02:59:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CE9871FB; Tue, 13 Jun 2023 20:00:01 -0700 (PDT) Received: from [10.163.46.15] (unknown [10.163.46.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5D9DB3F663; Tue, 13 Jun 2023 19:59:12 -0700 (PDT) Message-ID: <36489061-d646-ab9c-6365-d5f7e8ed5bd5@arm.com> Date: Wed, 14 Jun 2023 08:29:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH V11 02/10] arm64/perf: Add BRBE registers and fields Content-Language: en-US To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, Mark Brown , James Clark , Rob Herring , Marc Zyngier , Suzuki Poulose , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org References: <20230531040428.501523-1-anshuman.khandual@arm.com> <20230531040428.501523-3-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_195926_409166_69C1BE6E X-CRM114-Status: GOOD ( 14.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/13/23 21:57, Mark Rutland wrote: > On Wed, May 31, 2023 at 09:34:20AM +0530, Anshuman Khandual wrote: >> This adds BRBE related register definitions and various other related field >> macros there in. These will be used subsequently in a BRBE driver which is >> being added later on. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Marc Zyngier >> Cc: Mark Rutland >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Tested-by: James Clark >> Reviewed-by: Mark Brown >> Signed-off-by: Anshuman Khandual >> --- >> arch/arm64/include/asm/sysreg.h | 103 +++++++++++++++++++++ >> arch/arm64/tools/sysreg | 159 ++++++++++++++++++++++++++++++++ >> 2 files changed, 262 insertions(+) > >> +SysregFields BRBINFx_EL1 > >> +Enum 1:0 VALID >> + 0b00 NONE >> + 0b01 TARGET >> + 0b10 SOURCE >> + 0b11 FULL >> +EndEnum > > This looks correct... > > [...] > >> +Sysreg BRBINFINJ_EL1 2 1 9 1 0 > >> +Enum 1:0 VALID >> + 0b00 NONE >> + 0b01 TARGET >> + 0b10 SOURCE >> + 0b00 FULL >> +EndEnum > > ... but this clearly isn't. Fixed VALID_FULL as 0b11. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel