From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B6E7C43461 for ; Mon, 7 Sep 2020 08:56:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D95302078E for ; Mon, 7 Sep 2020 08:56:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="icLXO1mD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="erArDS/k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D95302078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+QvS00UWwmtKaR3vne/qL14TTxjUT/BVFIj4MtWgq0E=; b=icLXO1mDfAYo0qDlHbCkylCRI 7iLFl8UTlE2rUb/+c/ZamMCQdgfq9viL2P+FniZrSdRTgB163GSb3gTYRqS9a+ZplQdZXSvitjQMl AykWUwN9hUuJI9HeapT0sX1eRsX1hOjL9djuiB2d/nwKa+ITnbQZASjOASyYI/Y0odjdG1/8yB1D5 kyB501Zv4+ABZyeQ2DB9RaGXiWZ8Wv+JKvbrfJN0TIT2/eSnRWfk/2ZUhWh7WoEmO14/fV4hJuPxc Jnt6KsXUL0DJUuHXSRAGwnZqlvYr3wFu+fu/K+Lc6UmHRdsv4bdF00TXM1ivSZJQWuQQdf0SZ3Rh2 nfVSs0gDA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFCvW-0007RY-Vf; Mon, 07 Sep 2020 08:55:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFCvU-0007R0-LS for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 08:55:01 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 82AF720757; Mon, 7 Sep 2020 08:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599468899; bh=h0dzECAlJcaUj2DyOGtmStzWmm1Oimzbwx2te+tHEwU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=erArDS/k5tl0YdDvN8AQKEBXad+mxvHAMDPO1ZzBi4LTztrqdD8bEVz+C8WT+Nc5l avyVnLlnU+sU2hSd0kICBhZxf+eAkQAaKhZ5ZKqt6lJEFg5crYUfmmXPAXdqVxI2B+ S+zXVCN1qryM2oFOI5PrvKTLWQ4OmTTYl4RooQXM= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kFCvR-009iBY-K7; Mon, 07 Sep 2020 09:54:57 +0100 MIME-Version: 1.0 Date: Mon, 07 Sep 2020 09:54:57 +0100 From: Marc Zyngier To: Jianyong Wu Subject: Re: [PATCH v14 08/10] ptp: arm64: Enable ptp_kvm for arm64 In-Reply-To: References: <20200904092744.167655-1-jianyong.wu@arm.com> <20200904092744.167655-9-jianyong.wu@arm.com> <874kocmqqx.wl-maz@kernel.org> User-Agent: Roundcube Webmail/1.4.8 Message-ID: <366387fa507f9c5d5044549cea958ce1@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: Jianyong.Wu@arm.com, netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, richardcochran@gmail.com, Mark.Rutland@arm.com, will@kernel.org, Suzuki.Poulose@arm.com, Steven.Price@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, Justin.He@arm.com, nd@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_045500_950185_4527B18E X-CRM114-Status: GOOD ( 37.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Justin He , kvm@vger.kernel.org, Suzuki Poulose , netdev@vger.kernel.org, richardcochran@gmail.com, Steve Capper , linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, Steven Price , john.stultz@linaro.org, yangbo.lu@nxp.com, pbonzini@redhat.com, tglx@linutronix.de, nd , will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-09-07 09:40, Jianyong Wu wrote: > Hi Marc, > >> -----Original Message----- >> From: Marc Zyngier >> Sent: Saturday, September 5, 2020 7:02 PM >> To: Jianyong Wu >> Cc: netdev@vger.kernel.org; yangbo.lu@nxp.com; john.stultz@linaro.org; >> tglx@linutronix.de; pbonzini@redhat.com; >> sean.j.christopherson@intel.com; >> richardcochran@gmail.com; Mark Rutland ; >> will@kernel.org; Suzuki Poulose ; Steven Price >> ; linux-kernel@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; kvmarm@lists.cs.columbia.edu; >> kvm@vger.kernel.org; Steve Capper ; Justin He >> ; nd >> Subject: Re: [PATCH v14 08/10] ptp: arm64: Enable ptp_kvm for arm64 >> >> On Fri, 04 Sep 2020 10:27:42 +0100, >> Jianyong Wu wrote: >> > >> > Currently, there is no mechanism to keep time sync between guest and >> > host in arm64 virtualization environment. Time in guest will drift >> > compared with host after boot up as they may both use third party time >> > sources to correct their time respectively. The time deviation will be >> > in order of milliseconds. But in some scenarios,like in cloud >> > envirenment, we ask for higher time precision. >> > >> > kvm ptp clock, which choose the host clock source as a reference clock >> > to sync time between guest and host, has been adopted by x86 which >> > makes the time sync order from milliseconds to nanoseconds. >> > >> > This patch enables kvm ptp clock for arm64 and improve clock sync >> > precison significantly. >> > >> > Test result comparisons between with kvm ptp clock and without it in >> > arm64 are as follows. This test derived from the result of command >> > 'chronyc sources'. we should take more care of the last sample column >> > which shows the offset between the local clock and the source at the last >> measurement. >> > >> > no kvm ptp in guest: >> > MS Name/IP address Stratum Poll Reach LastRx Last sample >> > >> ========================================================== >> ============== >> > ^* dns1.synet.edu.cn 2 6 377 13 +1040us[+1581us] +/- 21ms >> > ^* dns1.synet.edu.cn 2 6 377 21 +1040us[+1581us] +/- 21ms >> > ^* dns1.synet.edu.cn 2 6 377 29 +1040us[+1581us] +/- 21ms >> > ^* dns1.synet.edu.cn 2 6 377 37 +1040us[+1581us] +/- 21ms >> > ^* dns1.synet.edu.cn 2 6 377 45 +1040us[+1581us] +/- 21ms >> > ^* dns1.synet.edu.cn 2 6 377 53 +1040us[+1581us] +/- 21ms >> > ^* dns1.synet.edu.cn 2 6 377 61 +1040us[+1581us] +/- 21ms >> > ^* dns1.synet.edu.cn 2 6 377 4 -130us[ +796us] +/- 21ms >> > ^* dns1.synet.edu.cn 2 6 377 12 -130us[ +796us] +/- 21ms >> > ^* dns1.synet.edu.cn 2 6 377 20 -130us[ +796us] +/- 21ms >> > >> > in host: >> > MS Name/IP address Stratum Poll Reach LastRx Last sample >> > >> ========================================================== >> ============== >> > ^* 120.25.115.20 2 7 377 72 -470us[ -603us] +/- 18ms >> > ^* 120.25.115.20 2 7 377 92 -470us[ -603us] +/- 18ms >> > ^* 120.25.115.20 2 7 377 112 -470us[ -603us] +/- 18ms >> > ^* 120.25.115.20 2 7 377 2 +872ns[-6808ns] +/- 17ms >> > ^* 120.25.115.20 2 7 377 22 +872ns[-6808ns] +/- 17ms >> > ^* 120.25.115.20 2 7 377 43 +872ns[-6808ns] +/- 17ms >> > ^* 120.25.115.20 2 7 377 63 +872ns[-6808ns] +/- 17ms >> > ^* 120.25.115.20 2 7 377 83 +872ns[-6808ns] +/- 17ms >> > ^* 120.25.115.20 2 7 377 103 +872ns[-6808ns] +/- 17ms >> > ^* 120.25.115.20 2 7 377 123 +872ns[-6808ns] +/- 17ms >> > >> > The dns1.synet.edu.cn is the network reference clock for guest and >> > 120.25.115.20 is the network reference clock for host. we can't get >> > the clock error between guest and host directly, but a roughly >> > estimated value will be in order of hundreds of us to ms. >> > >> > with kvm ptp in guest: >> > chrony has been disabled in host to remove the disturb by network clock. >> > >> > MS Name/IP address Stratum Poll Reach LastRx Last sample >> > >> ========================================================== >> ============== >> > * PHC0 0 3 377 8 -7ns[ +1ns] +/- 3ns >> > * PHC0 0 3 377 8 +1ns[ +16ns] +/- 3ns >> > * PHC0 0 3 377 6 -4ns[ -0ns] +/- 6ns >> > * PHC0 0 3 377 6 -8ns[ -12ns] +/- 5ns >> > * PHC0 0 3 377 5 +2ns[ +4ns] +/- 4ns >> > * PHC0 0 3 377 13 +2ns[ +4ns] +/- 4ns >> > * PHC0 0 3 377 12 -4ns[ -6ns] +/- 4ns >> > * PHC0 0 3 377 11 -8ns[ -11ns] +/- 6ns >> > * PHC0 0 3 377 10 -14ns[ -20ns] +/- 4ns >> > * PHC0 0 3 377 8 +4ns[ +5ns] +/- 4ns >> > >> > The PHC0 is the ptp clock which choose the host clock as its source >> > clock. So we can see that the clock difference between host and guest >> > is in order of ns. >> > >> > Signed-off-by: Jianyong Wu >> > --- >> > drivers/clocksource/arm_arch_timer.c | 24 +++++++++++++ >> > drivers/ptp/Kconfig | 2 +- >> > drivers/ptp/ptp_kvm_arm64.c | 53 >> ++++++++++++++++++++++++++++ >> > 3 files changed, 78 insertions(+), 1 deletion(-) create mode 100644 >> > drivers/ptp/ptp_kvm_arm64.c >> > >> > diff --git a/drivers/clocksource/arm_arch_timer.c >> > b/drivers/clocksource/arm_arch_timer.c >> > index d55acffb0b90..aaf286e90092 100644 >> > --- a/drivers/clocksource/arm_arch_timer.c >> > +++ b/drivers/clocksource/arm_arch_timer.c >> > @@ -1650,3 +1650,27 @@ static int __init arch_timer_acpi_init(struct >> > acpi_table_header *table) } TIMER_ACPI_DECLARE(arch_timer, >> > ACPI_SIG_GTDT, arch_timer_acpi_init); #endif >> > + >> > +#if IS_ENABLED(CONFIG_PTP_1588_CLOCK_KVM) >> > +#include >> > +int kvm_arch_ptp_get_crosststamp(unsigned long *cycle, struct >> timespec64 *ts, >> > + struct clocksource **cs) >> > +{ >> > + struct arm_smccc_res hvc_res; >> > + ktime_t ktime; >> > + >> > + /* Currently, linux guest will always use the virtual counter */ >> > + >> arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_PTP_FU >> NC_ID, >> > + ARM_PTP_VIRT_COUNTER, &hvc_res); >> > + if ((long long)(hvc_res.a0) < 0) >> > + return -EOPNOTSUPP; >> > + >> > + ktime = (long long)hvc_res.a0; >> > + *ts = ktime_to_timespec64(ktime); >> > + *cycle = (long long)hvc_res.a1; >> > + *cs = &clocksource_counter; >> > + >> > + return 0; >> > +} >> > +EXPORT_SYMBOL_GPL(kvm_arch_ptp_get_crosststamp); >> > +#endif >> > diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index >> > 942f72d8151d..127e96f14f89 100644 >> > --- a/drivers/ptp/Kconfig >> > +++ b/drivers/ptp/Kconfig >> > @@ -106,7 +106,7 @@ config PTP_1588_CLOCK_PCH config >> > PTP_1588_CLOCK_KVM >> > tristate "KVM virtual PTP clock" >> > depends on PTP_1588_CLOCK >> > - depends on KVM_GUEST && X86 >> > + depends on KVM_GUEST && X86 || ARM64 && ARM_ARCH_TIMER >> && >> > +ARM_PSCI_FW >> > default y >> > help >> > This driver adds support for using kvm infrastructure as a PTP >> > diff --git a/drivers/ptp/ptp_kvm_arm64.c b/drivers/ptp/ptp_kvm_arm64.c >> > new file mode 100644 index 000000000000..961abed93dfd >> > --- /dev/null >> > +++ b/drivers/ptp/ptp_kvm_arm64.c >> > @@ -0,0 +1,53 @@ >> > +// SPDX-License-Identifier: GPL-2.0-only >> > +/* >> > + * Virtual PTP 1588 clock for use with KVM guests >> > + * Copyright (C) 2019 ARM Ltd. >> > + * All Rights Reserved >> > + */ >> > + >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > + >> > +int kvm_arch_ptp_init(void) >> > +{ >> > + struct arm_smccc_res hvc_res; >> > + >> > + >> arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_FEATUR >> ES_FUNC_ID, >> > + &hvc_res); >> > + if (!(hvc_res.a0 | BIT(ARM_SMCCC_KVM_FUNC_KVM_PTP))) >> > + return -EOPNOTSUPP; >> > + >> > + return 0; >> >> What happens if the >> ARM_SMCCC_VENDOR_HYP_KVM_FEATURES_FUNC_ID function isn't >> implemented (on an old kernel or a non-KVM hypervisor)? The expected >> behaviour is that a0 will contain SMCCC_RET_NOT_SUPPORTED, which is >> -1. >> The result is that this function always returns "supported". Not an >> acceptable >> behaviour. >> > Oh! it's really a stupid mistake, should be "&" not "|". But even then. (-1 & whatever) is always true. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel