From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1111CDD0CB for ; Tue, 22 Oct 2024 18:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y9CSSJn0ti9P2PomuGM1IpvY2dY35KS2ng6g8SPbTBs=; b=ffh85za2MsSX5X7FIDcfe/FaEH 3kyVYOfyYUPhToI4Ikrh0sVkxl+PUb9LtlWM+UwqrXIsOydE5EkDwDX11MY34XIHlRinpEOSFOcmu qlI/Pc1Zv8AKUAiqamDe1nx5dQPaGeRr/FBHoHvb8AIBGlU9NpvD12Bgngy4sdlX/Bq8DbRnFp0J4 HK+5ubsEwIX5XlPJeirp46z5+lgbTA+2fc5qBNCmDT07ITg4GbgP7DRp+NzUnTvxL+IJZI8yQ5ovs EkaYZNJ8D9JOPtvypfU+ACqFJjn4aUJDIZJnCBsrxIvmW8oqBkoSCPZjivNvGt07RDDWeoQNc3aK8 tifc00DA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3Jt6-0000000Bq5y-2qeM; Tue, 22 Oct 2024 18:45:48 +0000 Received: from smtp.forwardemail.net ([207.246.76.47]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3Jra-0000000BpvJ-2keZ for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2024 18:44:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1729622639; bh=y9CSSJn0ti9P2PomuGM1IpvY2dY35KS2ng6g8SPbTBs=; b=d7pOzWg0+Q3Kq5Whfwa4M7VV1ObjDnnaSHt5KjJ0yOehtub2K5RT2Rqe5f2a+yM3Ei1kHGCuQ mnBytlTMoUvqjtsI4w6bfY4uSrhFvOJ28opfUZ1nFczyIfbqgbKTryHtPcmJpYaV1ks7G4bWx5A L8fGjntoIBAWHTaojoqOZ3WtbnVFqZ6BCQVKAI4zTcxNKXr3I96SXXJ9ZTMVfaPe3IKMHQNhl9w nZb6z56DIe1Vh84MjztyhF8KHEo7xTROW+oICrIs184bzr/Hmpbaf3FIQWOYEKDUr0C0O4t8jaw k+MuYFHO6CgbbJUYbpxSf/txnxabQbLz0jpHhHf0w8FA== Message-ID: <3669d2de-5324-4f48-a55c-942ce61d19bb@kwiboo.se> Date: Tue, 22 Oct 2024 20:43:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add FriendlyARM NanoPi R3S board To: Tianling Shen Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chris Morgan , Andy Yan , Jagan Teki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20241022181829.897547-1-cnsztl@gmail.com> Content-Language: en-US From: Jonas Karlman In-Reply-To: <20241022181829.897547-1-cnsztl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Report-Abuse-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Complaints-To: abuse@forwardemail.net X-ForwardEmail-Version: 0.4.40 X-ForwardEmail-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 207.246.76.47 X-ForwardEmail-ID: 6717f26eb5b2c22e6f61965d X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241022_114414_843263_5441999F X-CRM114-Status: GOOD ( 20.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tianling, On 2024-10-22 20:18, Tianling Shen wrote: > Hi Jonas, > > On Wed, Oct 23, 2024 at 1:56 AM Jonas Karlman wrote: >> >> Hi Tianling, >> >> On 2024-10-22 19:38, Tianling Shen wrote: >>> Hi Jonas, >>> >>> On Wed, Oct 23, 2024 at 12:49 AM Jonas Karlman wrote: >>>> >>>> Hi Tianling, >>>> >>>> On 2024-10-20 19:39, Tianling Shen wrote: >>>>> The NanoPi R3S(as "R3S") is an open source platform with dual-Gbps >>>>> Ethernet ports designed and developed by FriendlyElec for IoT >>>>> applications. >>>>> >>>>> Specification: >>>>> - Rockchip RK3566 >>>>> - 2GB LPDDR4X RAM >>>>> - optional 32GB eMMC module >>>>> - SD card slot >>>>> - 2x 1000 Base-T >>>>> - 3x LEDs (POWER, LAN, WAN) >>>>> - 2x Buttons (Reset, MaskROM) >>>>> - 1x USB 3.0 Port >>>>> - Type-C 5V 2A Power >>>>> >>>>> Signed-off-by: Tianling Shen >>>>> --- >>>>>  arch/arm64/boot/dts/rockchip/Makefile   Â  Â  Â  |   1 + >>>>>  .../boot/dts/rockchip/rk3566-nanopi-r3s.dts   | 554 ++++++++++++++++++ >>>>>  2 files changed, 555 insertions(+) >>>>>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts >>>>> >>>>> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile >>>>> index 8e1025cb5d20..e641033d23d1 100644 >>>>> --- a/arch/arm64/boot/dts/rockchip/Makefile >>>>> +++ b/arch/arm64/boot/dts/rockchip/Makefile >>>>> @@ -109,6 +109,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb >>>>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb >>>>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lckfb-tspi.dtb >>>>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb >>>>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-nanopi-r3s.dtb >>>>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb >>>>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb >>>>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb >>>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts >>>>> new file mode 100644 >>>>> index 000000000000..951dd9bcb4b0 >>>>> --- /dev/null >>>>> +++ b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts >>>>> @@ -0,0 +1,554 @@ >>>>> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT >>>>> +/* >>>>> + * Copyright (c) 2020 Rockchip Electronics Co., Ltd. >>>>> + * >>>>> + * Copyright (c) 2024 FriendlyElec Computer Tech. Co., Ltd. >>>>> + * (http://www.friendlyarm.com/ >> >> This could probably be updated to use https://www.friendlyelec.com/ > > Yes! > >> >>>>> + * >>>>> + * Copyright (c) 2024 Tianling Shen >>>>> + */ >>>>> + >>>>> +/dts-v1/; >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include "rk3566.dtsi" >>>>> + >>>>> +/ { >>>>> +   Â  model = "FriendlyARM NanoPi R3S"; >>>> >>>> Please use the marketing name, and the name added in binding: >>>> >>>>   Â FriendlyElec NanoPi R3S >>> >>> Sorry for the copy & paste error, will fix it in new patch. >> >> The commit subject could probably also be updated :-) >> >>> >>>> >>>>> +   Â  compatible = "friendlyarm,nanopi-r3s", "rockchip,rk3566"; >>>>> + >>>>> +   Â  aliases { >>>>> +   Â  Â  Â  Â  Â  ethernet0 = &gmac1; >>>>> +   Â  Â  Â  Â  Â  mmc0 = &sdmmc0; >>>>> +   Â  Â  Â  Â  Â  mmc1 = &sdhci; >>>> >>>> This board comes with on-board eMMC this please use mmc0 as alias for >>>> &sdhci; and mmc1 for sd-card. >>> >>> Is using mmc0 for sdhci a common practice for eMMC boards? >>> The eMMC module on R3S is optional and users may get boards without it. >> >> Typically any non-removable storage (emmc) is listed before removable >> storage (sd-card) options. Also U-Boot will try to override and use >> mmc0=sdhci and mmc1=sdmmc0 for all rk356x boards, so for EFI booing >> using control FDT the alias may be different. >> > > Thank you for the details! May I have your Suggested-by tag for all > of these fixes? Sure, Suggested-by: Jonas Karlman Regards, Jonas > > Thanks, > Tianling. > >> Regards, >> Jonas >> >> [snip]