From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE28FC433EF for ; Wed, 15 Jun 2022 15:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KU7ZgfVbOiq+kXKELeL39cNM4cYedcJPp1cwxmzjQsA=; b=uuHVrfaO7BXwHl GRZ4eDjxNfrALegzmn5wo2FyDUsChl9HhPkytRHWr68K7nXGx5cspXlRzVFpB56mq29mzPxVAyFFR lmkXJF6GYdjkN3ujbmWL3PHj4gNPGzBQBwxLOFGRzYJhFtD+I6RLztyifSFw65eUpEkuX+fm+6gbm e7M8pFDKfpMCUgrijwh9Aiy0ZF6fqbuZGtPqrWKHioHTVd8ouK48zx0oV7Ocj6/4yPMx8JB3h2nrk 8CJlIpg7r8NJsCWZfRnk7B6r8Dqg8M7vJmWycDtj5OC6+SalNeFyhmg0/B112TsP+/+uwdjJRK+7b riun474ig+MfZlE/0vGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1VKr-00FFUo-Hi; Wed, 15 Jun 2022 15:53:37 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1VKo-00FFT2-MD for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 15:53:36 +0000 Received: by mail-ej1-x62a.google.com with SMTP id v1so24049553ejg.13 for ; Wed, 15 Jun 2022 08:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D5ShLIbJdbDjGlxDv7D9TUkds40P1/JB5xsD295mwPM=; b=ciqSZu6WTLDGRSjO54NxzovGpYsYhGGsOZARVTMj+y8DfMifPnFGkOH5KV7BbJhb5k 8S640o47KmDM86S99aJ3cBi06365fmZ9hpTCErSvRw1adrK4oe/CZ+xYxayYFKNtdlKR dFtFRl6r9lxLLVnSVLYLcK6ObsYHx8f5RutGYsz3yibJprsZ6aUz04aJK4zk1wTT1TEm 94O43RAdX62nAx4IKH6DCUAbUlQZub+z2wGDEz3B8q8hMf+7HTuIw6NOz/lAvaJLYJtC Uz6CfSMbi2lAv5EIA0u9QhuFkAze8QTPtBPM4acfgDLEt6vQw7ON+Z/p5nZ+195qpyoU Cewg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D5ShLIbJdbDjGlxDv7D9TUkds40P1/JB5xsD295mwPM=; b=yrki8u4JFvUaXJhyJpc+m4XwqXB/0KrjUfU4E6BMgMKbjmXBsBrd7zqnjJwkCFHTdM FC63KIkIr3XTu7hKl34YUR+o9ruYwlKMOflNs0xGKs4xXmT7eZKjhb1HEn3qogDzjA+I 289Lf8m7wuqJD/muW1Ud1fjbQxOFG4X7LVUQJjS7MhN2NyKAFeN1kwyxeXXfIqVnmev6 1GPGIGE371HMdCWA0yMZE32Vnw5czn/I/lsYCiQFIf20ExMxVm+5YU3R6jhUZvM4Tma2 VNEyYZKBJE8ws5diLpSUf7GJ9UDthFiK+rt7CAi4O0rR+eu0z4hk1wUtX78ceHz74LqI N7Pg== X-Gm-Message-State: AJIora92Q9njyCxDIfyz7w+5oynipCm0yyjfmfH5hEwuqp1X5EvzGsS2 REFJfW5dqFXonUChxt9p2pE= X-Google-Smtp-Source: AGRyM1sVtnrDE7GtZbaoUeUmFFWPnp7cBVKqt8WzfkzPflwAbHdYxsZncOddT9V93wqNSiltwTbHlQ== X-Received: by 2002:a17:906:519b:b0:711:fb34:16f4 with SMTP id y27-20020a170906519b00b00711fb3416f4mr431124ejk.275.1655308410430; Wed, 15 Jun 2022 08:53:30 -0700 (PDT) Received: from kista.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id v14-20020aa7d9ce000000b0042bc97322desm9548790eds.43.2022.06.15.08.53.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 08:53:29 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Maxime Ripard , Samuel Holland Cc: Samuel Holland , Daniel Vetter , David Airlie , Ondrej Jirman , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] drm/sun4i: Fix crash during suspend after component bind failure Date: Wed, 15 Jun 2022 17:53:28 +0200 Message-ID: <3671441.kQq0lBPeGt@kista> In-Reply-To: <20220615054254.16352-1-samuel@sholland.org> References: <20220615054254.16352-1-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_085334_840362_EEEC6E6B X-CRM114-Status: GOOD ( 14.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 15. junij 2022 ob 07:42:53 CEST je Samuel Holland napisal(a): > If the component driver fails to bind, or is unbound, the driver data > for the top-level platform device points to a freed drm_device. If the > system is then suspended, the driver passes this dangling pointer to > drm_mode_config_helper_suspend(), which crashes. > > Fix this by only setting the driver data while the platform driver holds > a reference to the drm_device. > > Fixes: 624b4b48d9d8 ("drm: sun4i: Add support for suspending the display driver") > Signed-off-by: Samuel Holland Reviewed-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel