From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: shmobile: sdhi: pass DMA filter from platform code
Date: Fri, 31 May 2013 18:02:31 +0200 [thread overview]
Message-ID: <3675801.kLfsmmiSOq@wuerfel> (raw)
In-Reply-To: <alpine.DEB.2.00.1305311721160.7395@axis700.grange>
On Friday 31 May 2013 17:30:01 Guennadi Liakhovetski wrote:
> On Fri, 31 May 2013, Arnd Bergmann wrote:
> > On Friday 31 May 2013 16:52:13 Guennadi Liakhovetski wrote:
> > I think it's more a matter of using the API correctly. The dmaengine
> > API is an abstraction to separate the slave driver from the master
> > through well-defined calls. If you make additional assumptions
> > in the slave driver about the master, that is a layering violation.
>
> I think it is a common practice, see e.g.
>
> drivers/mmc/host/omap_hsmmc.c
> drivers/mmc/host/davinci_mmc.c
Yes, those should be fixed as well.
> And what do you do for DT-based platforms?
Once the driver is DT-enabled, we no longer have to pass
a filter function at all because the slave id and all settings
will get pulled out of the DT using the dma engine's xlate()
callback.
Arnd
next prev parent reply other threads:[~2013-05-31 16:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 13:56 [PATCH 1/2] ARM: shmobile: sdhi: pass DMA filter from platform code Arnd Bergmann
2013-05-31 13:56 ` [PATCH 2/2] ARM: shmobile: sdhi: remove DMA hardware dependencies Arnd Bergmann
2013-05-31 13:58 ` Arnd Bergmann
2013-06-07 10:22 ` Guennadi Liakhovetski
2013-06-07 12:59 ` Arnd Bergmann
2013-06-07 13:12 ` Guennadi Liakhovetski
2013-06-07 14:53 ` Arnd Bergmann
2013-06-07 15:32 ` Guennadi Liakhovetski
2013-06-07 16:06 ` Arnd Bergmann
2013-06-19 19:51 ` Guennadi Liakhovetski
2013-06-19 21:51 ` Arnd Bergmann
2013-06-26 10:10 ` DMA channels (was Re: [PATCH 2/2] ARM: shmobile: sdhi: remove DMA hardware dependencies) Guennadi Liakhovetski
2013-06-26 14:35 ` Arnd Bergmann
2013-06-26 15:48 ` Vinod Koul
2013-05-31 14:52 ` [PATCH 1/2] ARM: shmobile: sdhi: pass DMA filter from platform code Guennadi Liakhovetski
2013-05-31 15:11 ` Arnd Bergmann
2013-05-31 15:30 ` Guennadi Liakhovetski
2013-05-31 16:02 ` Arnd Bergmann [this message]
2013-06-05 8:28 ` Guennadi Liakhovetski
2013-06-07 10:25 ` Guennadi Liakhovetski
2013-06-07 12:52 ` Arnd Bergmann
2013-06-07 13:01 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3675801.kLfsmmiSOq@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox