From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D671EC433EF for ; Fri, 11 Mar 2022 10:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=goSXES+aFx+wne992uDJTB7o5i70h/m4a+geC881zGM=; b=qj6kVH3z8GD5xC qdivZDYrLaPj6bwc2wqivYbG8CI9+Co9XOWoptfo0+K8E9G6vpWYmzNpASw67Y3xrpaGHI51FWysU FoalVvw7cfrOSy7oi0PRl5I6xz8pewEXlxBLVTVoMzpkSCrZfvdFRAXSDWEtOHpk6nJ85aJCWkTD6 /blNND3fvnAIbNYGJQUcpyXCFYCiYHgGBKHwdlxgVD+dNw+/Vjij2DtZduYjXa8m5z7zdjzzWOjRd sXaunzss2WU/eHdzcA5EUmuF5xX5VSmTYXLmMeCzlG0I4bamesTGgNlWwZtUfj6b+drcOLcww+eMg YgRmPoGON0gE9lg8paAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nScy7-00G8rY-En; Fri, 11 Mar 2022 10:57:59 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nScy3-00G8qq-Mh for linux-arm-kernel@lists.infradead.org; Fri, 11 Mar 2022 10:57:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1646996275; x=1678532275; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3DJWRY8DxKyOlSga9F41zew51/GuSj1jE3Ph1MQJt8Y=; b=RlxVgQXRaoEIxeWFbAu9FaXU0Oa3xnbnDK6/qHHaO49ELuzCEeEqZVOS EGvh1YAnSKPEvX4Nf+PfLghh5JwF8goYT5BOc6qAOIoAKJAhTcHR2U78T e2FBmzg2BLq8AyNyWC+UI7JlZ1a0CNoW9ZFl+KPb41+ngT9rT19g1FC3c e1p52XY7qPh7Z2RPTom+cM6KcLM1UAJRmRdSBkOc1T6fE3sckAinUgyhS DKRR6AcUDNJALXFbrJDFgHHpLsXNbwPfLuzxJlWvQVn8huxMhevFwJAJz xE3RJYjX+tRYjst8NQAHMXGfZ2y6zM7tBBNanvjbnj4pehYlscYiN7Ekh g==; X-IronPort-AV: E=Sophos;i="5.90,173,1643670000"; d="scan'208";a="22608829" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 11 Mar 2022 11:57:51 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 11 Mar 2022 11:57:51 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 11 Mar 2022 11:57:51 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1646996271; x=1678532271; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3DJWRY8DxKyOlSga9F41zew51/GuSj1jE3Ph1MQJt8Y=; b=YNN0iYzRCHmLitYGgTinhhK1M5AwB2Nrb78y5oKbHqwYImogY2X9CX6l 7pLf7XLFEGrValAEsaaQtAs36mIhtQEaPOUsbKyAcvrSWRFNPUAtuK6wV 9nrBm52Blrzu+KpCH0bzh/47vzeVzo/q98E03eV0ZK43JA1dULMZ7S2on HtT3enQv48RBQWF56TRFLL4vsS0adUD7O4JfjajefAU8OgGjzKnt2E4We 8+vEWYDo41K5G0ET2Ch/bt6eGrbv57UI016ZGD4bfW8iwEeWpIZnBQclQ i31DGCDORaTi5Spx6mtnCiyHBQHUcLBE7Lp9DZ7O9RJZ3PLVbVoJunF4b g==; X-IronPort-AV: E=Sophos;i="5.90,173,1643670000"; d="scan'208";a="22608828" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 11 Mar 2022 11:57:51 +0100 Received: from steina-w.localnet (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id CB1F2280065; Fri, 11 Mar 2022 11:57:50 +0100 (CET) From: Alexander Stein To: Alifer Moraes Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eran.m@variscite.com, festevam@gmail.com, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-i2c@vger.kernel.org, linux@rempel-privat.de, pierluigi.p@variscite.com, s.hauer@pengutronix.de, shawnguo@kernel.org, gaopan , Fugang Duan , Vipul Kumar Subject: Re: (EXT) [PATCH] i2c: imx: add irqf_no_suspend Date: Fri, 11 Mar 2022 11:57:48 +0100 Message-ID: <3676803.kQq0lBPeGt@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20220307143630.28697-1-alifer.m@variscite.com> References: <20220307143630.28697-1-alifer.m@variscite.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220311_025756_138419_33F44634 X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hallo, Am Montag, 7. M=E4rz 2022, 15:36:30 CET schrieb Alifer Moraes: > From: gaopan > = > The i2c irq is masked when pcie starts a i2c transfer process > during noirq suspend stage. As a result, i2c transfer fails. > To solve the problem, IRQF_NO_SUSPEND is added to i2c bus. > = > Signed-off-by: Gao Pan > Signed-off-by: Fugang Duan > Signed-off-by: Vipul Kumar > --- > drivers/i2c/busses/i2c-imx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > = > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index 27f969b3dc07..fcc09a1e7f44 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -1478,7 +1478,8 @@ static int i2c_imx_probe(struct platform_device *pd= ev) > goto rpm_disable; > = > /* Request IRQ */ > - ret =3D request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED, > + ret =3D request_threaded_irq(irq, i2c_imx_isr, NULL, > + IRQF_SHARED | IRQF_NO_SUSPEND, > pdev->name, i2c_imx); > if (ret) { > dev_err(&pdev->dev, "can't claim irq %d\n", irq); I stumbled across Documentation/power/suspend-and-interrupts.rst which stat= es: > For this reason, using IRQF_NO_SUSPEND and IRQF_SHARED at the > same time should be avoided. Given this IMHO at least a comment should be inserted why this is fine. I d= ont = have a full picture about the situation, but to me it seems there is a = reference missing, or why/how does some PCIe start some I2C transfer when t= he controller is suspended already? Do I miss something? Best regards, Alexander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel