From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 821BAC433F5 for ; Wed, 8 Sep 2021 14:13:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 471E7610C8 for ; Wed, 8 Sep 2021 14:13:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 471E7610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=if/w9sEeax/AC1vGtAiO1EMkUNV4p5mgmeXVPw+MfSU=; b=Jlkpd1kgjK55bQVJYNF3+h9iMJ GMtvbFpPPcQMB7Prb1+6/PaySVAF9aDiSxmMXtExjW/7rZSARkUL3LmBs983xYLOZAFI8wpZCSmro L0CxNvFKwNcMlL/89qn4QIPvzk3RNMO2nS5U3G4ZjhLTkJR8VS0FdmwZtDINaBuCzn2lJQNpaRWJk 1VvHOtGiULmQRebpxj9NUOXDlT1Splheq+sLJ3FxOExAt5LQCIWnQjX3CvuYd9j6dtaVHkfZxFy4X vJTzxAkkO091IKIHZIQF7j9y4dLcl2FQtVrzOw6afPB/NdoRme+rGa3A1UXaKc37ajAcJra/y16c/ +pD9S6Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNyIi-006tPg-M5; Wed, 08 Sep 2021 14:11:44 +0000 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNyId-006tOv-TC for linux-arm-kernel@lists.infradead.org; Wed, 08 Sep 2021 14:11:41 +0000 Received: by mail-il1-x134.google.com with SMTP id u11so2462326ilj.5 for ; Wed, 08 Sep 2021 07:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h56N23KkijtRAG3ZoT0nWhy4eiurQamwjgFR6Q1Zg+4=; b=NOKQw41L5DOfpZAyRQKlcUeEgFvpXXMaWD//HYPx92A6Krj6OyBec9XvpKkZxxoIph U7ovtYxRF9YVOEtVZDBCOV8IWwdG4tMzL33AvhgD+LWu3967ogjFQbJNd37mhadh9W6E vczqWIwdigVtZhKjmb5iPfQJ+15JtKbK3tCng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h56N23KkijtRAG3ZoT0nWhy4eiurQamwjgFR6Q1Zg+4=; b=JGPqgp8Xr9E6fe+y69I5jSPHKR48WigLt5KawH7G9QTH41mCejYDyCOs8ZhOqsBRkX JhPRlGfe62qZvGJSaOiAwTxAMqfxpGIKe/3s5ZQ6tLcZNGaM7YZNahe3sfSggPWpflHL EYuBaF3zjro91l1ssdQNFuN/zM7uCjoM/SYNz/S5PRwHHQ63YiCNfnIudHDo8w7SHK1x YLvK6TpeVYXCv1d+zYu4mnD4923GGFS1g5Hn7/R6JZiFnXtrV3ChKnfuAK82irDO4W0+ J2kiSEfu7UG0rzfp0Cp/a3/oI8prQHH8Q21RGkUSav/REVu7KPMuwKcHekEBMbJ8jT2P YEug== X-Gm-Message-State: AOAM532iNTa34zTQVzdzMd+c58uKQeixmhIH2nsu2WabH3XBLlKkMakd JYQCMixseJO/GIjjqUuXEHG9lQjhIHicPA== X-Google-Smtp-Source: ABdhPJwIyKVaszB6vLEwTNN4bmc0KXCTddEw/AV2QK1CkXp+6dxaZ0tiGoQA7j+had8rESU69jxe6Q== X-Received: by 2002:a05:6e02:78d:: with SMTP id q13mr53233ils.262.1631110297834; Wed, 08 Sep 2021 07:11:37 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id p11sm1171267ilm.61.2021.09.08.07.11.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 07:11:37 -0700 (PDT) Subject: Re: ipv4/tcp.c:4234:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] To: Linus Torvalds , Naresh Kamboju , Mathias Nyman , Johannes Berg , Jakub Kicinski , Brendan Higgins , Ariel Elior , GR-everest-linux-l2@marvell.com, Wei Liu Cc: Linux ARM , open list , Netdev , lkft-triage@lists.linaro.org, Arnd Bergmann , "David S. Miller" , Greg Kroah-Hartman , Nick Desaulniers , Nathan Chancellor , Daniel Borkmann , Alexei Starovoitov , Eric Dumazet , Shuah Khan References: From: Shuah Khan Message-ID: <36aa5cb7-e3d6-33cb-9ac6-c9ff1169d711@linuxfoundation.org> Date: Wed, 8 Sep 2021 08:11:36 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_071140_040485_EF659CD5 X-CRM114-Status: GOOD ( 30.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/7/21 5:14 PM, Linus Torvalds wrote: > [ Added maintainers for various bits and pieces, since I spent the > time trying to look at why those bits and pieces wasted stack-space > and caused problems ] > > On Tue, Sep 7, 2021 at 3:16 PM Linus Torvalds > wrote: >> >> None of these seem to be new. > > That said, all but one of them seem to be (a) very much worth fixing > and (b) easy to fix. > > The do_tcp_getsockopt() one in tpc.c is a classic case of "lots of > different case statements, many of them with their own struct > allocations on stack, and all of them disjoint". > > So the fix for that would be the traditional one of just making helper > functions for the cases that aren't entirely trivial. We've done that > before, and it not only fixes stack usage problems, it results in code > that is easier to read, and generally actually performs better too > (exactly because it avoids sparse stacks and extra D$ use) > > The pe_test_uints() one is the same horrendous nasty Kunit pattern > that I fixed in commit 4b93c544e90e ("thunderbolt: test: split up test > cases in tb_test_credit_alloc_all") that had an even worse case. > > The KUNIT macros create all these individually reasonably small > initialized structures on stack, and when you have more than a small > handful of them the KUNIT infrastructure just makes the stack space > explode. Sometimes the compiler will be able to re-use the stack > slots, but it seems to be an iffy proposition to depend on it - it > seems to be a combination of luck and various config options. > I have been concerned about these macros creeping in for a while. I will take a closer look and work with Brendan to come with a plan to address it. > I detest code that exists for debugging or for testing, and that > violates fundamental rules and causes more problems in the process. > Having recently debugged a problem spinlock hold in an invalid context related to debug code, I agree with you on this that test and debug code shouldn't cause problems. thanks, -- Shuah _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel