From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AD82C10F06 for ; Sat, 6 Apr 2019 10:24:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E12FD218C3 for ; Sat, 6 Apr 2019 10:24:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tZvrieg1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="bh7mqx4D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E12FD218C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=caE9qmaIo7IcDiWcQbUcyblXphjx9zXem+fucSKuVNo=; b=tZvrieg1J6hkWyHcSxu7B4BKh qtT09XqRLXkQ9V9kK+shdl+yn4FTynSTJjaXlGu/UnLYlP1pRnZzjCh6/cfa39kUlk/TOOJj8yIaR rNKdWU3EhmUKhteJxrIpnWelI+3qsqc2uZid+wlMFn+kdo52CgU3NGqONuqMOAVblcdeW4ZIeeiMS u7goNdArHVFYWo1wvay5evFXor0LUxAs7dUIeuKn6kOr2LflvFqkAkfdLykaIe/eMsQAPLsj7Y/U5 TJ5/RPjkJczwp2+o8NszXgKerVSQTBUccejKO1Vs6heolwCrwjxlpBspGxyTYfF5RE+VmbmTI0BKB woqBZSsKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCiV7-0002UH-6q; Sat, 06 Apr 2019 10:24:41 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCiV3-0002To-UB for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2019 10:24:39 +0000 Received: by mail-lf1-x141.google.com with SMTP id y18so6189121lfe.1 for ; Sat, 06 Apr 2019 03:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0B2T93URAhgkJumCufvQgsIA73utiusJRcpc3egwJ3w=; b=bh7mqx4Dk6f8JGmWpEyE1WEoykl+7YYcpjdshasbN5gUWF1DQkQ+saSf5pYKspd0ks 9lzneFQTxPofVNeIlAyPVH0i5m5wMYgkVes8wNDoFp7BoFm9U4f7HPH5etAGHhXCapgi nQKVpD6sPyRH0mmUqHoEhwtN0sY2olKexpbyi8n2YKDOMzAf6Y9WxWz/nMy0iIHtP+x2 rEGTLwsLvUR3a8nNdAKClh8PJgZrUd1GpKk255faE0gAr03ez+oFKn1sPURrjP6jad5K JqqMjFeVrSJxnPBjr06IwXzL5Cw5E050prXoXpMeAvcc1NkszCowLyg5Snut4t954yFZ /dAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0B2T93URAhgkJumCufvQgsIA73utiusJRcpc3egwJ3w=; b=QbBRn/U9IqZj5eOygtp7DZ9DDb9kL//nC2BAQy4BRTwzajjy7fkpAFhE0Pr1jyXqWl cNvAkkNYQj28DyzE0vugNng/GGLUReaZTCyamkKxRjNtM/4dG0IP/Y1+xHpl5Zmp5vkC pTlzNUPt+I+Z3QoB43SehdhPoKGFr4EZR5wU43be3g0caMLiJugttlSdNgSnTxEGCLHn vwclyb6j4KukKhlTrbehqfGUmlne56BuUQxJlNw8aGP9wrf4fGttjBafo5lT6ZTYYp8T 1ji6OejwQlprLdgSaqfY2fcuirUL/eZuKJkWWzTZuNtEkhamAWiNZ3vKp05ki48r1fSb jHHA== X-Gm-Message-State: APjAAAVC2ffkHeb99i9Zw4nCdJFa6zoYtbJs37rUrods/KGm6bHNpDUR 1xYCKoyWPGxUkstmGtG5MMn1DQ== X-Google-Smtp-Source: APXvYqxPg2maS6hIFXQrqgAZHG5hl6JCOOnw2lWbLYw42o3CcmK36QiKAT3Au6HlUb4wVR3vdqDlcQ== X-Received: by 2002:ac2:5082:: with SMTP id f2mr9991211lfm.71.1554546273571; Sat, 06 Apr 2019 03:24:33 -0700 (PDT) Received: from [10.102.31.166] ([81.16.143.135]) by smtp.gmail.com with ESMTPSA id q5sm4914656lfm.16.2019.04.06.03.24.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Apr 2019 03:24:32 -0700 (PDT) Subject: Re: [PATCH 06/12] net: stmmac: sun8i: force select external PHY when no internal one To: megous@megous.com, linux-sunxi@googlegroups.com, Maxime Ripard , Chen-Yu Tsai , Rob Herring , Linus Walleij References: <20190405234514.6183-1-megous@megous.com> <20190405234514.6183-7-megous@megous.com> From: Sergei Shtylyov Message-ID: <36e1e65b-5a8f-f8ae-6c33-07c30beada17@cogentembedded.com> Date: Sat, 6 Apr 2019 13:24:26 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190405234514.6183-7-megous@megous.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190406_032438_116989_811B8253 X-CRM114-Status: GOOD ( 19.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Airlie , Chi-Hsien Lin , dri-devel@lists.freedesktop.org, Giuseppe Cavallaro , linux-stm32@st-md-mailman.stormreply.com, brcm80211-dev-list@cypress.com, Jose Abreu , Naveen Gupta , Icenowy Zheng , devicetree@vger.kernel.org, Arend van Spriel , Alexandre Torgue , Hante Meuleman , linux-gpio@vger.kernel.org, Wright Feng , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Franky Lin , brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Kalle Valo , Maxime Coquelin , "David S. Miller" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello! On 06.04.2019 2:45, megous@megous.com wrote: > From: Icenowy Zheng > > The PHY selection bit also exists on SoCs without an internal PHY; if > it's set to 1 (internal PHY) then the MAC will not make use of any PHY. > > This problem appears when adapting for H6, which has no real internal > PHY (the "internal PHY" on H6 is not on-die, but on a co-packaged AC200 > chip, via RMII interface at GPIO bank A), but the PHY selection bit is > set. > > Force the PHY selection bit to 0 when no external PHY to select this > problem. "Select this problem" sound weird... > Signed-off-by: Icenowy Zheng > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > index e3e3dc44b33b..bd340e77b2ea 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c > @@ -908,6 +908,11 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv) > * address. No need to mask it again. > */ > reg |= 1 << H3_EPHY_ADDR_SHIFT; > + } else { > + /* For SoCs without internal PHY the PHY selection bit should be > + * set to 0 (external PHY). > + */ > + reg &= ~(H3_EPHY_SELECT); No () should be needed here, add () around the macro body if still needed. [...] MBR, Sergei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel