From: Steven Price <steven.price@arm.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
robh@kernel.org, tomeu.vizoso@collabora.com,
alyssa.rosenzweig@collabora.com
Cc: linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] drm/panfrost: add support for vendor quirk
Date: Thu, 17 Sep 2020 11:29:05 +0100 [thread overview]
Message-ID: <370802ea-5f21-7a62-cf84-0dc5f5020667@arm.com> (raw)
In-Reply-To: <20200916150147.25753-2-narmstrong@baylibre.com>
On 16/09/2020 16:01, Neil Armstrong wrote:
> The T820, G31 & G52 GPUs integratewd by Amlogic in the respective GXM, G12A/SM1 & G12B
NIT: s/integratewd/integrated/
> SoCs needs a quirk in the PWR registers after each reset.
>
> This adds a callback in the device compatible struct of permit this.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_device.h | 3 +++
> drivers/gpu/drm/panfrost/panfrost_gpu.c | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/panfrost/panfrost_device.h
> index abfc78db193a..140e004a3790 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.h
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.h
> @@ -70,6 +70,9 @@ struct panfrost_compatible {
> int num_pm_domains;
> /* Only required if num_pm_domains > 1. */
> const char * const *pm_domain_names;
> +
> + /* Vendor implementation quirks callback */
> + void (*vendor_quirk)(struct panfrost_device *pfdev);
> };
>
> struct panfrost_device {
> diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> index c7c5da5a31d4..a6de78bc1fa8 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> @@ -136,6 +136,10 @@ static void panfrost_gpu_init_quirks(struct panfrost_device *pfdev)
>
> if (quirks)
> gpu_write(pfdev, GPU_JM_CONFIG, quirks);
> +
> + /* Here goes platform specific quirks */
> + if (pfdev->comp->vendor_quirk)
> + pfdev->comp->vendor_quirk(pfdev);
> }
>
> #define MAX_HW_REVS 6
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-17 10:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 15:01 [PATCH v2 0/3] drm/panfrost: add Amlogic integration quirks Neil Armstrong
2020-09-16 15:01 ` [PATCH v2 1/3] drm/panfrost: add support for vendor quirk Neil Armstrong
2020-09-17 10:29 ` Steven Price [this message]
2020-09-16 15:01 ` [PATCH v2 2/3] drm/panfrost: add amlogic reset quirk callback Neil Armstrong
2020-09-17 10:29 ` Steven Price
2020-09-16 15:01 ` [PATCH v2 3/3] drm/panfrost: add Amlogic GPU integration quirks Neil Armstrong
2020-09-17 10:29 ` Steven Price
2020-09-16 17:05 ` [PATCH v2 0/3] drm/panfrost: add Amlogic " Alyssa Rosenzweig
2020-09-21 7:52 ` Neil Armstrong
2020-09-21 9:17 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=370802ea-5f21-7a62-cf84-0dc5f5020667@arm.com \
--to=steven.price@arm.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh@kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox