From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DFCB606B4C3 for ; Wed, 21 Oct 2026 12:35:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=SjMt6PQ1; dkim=pass (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=uhPCu5kB DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+c9+shoBVGKMTVRiYFf5APeJCORN4Sf79qlNAFX1wgg=; b=SjMt6PQ1ai6nLXbvD3CxWeg5SO SAzXDxIz8a13ci84YFgF8vVnKbbX055orSEu1xq5kNRstGgDW9wGf5GptQNh4yse+sR/LIYzvEwBN DK1+z1L4qt7sXSIng1WfTKqE4BDorN5xM0JVppZxxsABrkgLxLoxpB87h4+53aKiFyFzEEYhJUZD5 EfjKD2tNr1Q1/bRZ0rnUQTCnsHhZ/QUpjgM2FKup+y03Sf1kjnvJHbTqKnMkCMKO+NvRtbq9wKKzG Nfl3Lp2ToLYdxaxVVlEWCiygoMb3U3d3D+hIdIaQHC0hneQtUKsEw2NeCPyFfbqv6YFQHAhLwQKNk aj9wJ+Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJVXl-0000000BoUm-0dK1; Wed, 21 Oct 2026 12:35:45 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJVXg-0000000BoSZ-3nhy; Wed, 21 Oct 2026 12:35:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=+c9+shoBVGKMTVRiYFf5APeJCORN4Sf79qlNAFX1wgg=; b=uhPCu5kBqD3gwHLmGX+i3yZ8D+ RqD4k7y1uAlgvVkz+zgxZb1KFh6bofsoDYvnRySAHrBApQMB0r4g9M8amF+ZFJznEVL6WISsDawON brLaQ/BwqcOVG9tOK/xBEziZPyku17B+bnSQMe5eQXm+WxaFtD77WgRZNdN/ecHx3zWoqeFMHvdUK H7GDGR7BkGsqOGW7V0mUx9JeAsQ6T9hS9RkVeN3RSNRwaW/ODNL9YXcry+rtmIR5CRwn/Otv8LFJ8 J/9cWyHG8IjCt7gYh/8Ky1Yte1lmbgNH+rn2nSzg7G+jH6k/miHIwseDTfhc5M6LyeJt5bFiR23/F 94CenVBQ==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Manivannan Sadhasivam , Bjorn Helgaas , Diederik de Haas Cc: Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Diederik de Haas Subject: Re: [PATCH] PCI: dw-rockchip: Remove redundant dev_err() Date: Wed, 21 Oct 2026 14:35:37 +0200 Message-ID: <3711913.V25eIC5XRa@diego> In-Reply-To: <20261021101533.609118-1-diederik@cknow-tech.com> References: <20261021101533.609118-1-diederik@cknow-tech.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261021_053540_949645_D7BAB183 X-CRM114-Status: UNSURE ( 7.06 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Am Mittwoch, 21. Oktober 2026, 12:14:57 Mitteleurop=C3=A4ische Sommerzeit s= chrieb Diederik de Haas: > The devm_request_threaded_irq() function already automatically logs > detailed error messages on failure since commit > 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()") > So remove the now-redundant driver-specific dev_err() calls. >=20 > Signed-off-by: Diederik de Haas Reviewed-by: Heiko Stuebner