Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: "robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	Frank Li <frank.li@nxp.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	"dario.binacchi@amarulasolutions.com"
	<dario.binacchi@amarulasolutions.com>,
	"alexander.stein@ew.tq-group.com"
	<alexander.stein@ew.tq-group.com>,
	"Markus.Niebel@tq-group.com" <Markus.Niebel@tq-group.com>,
	"matthias.schiffer@tq-group.com" <matthias.schiffer@tq-group.com>,
	"y.moog@phytec.de" <y.moog@phytec.de>,
	"josua@solid-run.com" <josua@solid-run.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	"primoz.fiser@norik.com" <primoz.fiser@norik.com>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support
Date: Wed, 28 Jan 2026 11:16:13 +0100	[thread overview]
Message-ID: <37133829-da88-4ea6-a58e-fcb4cc7f7c12@kernel.org> (raw)
In-Reply-To: <VI0PR04MB12114EDD17C2F37A3AE7D61089293A@VI0PR04MB12114.eurprd04.prod.outlook.com>

On 26/01/2026 03:52, Sherry Sun wrote:
>> Subject: Re: [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless
>> EVK board support
>>
>> On Fri, Jan 23, 2026 at 10:44:48AM +0800, Sherry Sun wrote:
>>> i.MX93 Wireless SiP is created by integrating i.MX93 and IW610 WLCSP
>>> (Wi-Fi + BLE + 802.15.4). And i.MX93 Wireless EVK board with the
>>> i.MX93 Wireless SiP basically reuse the i.MX93 11x11 EVK board, with
>>> some minor functional and pin connection differences.
>>>
>>> Here are the detailed differences between i.MX93 Wireless EVK and
>>> i.MX93
>>> 11x11 EVK board.
>>>
>>> Function differences:
>>> Function	i.MX93W EVK			i.MX93 EVK
>>> WIFI/BT		IW610 in i.MX93W		IW612 M.2 module
>>> MQS		N				Y
>>> PDM MIC		N				Y
>>> M.2		N				Y
>>> RPi 40-pin HDR	Limited support(pin conflict) 	Y
>>>
>>> Pin connection differences:
>>> Function  Signal name	i.MX93W EVK		i.MX93 EVK
>>> WIFI/BT	  SPI_FRM	SAI1_TXFS (spi1.PCS0)	GPIO_IO08
>> (spi3.PCS0)
>>> 	  SPI_TXD	SAI1_TXC (spi1.SIN)	GPIO_IO09 (spi3.SIN)
>>> 	  SPI_RXD	SAI1_RXD0 (spi1.SOUT)	GPIO_IO10 (spi3.SOUT)
>>> 	  SPI_CLK	SAI1_TXD0 (spi1.SCK)	GPIO_IO11 (spi3.SCK)
>>> 	  SPI_INT	CCM_CLKO1		on-board IO expander
>>> 	  NB_WAKE_IN	PDM_CLK			on-module IO
>> expander
>>> 	  WL_WAKE_IN	PDM_BIT_STREAM0		on-module IO
>> expander
>>> 	  IND_RST_WL	PDM_BIT_STREAM1		on-module IO
>> expander
>>> 	  IND_RST_NB	GPIO_IO28		on-module IO expander
>>> 	  PDn		GPIO_IO29		on-module IO expander
>>> 	  NB_WAKE_OUT	GPIO_IO14		on-board IO
>> expander
>>> 	  WL_WAKE_OUT	GPIO_IO15		CCM_CLKO1
>>> I2C3	  I2C3_SDA	GPIO_IO00		GPIO_IO28
>>> 	  I2C3_SCL	GPIO_IO01		GPIO_IO29
>>>
>>> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
>>> ---
>>>  arch/arm64/boot/dts/freescale/Makefile       |  1 +
>>>  arch/arm64/boot/dts/freescale/imx93w-evk.dts | 73
>>> ++++++++++++++++++++
>>>  2 files changed, 74 insertions(+)
>>>  create mode 100644 arch/arm64/boot/dts/freescale/imx93w-evk.dts
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/Makefile
>>> b/arch/arm64/boot/dts/freescale/Makefile
>>> index 700bab4d3e60..d0ea746c59b8 100644
>>> --- a/arch/arm64/boot/dts/freescale/Makefile
>>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>>> @@ -418,6 +418,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-9x9-qsb-
>> i3c.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-frdm.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-14x14-evk.dtb
>>> +dtb-$(CONFIG_ARCH_MXC) += imx93w-evk.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-kontron-bl-osm-s.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-nash.dtb
>>>  dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb diff --git
>>> a/arch/arm64/boot/dts/freescale/imx93w-evk.dts
>>> b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
>>> new file mode 100644
>>> index 000000000000..f09587dc74f6
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/freescale/imx93w-evk.dts
>>> @@ -0,0 +1,73 @@
>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>> +/*
>>> + * Copyright 2026 NXP
>>> + */
>>> +
>>> +#include "imx93-11x11-evk.dts"
>>> +
>>> +/ {
>>> +	model = "NXP i.MX93W EVK board";
>>> +	compatible = "fsl,imx93-wireless-evk", "fsl,imx93";
>>> +
>>> +	/delete-node/ regulator-m2-pwr;
>>
>> If you remove nodes then clearly you do not share a common design, thus
>> you should not include other DTSI... and definitely even more confusing to
>> include other DTS.
> 
> Hi Krzysztof,
> Ok, it seems I should mark these nodes as disabled instead of delete them, will fix, thanks!

Still wrong. How component present in the board can be missing in the
same time? You included other DTS for a reason which means this board
grows on the previous design.

Best regards,
Krzysztof


      reply	other threads:[~2026-01-28 10:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23  2:44 [PATCH V2 0/2] Add i.MX93 Wireless EVK board support Sherry Sun
2026-01-23  2:44 ` [PATCH V2 1/2] dt-bindings: arm: fsl: Add i.MX93 Wireless EVK board Sherry Sun
2026-01-23  9:00   ` Krzysztof Kozlowski
2026-01-26  2:03     ` Sherry Sun
2026-01-23  2:44 ` [PATCH V2 2/2] arch: arm64: imx93-wevk: Add i.MX93 Wireless EVK board support Sherry Sun
2026-01-23  9:02   ` Krzysztof Kozlowski
2026-01-23 15:06     ` Frank Li
2026-01-26  2:52     ` Sherry Sun
2026-01-28 10:16       ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37133829-da88-4ea6-a58e-fcb4cc7f7c12@kernel.org \
    --to=krzk@kernel.org \
    --cc=Markus.Niebel@tq-group.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=frank.li@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=josua@solid-run.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.schiffer@tq-group.com \
    --cc=primoz.fiser@norik.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=sherry.sun@nxp.com \
    --cc=y.moog@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox