From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc: mchehab@kernel.org, hverkuil@xs4all.nl,
ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
gregkh@linuxfoundation.org, mripard@kernel.org, wens@csie.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
nicolas.dufresne@collabora.com, andrzej.p@collabora.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, kernel@collabora.com
Subject: Re: [PATCH 3/7] media: hantro: HEVC: Fix chroma offset computation
Date: Fri, 1 Jul 2022 11:03:18 +0200 [thread overview]
Message-ID: <37145626-1a7e-2aba-4f3c-4d0574729a41@collabora.com> (raw)
In-Reply-To: <Yr60jj4OOAM6plWC@aptenodytes>
Le 01/07/2022 à 10:47, Paul Kocialkowski a écrit :
> Hi Benjamin,
>
> On Fri 17 Jun 22, 13:57, Benjamin Gaignard wrote:
>> The chroma offset depends of the bitstream depth.
>> Make sure that ctx->bit_depth is used to compute it.
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
>> ---
>> drivers/staging/media/hantro/hantro_g2_hevc_dec.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/hantro/hantro_g2_hevc_dec.c b/drivers/staging/media/hantro/hantro_g2_hevc_dec.c
>> index 9eac133bda68..8407ad45b7b7 100644
>> --- a/drivers/staging/media/hantro/hantro_g2_hevc_dec.c
>> +++ b/drivers/staging/media/hantro/hantro_g2_hevc_dec.c
>> @@ -12,7 +12,7 @@
>>
>> static size_t hantro_hevc_chroma_offset(struct hantro_ctx *ctx)
>> {
>> - return ctx->dst_fmt.width * ctx->dst_fmt.height;
>> + return ctx->dst_fmt.width * ctx->dst_fmt.height * ctx->bit_depth / 8;
> Is this a case for DIV_ROUND_UP or are you sure the rounded-down size is always
> sufficient?
No need of DIV_ROUND_UP here because it could affect the chroma offset when
using decoder tiled format and add extra bytes between luma and chroma planes.
Regards,
Benjamin
> Cheers,
>
> Paul
>
>> }
>>
>> static size_t hantro_hevc_motion_vectors_offset(struct hantro_ctx *ctx)
>> --
>> 2.32.0
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-01 9:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 11:57 [PATCH 0/7] Enable 10bits bitstream for Hantro/G2 HEVC codec Benjamin Gaignard
2022-06-17 11:57 ` [PATCH 1/7] media: hantro: Store HEVC bit depth in context Benjamin Gaignard
2022-06-30 17:30 ` Ezequiel Garcia
2022-06-17 11:57 ` [PATCH 2/7] media: hantro: HEVC: Fix auxilary buffer size calculation Benjamin Gaignard
2022-06-30 17:33 ` Ezequiel Garcia
2022-06-17 11:57 ` [PATCH 3/7] media: hantro: HEVC: Fix chroma offset computation Benjamin Gaignard
2022-06-30 17:34 ` Ezequiel Garcia
2022-07-01 8:47 ` Paul Kocialkowski
2022-07-01 9:03 ` Benjamin Gaignard [this message]
2022-06-17 11:57 ` [PATCH 4/7] media: hantro: postproc: Configure output regs to support 10bit Benjamin Gaignard
2022-06-30 17:35 ` Ezequiel Garcia
2022-06-17 11:58 ` [PATCH 5/7] media: Hantro: HEVC: Allows 10-bit bitstream Benjamin Gaignard
2022-06-30 17:38 ` Ezequiel Garcia
2022-06-17 11:58 ` [PATCH 6/7] media: hantro: imx8m: Enable 10bit decoding Benjamin Gaignard
2022-06-30 17:40 ` Ezequiel Garcia
2022-07-01 7:01 ` Benjamin Gaignard
2022-07-04 15:43 ` Nicolas Dufresne
2022-06-17 11:58 ` [PATCH 7/7] media: hantro: Allows luma and chroma depth to be different Benjamin Gaignard
2022-06-30 17:40 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37145626-1a7e-2aba-4f3c-4d0574729a41@collabora.com \
--to=benjamin.gaignard@collabora.com \
--cc=andrzej.p@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox