Re: [PATCH v2] pinctrl: qcom: Make important drivers default

[Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>]

On 28/04/2026 23:13, Dmitry Baryshkov wrote:
> On Tue, Apr 28, 2026 at 06:35:49PM +0200, Krzysztof Kozlowski wrote:
>> The main SoC TLMM (Top-Level Multiplexer) pin controller drivers are
>> essential for booting up SoCs and are not really optional for a given
>> platform.  Kernel should not ask users choice of drivers when that
>> choice is obvious and known to the developers that answer should be
>> 'yes' or 'module'.
>>
>> Switch all Qualcomm TLMM pin controller drivers to a default 'yes' for
>> ARCH_QCOM.  This has impact:
>>
>> 1. arm64 defconfig: enable PINCTRL_SM7150, PINCTRL_IPQ9650 and
>>    PINCTRL_HAWI, which were not selected before but should be, because
>>    these platforms need them for proper boot.
>>
>> 2. arm qcom_defconfig: no changes.
>>
>> 3. arm multi_v7 defconfig: enable drivers necessary to boot ARM 32-bit
>>    platforms, which are already enabled on qcom_defconfig.
>>
>> 4. COMPILE_TEST builds: enable by default all drivers for arm or arm64
>>    builds, whenever ARCH_QCOM is selected.  This has impact on build
>>    time and feels logical, because if one selects ARCH_QCOM then
>>    probably by default wants to build test it entirely.  Kernels with
>>    COMPILE_TEST are not supposed to be used for booting.
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Reviewed-by: Linus Walleij <linusw@kernel.org>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>
>> ---
>>
>> I did similar change for clocks and I will be continuing with
>> interconnect and other missing pieces.
>>
>> Changes in v2:
>> 1. Rebase on Linus W. devel branch. This should go with pinctrl, I
>>    think.
>> 2. Add tags.
>> 3. Update also PINCTRL_IPQ9650.
>> ---
>>  arch/arm/configs/multi_v7_defconfig |  8 ----
>>  arch/arm/configs/qcom_defconfig     | 15 -------
>>  arch/arm64/configs/defconfig        | 46 ----------------------
>>  drivers/pinctrl/qcom/Kconfig        |  1 +
>>  drivers/pinctrl/qcom/Kconfig.msm    | 61 +++++++++++++++++++++++++++++
> 
> I think it would have been better split into 3 patches, but this way is
> also fine.

You mean defconfigs as separate patches? I could do that and I was
thinking about it, but many people do testing with defconfig and such
defconfig would be nonbisectable here.

Best regards,
Krzysztof