From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE94CC3DA42 for ; Wed, 10 Jul 2024 19:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gEbSr+p0f3OVfoF+U52II1mfKi+tj9bkA1wOAZejR7c=; b=VsnWXn5JW8RGpmwhO3H0j3OeBZ cZ/qBXss/VMk2FS/VKjuoXg5wdO4DqM8BrBVgRwXLxS0rONBhDKGos9Frp4MTpgnS+luvdQa4mHLM 946NwsAuBgT8sNCzU5IC4A7Raj59gYrKt5eeqS4Ht+r+cOxtizr5/CheYvd14hoBvSnQYuZzic669 IrP8Ian8jwxHgU5bUVl7odQoL62AFLKMtiUTShg0lB3JvRbKSHaNiSAqdm9lCLSFVwr7VE2FpLVCV a6DmbsGhrrS67iX84tOOhg5ZemqqB1vPtUJL5yTUA+9CIONGGi3I0FtKEwexU0L5/nJj5wUycoMDR qqAaT5CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRcnK-0000000BW3g-3NGF; Wed, 10 Jul 2024 19:16:02 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRcn3-0000000BW0q-1FFL; Wed, 10 Jul 2024 19:15:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1720638939; bh=XcRXiDRqA+ir3jqrK/0TX5hqWhgGqVuOsPns1Whd1o0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zz9Kyvc8n8oCcnls3iEZbvezLgnMdf1CbKfrc+yJMK7zd9luGuMYw5A93UeUydrJW xXU7KD46J7LqS9jwBuwExwP1XPj+p+7FlwWFlF681L2se3YvzYaeL241EAZSYRMgyi CyjsUo3dvRw/KSyo4omFjJ42t1wKkt30FEbjUYFRCMHeKYzIpUNaKaqGkN8LrNsSmo Cx8eiTje1VZ+O7InF+MuPsNqQnCTYXZUB1TdoMwPXtsgyHVzmXdebUJZsSBnTmPmv6 AICdiMttq8SN9pVvq3Sz0FhPZ3ahkBWCtNBngmYlFQ9Qj2fNjm2UTfFsVYW7rSfch8 bdVLhuXzT4sfA== Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id E729C37810CD; Wed, 10 Jul 2024 19:15:37 +0000 (UTC) Date: Wed, 10 Jul 2024 15:15:36 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: AngeloGioacchino Del Regno Cc: Matthias Brugger , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, Macpaul Lin , Chunfeng Yun , Chen-Yu Tsai Subject: Re: Probe failure of usb controller @11290000 on MT8195 after next-20231221 Message-ID: <375b2345-657a-4b8f-b5e3-dc16784ffde9@notapiano> References: <9fce9838-ef87-4d1b-b3df-63e1ddb0ec51@notapiano> <064935d8-fbda-4eda-b013-8c8fc63b561c@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <064935d8-fbda-4eda-b013-8c8fc63b561c@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240710_121545_661205_86075D55 X-CRM114-Status: GOOD ( 28.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 19, 2024 at 10:12:07AM +0100, AngeloGioacchino Del Regno wrote: > Il 18/01/24 19:36, Nícolas F. R. A. Prado ha scritto: > > Hi, > > > > KernelCI has identified a failure in the probe of one of the USB controllers on > > the MT8195-Tomato Chromebook [1]: > > > > [ 16.336840] xhci-mtk 11290000.usb: uwk - reg:0x400, version:104 > > [ 16.337081] xhci-mtk 11290000.usb: xHCI Host Controller > > [ 16.337093] xhci-mtk 11290000.usb: new USB bus registered, assigned bus number 5 > > [ 16.357114] xhci-mtk 11290000.usb: clocks are not stable (0x1003d0f) > > [ 16.357119] xhci-mtk 11290000.usb: can't setup: -110 > > [ 16.357128] xhci-mtk 11290000.usb: USB bus 5 deregistered > > [ 16.359484] xhci-mtk: probe of 11290000.usb failed with error -110 > > > > A previous message [2] suggests that a force-mode phy property that has been > > merged might help with addressing the issue, however it's not clear to me how, > > given that the controller at 1129000 uses a USB2 phy and the phy driver patch > > only looks for the property on USB3 phys. > > > > Worth noting that the issue doesn't always happen. For instance the test did > > pass for next-20240110 and then failed again on today's next [3]. But it does > > seem that the issue was introduced, or at least became much more likely, between > > next-20231221 and next-20240103, given that it never happened out of 10 runs > > before, and after that has happened 5 out of 7 times. > > > > Note: On the Tomato Chromebook specifically this USB controller is not connected > > to anything. > > > > [1] https://linux.kernelci.org/test/case/id/659ce3506673076a8c52a428/ > > [2] https://lore.kernel.org/all/239def9b-437b-9211-7844-af4332651df0@mediatek.com/ > > [3] https://linux.kernelci.org/test/case/id/65a8c66ee89acb56ac52a405/ > > > > Thanks, > > Nícolas > > Hey Nícolas, > > I wonder if this is happening because of async probe... I have seen those happening > once in a (long) while on MT8186 as well with the same kind of flakiness and I am > not even able to reproduce anymore. > > For MT8195 Tomato, I guess we can simply disable that controller without any side > effects but, at the same time, I'm not sure that this would be the right thing to > do in this case. > > Besides, the controller at 11290000 is the only one that doesn't live behind MTU3, > but I don't know if that can ring any bell.... An update on this issue: it looks like it only happens if "xhci-mtk 11290000.usb" probes before "mtk-pcie-gen3 112f8000.pcie". What they have in common is that both of those nodes use phys that share the same t-phy block: pcie uses the usb3 phy while xhci uses the usb2 phy. So it seems that some of the initialization done by the pcie controller might be implicitly needed by the usb controller. This should help to narrow down the issue and find a proper fix for it. Thanks, Nícolas