From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF3D4C00140 for ; Fri, 12 Aug 2022 17:31:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g/P+Zg4BBvvysO8zPBzathtuJ5tLtCtVwGcavSZzeSQ=; b=RRLjLnbYeUbKmK N0j4cbfFP6e21vNqiYFv/gQNP6WE4ZucZ3yeAYxwwvowSyp7amob5feIPIyXxPRO2oWt1v8C3D4ow uWNor5/38675iYVfHWa0dy1JXXK6pDl7Kax4Hj8vMDARVaxCYq+4mDbUJH6xFyGRgn+Fu/g+c9at7 6oJJ4EQbNouLmRD1daWAgzgxuYURH82QYGtq2I+hWxu0ivZzP9OjkvvRjs688rENCHtZuH4n3UoL1 jZibilf8aDCZcTf1kty6Nd89xsOkzmMQHJFAZdZExHKIDF8y2gsKYiBnUS7bHEw7vDlkLKyTuwBCr WfWWMSYnDWb94MbR0JkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMYUD-00BWc5-AV; Fri, 12 Aug 2022 17:30:17 +0000 Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMYTv-00BWTB-Ew for linux-arm-kernel@lists.infradead.org; Fri, 12 Aug 2022 17:30:01 +0000 Received: by mail-qt1-x829.google.com with SMTP id y18so1267601qtv.5 for ; Fri, 12 Aug 2022 10:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Ai2HsUP704GMlIzejaJoLn59RRK3/SzYyUuWR94MIL4=; b=TXZGPzKcE7bYngWw7KpHl+NVc6xLAw/AliIXjBeWgw6YNJuVtLC8fi/RWfCQQ/cVLn lxzRXwoxNfBgYuA+wBj5IR2pM2vEOPpdhu9lpxVwBKZlxrU21P8tQm6iBxrBcU2Twpq0 DJErNg3B/ivCY+tJwX7Z/Vy4tcPZ1wW8xiILJquLLEX6XdI0IM9PtiKYmZjPdkxYrCsb p1u+dshkTNSOI7XvLEtoCmKutqPcSdDc8xiBa2fhlJprMS3CiQWTEh4uH91puGIXdP3w s9rBDlaXblnntNdBNfGg+bkkmKLqPrISroZTCCjq8uwJIKkQQh2Ya22HEhwMBhS9PrBu VIcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Ai2HsUP704GMlIzejaJoLn59RRK3/SzYyUuWR94MIL4=; b=xgPmeGmGeZBIwBBtaEQypSuNZozm/xZGsAY77kifV8lk9mFt+GAmQpMs1uBf5tcFeO ZaI6lD2f3hVmSeKj/nRyZofFIR7k0/F8GwCfAoGjpWxLOSRQ8SQu3nYZ3ZWA7iRvmtAS CIxkgHjmKtUxPt0cThP8f4RrNafk/jnU8YxRdBkG9H0JPQlKVt1bysfQxb3Zq4IgarDn Ls6BnD/ADouIKHBovzvZ+fR8xyaTNakxQKBG6kztA5y7mL1bfjOSpetRT0R76hogt2wl uuWJN5T5oAlHNK2aAcHzBskezprwKE9Q8NmEi1EGxUqZbd/cX8Azc6hRMZmMKOP2pvoG 7mqA== X-Gm-Message-State: ACgBeo2D9mEz7Tw+UIO+5DyM59NkkxtXJNjdd6hqFyRI+5mxvjTbp2U2 6SAw0x+1nGDz5Eb1DkiUTiM= X-Google-Smtp-Source: AA6agR4gkODGcvEaK8l0bY+IKrZkwI3Wy+SSMYjbe2r/KhNlG9XCutTuN0Lo4jAYYI5yqqRcnKkTeQ== X-Received: by 2002:a05:622a:2c2:b0:343:645f:1601 with SMTP id a2-20020a05622a02c200b00343645f1601mr4511482qtx.349.1660325394707; Fri, 12 Aug 2022 10:29:54 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id w20-20020a05620a0e9400b006b63679a433sm1975883qkm.133.2022.08.12.10.29.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 10:29:54 -0700 (PDT) Message-ID: <375eac04-dbfd-080a-3003-cae3eda1f42b@gmail.com> Date: Fri, 12 Aug 2022 10:29:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 3/3] memory: Add Broadcom STB memory controller driver Content-Language: en-US To: Krzysztof Kozlowski , Florian Fainelli , linux-kernel@vger.kernel.org Cc: Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20220801220931.181531-1-f.fainelli@gmail.com> <20220801220931.181531-4-f.fainelli@gmail.com> <26ad247d-a4b3-4051-b8d9-505c09b76f6b@linaro.org> From: Florian Fainelli In-Reply-To: <26ad247d-a4b3-4051-b8d9-505c09b76f6b@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220812_102959_741564_B37681A3 X-CRM114-Status: GOOD ( 18.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/9/22 02:58, Krzysztof Kozlowski wrote: > On 02/08/2022 01:09, Florian Fainelli wrote: >> Add support for configuring the Self Refresh Power Down (SRPD) >> inactivity timeout on Broadcom STB chips. This is used to conserve power >> when the DRAM activity is reduced. >> > > >> +static int __maybe_unused brcmstb_memc_resume(struct device *dev) >> +{ >> + struct brcmstb_memc *memc = dev_get_drvdata(dev); >> + >> + if (memc->timeout_cycles == 0) >> + return 0; >> + >> + return brcmstb_memc_srpd_config(memc, memc->timeout_cycles); >> +} >> + >> +static SIMPLE_DEV_PM_OPS(brcmstb_memc_pm_ops, brcmstb_memc_suspend, >> + brcmstb_memc_resume); >> + >> +static struct platform_driver brcmstb_memc_driver = { >> + .probe = brcmstb_memc_probe, >> + .remove = brcmstb_memc_remove, >> + .driver = { >> + .name = "brcmstb_memc", >> + .owner = THIS_MODULE, > > No need, run coccinelle. > >> + .of_match_table = brcmstb_memc_of_match, >> + .pm = &brcmstb_memc_pm_ops, > > Shouldn't this be pm_ptr()? and then no need for __maybe_unused in > brcmstb_memc_resume/suspend. How can one can remove __maybe_unused without causing a warning for the CONFIG_PM=n case, not that I needed to build to convince myself, but still did anyway: drivers/memory/brcmstb_memc.c:275:12: warning: 'brcmstb_memc_resume' defined but not used [-Wunused-function] static int brcmstb_memc_resume(struct device *dev) ^~~~~~~~~~~~~~~~~~~ drivers/memory/brcmstb_memc.c:252:12: warning: 'brcmstb_memc_suspend' defined but not used [-Wunused-function] static int brcmstb_memc_suspend(struct device *dev) ^~~~~~~~~~~~~~~~~~~~ unless you also implied enclosing those functions under an #if IS_ENABLED(CONFIG_PM) or something which is IMHO less preferable. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel