From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC53EC3DA6E for ; Thu, 28 Dec 2023 12:17:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NOiwkfWUYfEmzEEI9r/2UDtCZn51VxWCZzgy5ddVGg8=; b=GhQ20Kuxuog2BB YNSvyEMn8+wLYNvAHEBx+i0+2a6UvK+KraQPmgWmNuXXWYBPBuCFHx5D9YWHtxL+lxTGREdzv+2NL y70hF9oVTsgKU3zKnqoHOltiACeqrPPLtkhmOqRjrxjaLZlssCuv56IGYfOWCyN2WQEjFIoZRM0aT JXvG/17zmjjqnKkmZD8K3ZiBC4HUgdHUhq/TDrCpBsDncRBW7eBlZfk3Pfw5P7U00r+zBU7K7xWvv k1mKJ5MYZETPDQu11cY03Ue3SCipat0/31IzhblH7SeuiV3C/rL0SLt/LESYqhVWzanhLNH716zdD crq8adK8/zaPR+ExFwZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rIpJU-00Gp8I-2R; Thu, 28 Dec 2023 12:16:36 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rIpJS-00Gp7u-0q for linux-arm-kernel@lists.infradead.org; Thu, 28 Dec 2023 12:16:35 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50e7be1c65dso2710518e87.3 for ; Thu, 28 Dec 2023 04:16:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703765791; x=1704370591; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jy4IP1Kl2AB2GKEPjxgNpR4MZbSsWb2iMit5XkzF8Ao=; b=uDYIaZ6SzGcjYfyQCCWO2hCGyRGPBgVoV7lBF19+QiWaGQMlptoGiB43FU9CYkTTK5 dAuBKLmjnZ9aeyQy/M3Twv+sKfNlkGOGSJ4bDLuL0mwtcCitzY4Ql89y/+R3r3kqRYiJ 8g4H27unt+VnF+Ycd9bIWwFsnouuxSUy2ZRcigwybquObFV01+HS1qDcTXwWqlEPvwuS +aLRZADSuCnpBuJt3IeSH69f7gn49o0jUJ7zhRfEKCdXgvTgySJB62g+47sIrDXgFJAn uUWfsfEvx1ZS9Ac1dtBxKe1dP4Eptk5HYU+XCHvTQpTCwJ1+NdVLuIwnxSwIWtopbdI9 zVrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703765791; x=1704370591; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jy4IP1Kl2AB2GKEPjxgNpR4MZbSsWb2iMit5XkzF8Ao=; b=R4pA8LyZ2IcYlT7x+dS6YGyIuY64aSTOOYRWgiMIPPBvSQdwmD3iUHpVmYzR4G4AvY lx4Q2E1wOy3mLG1zbsOrSbB/PXYIirm7so8ZSTkj1cm7oxUMOSNPnWedrCQgCGPelezt KOAtTRvSxTCPbff+ojGDLSE1g+BG1JD24d2k2d4yjGBPQSuXT0jaHCCyXrfRQFENvDkE vho7KK1SXks30CHjqq7gqVVE4gFzGIpRuU+9bh26WeqtVpuROGc6/cFMT57hfw12WUpS Q4E31ZkhP/FNN4Q+muhRTGQbx63OKQEVRmGcE2s8DJUqd0dUKo5eo1F8qEN6UZ9rPUeE yg0Q== X-Gm-Message-State: AOJu0YyEcmi7CL7qyHlap2zU1J1JJzAXLV/NV4ax6Ge6gn7SFW3hDuh5 DIKiLlFFBuAUyk1kGUM+PGFkL7JYCVoS8g== X-Google-Smtp-Source: AGHT+IEzNnJxO9r5hkXRQO0iXze5pkEqQtXtFoux8xSIl8tKr4p2lrhCrIWVk0HGbp10NVjz6LVl8A== X-Received: by 2002:a05:6512:696:b0:50e:7e29:b0e9 with SMTP id t22-20020a056512069600b0050e7e29b0e9mr2616586lfe.73.1703765790949; Thu, 28 Dec 2023 04:16:30 -0800 (PST) Received: from [192.168.199.125] (178235179028.dynamic-4-waw-k-1-3-0.vectranet.pl. [178.235.179.28]) by smtp.gmail.com with ESMTPSA id mf6-20020a1709071a4600b00a26aa8f3372sm6798159ejc.27.2023.12.28.04.16.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Dec 2023 04:16:30 -0800 (PST) Message-ID: <376d3040-b9ed-4574-90d7-fb864d694e3c@linaro.org> Date: Thu, 28 Dec 2023 13:16:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] firmware/psci: Set pm_set_resume/suspend_via_firmware() on qcom Content-Language: en-US To: Sudeep Holla Cc: Mark Rutland , Lorenzo Pieralisi , Marijn Suijten , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Andersson References: <20231227-topic-psci_fw_sus-v1-0-6910add70bf3@linaro.org> <20231227-topic-psci_fw_sus-v1-2-6910add70bf3@linaro.org> <20231228102801.fzaubcjq5thfwgxg@bogus> <20231228115053.zlypgc5uxxvghi4a@bogus> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20231228115053.zlypgc5uxxvghi4a@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231228_041634_359853_52C0E3B2 X-CRM114-Status: GOOD ( 22.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28.12.2023 12:50, Sudeep Holla wrote: > On Thu, Dec 28, 2023 at 12:47:51PM +0100, Konrad Dybcio wrote: >> On 28.12.2023 11:28, Sudeep Holla wrote: >>> On Wed, Dec 27, 2023 at 11:15:31PM +0100, Konrad Dybcio wrote: >>>> Most Qualcomm platforms implementing PSCI (ab)use CPU_SUSPEND for >>>> entering various stages of suspend, across the SoC. These range from a >>>> simple WFI to a full-fledged power collapse of the entire chip >>>> (mostly, anyway). >>>> >>>> Some device drivers are curious to know whether "the firmware" (which is >>>> often assumed to be ACPI) takes care of suspending or resuming the >>>> platform. Set the flag that reports this behavior on the aforementioned >>>> chips. >>>> >>>> Some newer Qualcomm chips ship with firmware that actually advertises >>>> PSCI SYSTEM_SUSPEND, so the compatible list should only grow slightly. >>>> >>> >>> NACK, just use suspend-to-idle if SYSTEM_SUSPEND is not advertised. It is >>> designed for such platforms especially on x86/ACPI which don't advertise >>> Sx states. I see no reason why that doesn't work on ARM platforms as well. >> >> Not sure if I got the message through well, but the bottom line is, on >> Qualcomm platforms the "idle" states aren't actually just "idle" (read: >> they're not like S0ix). All but the most shallow ones shut down quite a >> chunk of the entire SoC, with the lowest ones being essentially S3 with >> power being cut off from the entire chip, except for the memory rail. >> > > No I understood that and S2I is exactly what you need. > Have you checked if S2I already works as intended on these platforms ? Yes, simple CPU idling works OOTB and the SoC power collapse only works given the developer doesn't cut corners when bringing up the platform (read: works on some of the ones we support, trying hard to expand that group!) > What extra do you achieve with this hack by advertising fake S2R ? Uh.. unless I misunderstood something, I'm not advertising s2ram.. Quite the opposite, I'm making sure only s2idle is allowed. Admittedly, my mistake, I managed to misname the function which I didn't spot before wrapping this patch up for sending.. > S2I will have less latency compared to S2R and the mem_sleep will be > automatically set to S2I if S2R is not supported, so no userspace impact > as well. Yes, everything that differs them is abstracted in TZ or through the power management coprocessor. > > So please let us know what this change provide extra over S2I ? Until > then my NACK still stands. The main point here is to advertise pm_resume/suspend_via_firmware, which represents that Qualcomm does a lot of not-very-obvious power wire plumbing within their PSCI impl. Konrad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel