From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BE4DC3DA64 for ; Thu, 1 Aug 2024 01:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AS1LCHXQtKq6pUr6NLuE7aPFuKrQxaWhJ6ltUhBJHx4=; b=CYaS/s1lAFvGXg/n7nvp+B2+ae Jb8XulIEG6L0UlAJgVM+G3jcnt6Ghu/Jt+Wr1TWsSNj3vU6bLss2U+Vv3dl+aDzYBXmQOs19NcMzm 8elqovl7LGaLiJqFHa7eGCaZ1BvFa3lvtSkc9b7KIW3dYeHWYdqUscKdXTmtViHiNNuZf0MgHfXgf wl2uT/dxngrbKxybkEcniQf07S7jk0DXhlv1oDhLje9PGO60mcwwkgcorh2NM8NB+d1/eGTiChzjV tD1bw1M8WhehnnJtI/OUSbWLyMv1wozW0SFUX/UtDcpkr5KShZpcIYJrE01b7jgkcKf7gENo3RTaB cqVQt2Eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZKrk-00000003IhD-0QTo; Thu, 01 Aug 2024 01:44:28 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZKrG-00000003IaE-1nIO for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 01:44:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1722476632; bh=AS1LCHXQtKq6pUr6NLuE7aPFuKrQxaWhJ6ltUhBJHx4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=ZA0/k13RoCLi1mQmZBnLLd2hgir5BGyXO7uh1qdFbf+okSL6+0jY1qv9XVKBw4Nb9 3NhSvt1DuycKpU5kJQyH+OR8lbx4iHd/kVGpbIZadSETlczSYmKIIPeSHuHTa+JTVw r/76CHEK79y5qMbXr83J9vB/YSowkNsgkvJcWNR5vTY1ihdZPDPONxoWgnmtn4XaiT f1vyjiW+jwzzunPdj6rHFh0deh4A1QdWvm8cakFR3CuS1wO4x/EQQQVAyOKnQo89qL UxCeZbYfd6aj2E20b++q/CpASU11v8C9t5Sc5rrkaN3GG58Ya2dHv36TQ7bVItWOk+ Y/Wv2hjFXddQQ== Received: from [192.168.68.112] (ppp118-210-29-70.adl-adc-lon-bras31.tpg.internode.on.net [118.210.29.70]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 4457164B84; Thu, 1 Aug 2024 09:43:51 +0800 (AWST) Message-ID: <3770677daec27d5cfa9c952ba03a77875bc24b56.camel@codeconstruct.com.au> Subject: Re: [PATCH] iio: adc: aspeed: Use of_property_present() From: Andrew Jeffery To: "Rob Herring (Arm)" , Jonathan Cameron , Lars-Peter Clausen , Joel Stanley Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Thu, 01 Aug 2024 11:13:50 +0930 In-Reply-To: <20240731191312.1710417-5-robh@kernel.org> References: <20240731191312.1710417-5-robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_184358_795432_B6B397D3 X-CRM114-Status: UNSURE ( 7.11 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2024-07-31 at 13:12 -0600, Rob Herring (Arm) wrote: > Use of_property_present() to test for property presence rather than > of_find_property(). This is part of a larger effort to remove callers > of of_find_property() and similar functions. of_find_property() leaks > the DT struct property and data pointers which is a problem for > dynamically allocated nodes which may be freed. >=20 > Signed-off-by: Rob Herring (Arm) Acked-by: Andrew Jeffery