From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C90CAC4332F for ; Wed, 13 Dec 2023 20:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JG/hAAUZT+ROPTdcCZEjb4vLv+G2uxXlPLpTrk9GuD4=; b=UdKaJ0OXYiUVP8 AF+EPbqrEO0V1YOg6WQcwSlfrP4/6ccpxwnHFk9UXVn39KZwE6NDis82HdKRBtYAwEoNEuXix0/HY QSbp5SHiy+x7jUx/h2M4ClR4A3UKaXgbCNOMVzpJPVwhXm85pjfB12m8ePrcuYoIiPQWyfC7m+FXz T9DG+fzt4rA0bRdnRzrsU6XYh78Yulz02l7HogDD9q6bIW8GDejJmyXIiBhWTJnDfRDPqhqQB6f62 BDTEpr2ZmzdfovmQFqSFzcs9BTucD64wu+XrlfuMJOQodAQJlb6I5HwPo3NQSZQH1sqidq/BFdcKx prmJiq+//sOHp1QhSBKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDVoX-00Fxop-2D; Wed, 13 Dec 2023 20:26:41 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDVoV-00Fxo7-07 for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 20:26:40 +0000 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-336445a2749so275851f8f.0 for ; Wed, 13 Dec 2023 12:26:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702499194; x=1703103994; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JGV9ovWt1T0TxLyTUNl8lJVAhcl8IWinEHZFMqlV8R0=; b=Ui16Dw94RsJ5k72kP0uXpMKmN5W5Iu7eIpJmXz2GICdr0cQW/L5UU5gIlSOPiJUtYH Tq/zbrIKcTMyZskeBnE3cHi6djumT7RIDedVy3SM0k8CshnDXtke8Dn3yE9ZgkqAZ2Bj AXgz3JW94gq62eYdjnhArlEPTbiBP7Vgmz319r8XjEs1ewb9p8vvY6AWU1eGqFXaf07T b9eZ8HZ7xktFsS9k4FrAv9EBq4tsVJKvMODgx3x9+8b1P77CGAZ/fN2EP1TZlscgUJWz FrOYezAc6371oBFfHjHCCCPx9HO8+aiQ04/vACkgmvoxHj07Oyr5VMKtV/4iIdNKtUu+ ZcSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702499194; x=1703103994; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JGV9ovWt1T0TxLyTUNl8lJVAhcl8IWinEHZFMqlV8R0=; b=phSgplJAqGLH7CS7hlsK6IS1ZLpHY1AYlsT3txCDGO0SVNmfCSC8lKcSMDROcljpsQ 87hVoaYpSkwwBzaB8aapt0vmol9tcasJqlc3nf+/c87dU/j5hOsIVBbbINs5xcrpRG6J YttVxJb7aoaUCJpm8C7bcKSimYf5gNC9Wip2xIJa27xQuHQLgVEUqE/CemNNaXdSGvRO bFL4bnCkqE3+8tCX3XvlMsqWsbIDJRYZYFGgT78Pc7I9EWnT6CTVMbHIUIi8dNj2DpPI Jwtk0+fI5lYlX91eSbXltuMgC/G7GzdH7gs5/So7xxDP5QLVpZiR7evBpCNFoJmWQMpV +Iwg== X-Gm-Message-State: AOJu0Yxc4ST+m2y0CQhQkdaWph3/0yyQCDWp8CeaC/PN3ycmTdQYi293 ONM3wu4cdh3PBxXVHlH7uWI= X-Google-Smtp-Source: AGHT+IGCl2qoP1T/NnW43knX1fCbT4M6OGvmsXKs/O9+AOQvHcSiKP9r2rbiyLldtzfSqmLZwS+qiA== X-Received: by 2002:a05:6000:194f:b0:332:ce52:6388 with SMTP id e15-20020a056000194f00b00332ce526388mr4258017wry.14.1702499194241; Wed, 13 Dec 2023 12:26:34 -0800 (PST) Received: from archlinux.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id m11-20020a056000008b00b0033332524235sm14110534wrx.82.2023.12.13.12.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 12:26:33 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Paul Kocialkowski Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Maxime Ripard , Laurent Pinchart , Michael Turquette , Stephen Boyd , Paul Kocialkowski Subject: Re: [PATCH v7 7/7] ARM: dts: sun8i-a83t: Add BananaPi M3 OV8865 camera overlay Date: Wed, 13 Dec 2023 21:26:32 +0100 Message-ID: <3780932.kQq0lBPeGt@archlinux> In-Reply-To: <20231122141426.329694-8-paul.kocialkowski@bootlin.com> References: <20231122141426.329694-1-paul.kocialkowski@bootlin.com> <20231122141426.329694-8-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_122639_075048_2D40D33D X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, same comments as for patch 6. Best regards, Jernej On Wednesday, November 22, 2023 3:14:25 PM CET Paul Kocialkowski wrote: > Add an overlay supporting the OV8865 from the BananaPi Camera v3 > peripheral board. The board has two sensors (OV5640 and OV8865) > which cannot be supported in parallel as they share the same reset > pin and the kernel currently has no support for this case. > = > Signed-off-by: Paul Kocialkowski > --- > arch/arm/boot/dts/allwinner/Makefile | 1 + > .../sun8i-a83t-bananapi-m3-camera-ov8865.dtso | 109 ++++++++++++++++++ > 2 files changed, 110 insertions(+) > create mode 100644 arch/arm/boot/dts/allwinner/sun8i-a83t-bananapi-m3-ca= mera-ov8865.dtso > = > diff --git a/arch/arm/boot/dts/allwinner/Makefile b/arch/arm/boot/dts/all= winner/Makefile > index a0a9aa6595e4..980ac88634e3 100644 > --- a/arch/arm/boot/dts/allwinner/Makefile > +++ b/arch/arm/boot/dts/allwinner/Makefile > @@ -278,6 +278,7 @@ dtb-$(CONFIG_MACH_SUN8I) +=3D \ > sun8i-a83t-allwinner-h8homlet-v2.dtb \ > sun8i-a83t-bananapi-m3.dtb \ > sun8i-a83t-bananapi-m3-camera-ov5640.dtbo \ > + sun8i-a83t-bananapi-m3-camera-ov8865.dtbo \ > sun8i-a83t-cubietruck-plus.dtb \ > sun8i-a83t-tbs-a711.dtb \ > sun8i-h2-plus-bananapi-m2-zero.dtb \ > diff --git a/arch/arm/boot/dts/allwinner/sun8i-a83t-bananapi-m3-camera-ov= 8865.dtso b/arch/arm/boot/dts/allwinner/sun8i-a83t-bananapi-m3-camera-ov886= 5.dtso > new file mode 100644 > index 000000000000..0656ee8d4bfe > --- /dev/null > +++ b/arch/arm/boot/dts/allwinner/sun8i-a83t-bananapi-m3-camera-ov8865.dt= so > @@ -0,0 +1,109 @@ > +// SPDX-License-Identifier: GPL-2.0 OR X11 > +/* > + * Copyright 2022 Bootlin > + * Author: K=E9vin L'h=F4pital > + * Author: Paul Kocialkowski > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include > +#include > + > +&{/} { > + /* > + * These regulators actually have DLDO4 tied to their EN pin, which is > + * described as input supply here for lack of a better representation. > + * Their actual supply is PS, which is always-on. > + */ > + > + ov8865_avdd: ov8865-avdd { > + compatible =3D "regulator-fixed"; > + regulator-name =3D "ov8865-avdd"; > + regulator-min-microvolt =3D <2800000>; > + regulator-max-microvolt =3D <2800000>; > + vin-supply =3D <®_dldo4>; > + }; > + > + ov8865_dovdd: ov8865-dovdd { > + compatible =3D "regulator-fixed"; > + regulator-name =3D "ov8865-dovdd"; > + regulator-min-microvolt =3D <2800000>; > + regulator-max-microvolt =3D <2800000>; > + vin-supply =3D <®_dldo4>; > + }; > + > + ov8865_dvdd: ov8865-dvdd { > + compatible =3D "regulator-fixed"; > + regulator-name =3D "ov8865-dvdd"; > + regulator-min-microvolt =3D <1200000>; > + regulator-max-microvolt =3D <1200000>; > + vin-supply =3D <®_dldo4>; > + }; > +}; > + > +&ccu { > + assigned-clocks =3D <&ccu CLK_CSI_MCLK>; > + assigned-clock-parents =3D <&osc24M>; > + assigned-clock-rates =3D <24000000>; > +}; > + > +&csi { > + status =3D "okay"; > +}; > + > +&i2c2 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&i2c2_pe_pins>; > + status =3D "okay"; > + > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + ov8865: camera@36 { > + compatible =3D "ovti,ov8865"; > + reg =3D <0x36>; > + > + clocks =3D <&ccu CLK_CSI_MCLK>; > + assigned-clocks =3D <&ccu CLK_CSI_MCLK>; > + assigned-clock-parents =3D <&osc24M>; > + assigned-clock-rates =3D <24000000>; > + > + avdd-supply =3D <&ov8865_avdd>; > + dovdd-supply =3D <&ov8865_dovdd>; > + dvdd-supply =3D <&ov8865_dvdd>; > + > + powerdown-gpios =3D <&pio 4 17 GPIO_ACTIVE_LOW>; /* PE17 */ > + reset-gpios =3D <&pio 4 16 GPIO_ACTIVE_LOW>; /* PE16 */ > + > + port { > + ov8865_out_mipi_csi2: endpoint { > + remote-endpoint =3D <&mipi_csi2_in_ov8865>; > + link-frequencies =3D /bits/ 64 <360000000>; > + data-lanes =3D <1 2 3 4>; > + }; > + }; > + }; > +}; > + > +&mipi_csi2 { > + status =3D "okay"; > +}; > + > +&mipi_csi2_in { > + mipi_csi2_in_ov8865: endpoint { > + remote-endpoint =3D <&ov8865_out_mipi_csi2>; > + data-lanes =3D <1 2 3 4>; > + }; > +}; > + > +&pio { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&csi_mclk_pin>; > +}; > + > +®_dldo4 { > + regulator-min-microvolt =3D <2800000>; > + regulator-max-microvolt =3D <2800000>; > +}; > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel