From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 634F5C4707B for ; Tue, 9 Jan 2024 20:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uiIMM8YFZ0nOGfJtx5pBYFhKJQPOCpy+lpQzZDAFvro=; b=r3Iw18QzigGNJs 6EnSGZhWsX08V24GWzU6V0/dl3FRG3REmmFkZvVywsb08PGz8U12Lvtg22NtY1FER3MarrRmEddCF 1rp2UCQMLLLaFHfWbN2JNrgYFWjyM1NiCBmVZfLgP2P8DEwvY2ilGWsBuTOnC00vAgrPDyfdGOl/h VaoyfCJPgUjp647LRGf1ucW5VV0OSxPHbpwRyUCiou5o7ZWdEOC8nBJTTKxjIBQ0vq7x2gzDaCkqM DS87sNBdoZ2obYzk5dqkIr3QE+UDPrY9rWjjSdNj0JvVZtLm2iQI6ACXItZ/WnV5WuR2+E1qiyTgl I/YQNU9AnFM+iS51g3+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNIW1-009QTv-0g; Tue, 09 Jan 2024 20:16:01 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNIVy-009QTK-0K for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 20:15:59 +0000 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-336c8ab0b20so3184974f8f.1 for ; Tue, 09 Jan 2024 12:15:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704831354; x=1705436154; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MQBuQHYjeBWmqCwTGH4YkN69mVB+VC/t7tF3wqgLXWM=; b=ZVXv0sp9CyXYcDOuMlQKluoq/RmyYE/K8gX+yWlOl3oaYBrnZSNdyDs2UVQ/Wb+hoW /wpqFM2xN59Pox4yruxNHqWyqEPsqZAyG774CQyK424CPHWGmqA0PVim1H/n/PQSPcl9 iJf8b7dpcNBsX+Wk3OOuAt/VrV1l/I0oU/WUBgmcJTFR8/nEQgeAEkYR0z9LM+Q3wcVq jpBk7ZSgGk5/xZ4QIcbHqdAPF5LmxFjB6UMGlKYE+TpaOHqmiQZZkNO9OuwySlAQuXVJ /sjDdDSZjk+HwncOfY7eeUuHr7GnYssbcddfdSCvA7JolauVt2he7uSkKhPWxnd9HHBe NviA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704831354; x=1705436154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MQBuQHYjeBWmqCwTGH4YkN69mVB+VC/t7tF3wqgLXWM=; b=c0q9FOjNNEndIillxThJfEXUdl6I57K1Qy0N1fzSRK8YZwJaY5GjszkPXsSjlvtBVB OTkYkXyHRlLBchi/vBuKrTQ+3Yhe87zCcnk63va9IIn8IznoVlG+o/Wn3u2SztWaxHCF sJ7CxKooPgQRDFMqPIBva3f5HyJ1z5DoXZoHlFRMO1ugAgUWlgRBN5QPoDBtGK3SfVwP TxFpgauK5l2CdMZ2c9gabM4ADSTeKSb9OO+StUXOcvT7HjZQoiC8tndBDmqwvrqEiWev FQAJrOF3ZY71IrAd84Ek9VlRy8UwOltA/4vyZ1wZyZWNOnR/r4MhTNy8KHAcFoenxKqv DFcw== X-Gm-Message-State: AOJu0YyVBHUTajKMxSrc5IJJPePqc5TTRzy2rXdvDAowsv3kiZgBo5iG fNNSQkW7tKs8jYNsB9Aord4= X-Google-Smtp-Source: AGHT+IE4R7zgERsrbs9fWbJ69vzmnx8iBlzpLeYPnFGrt0JnjOw8UGQcz7XjE6871uIgRVOA/YyG7Q== X-Received: by 2002:a05:6000:543:b0:336:ec62:ea8b with SMTP id b3-20020a056000054300b00336ec62ea8bmr841769wrf.63.1704831354380; Tue, 09 Jan 2024 12:15:54 -0800 (PST) Received: from jernej-laptop.localnet (213-161-3-116.dynamic.telemach.net. [213.161.3.116]) by smtp.gmail.com with ESMTPSA id cr8-20020a05600004e800b00336673a4153sm3191685wrb.80.2024.01.09.12.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 12:15:54 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Jassi Brar , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Chen-Yu Tsai , Samuel Holland , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 10/12] mailbox: sun6i-msgbox: Convert to platform remove callback returning void Date: Tue, 09 Jan 2024 21:15:52 +0100 Message-ID: <3783111.kQq0lBPeGt@jernej-laptop> In-Reply-To: <2db7ef94aa35587980697405ec373e0b7bb70466.1703710628.git.u.kleine-koenig@pengutronix.de> References: <2db7ef94aa35587980697405ec373e0b7bb70466.1703710628.git.u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240109_121558_142586_65FB122D X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 27. december 2023 ob 22:02:38 CET je Uwe Kleine-K=F6nig napisal(= a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > = > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel