From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB8D7C282CB for ; Tue, 5 Feb 2019 14:15:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD1B3217F9 for ; Tue, 5 Feb 2019 14:15:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ov3NN2ZE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD1B3217F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i2se.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vEXQiA0L+D6zkvYm+HtPXjpAKLu6liMzW5eW1rTjiW4=; b=ov3NN2ZEN6xDrk ahtk5hLEkxKS+JO1QP13RXSR5mYoYubLMtgSQGTtH9K+LTcTA6pEy1pXHr3y1jmGBebp8PTb3odUg g812TG+jSyRS0VqRVeQ58ucq5GtDrRpNAiFA9E8d8JxTtkl1n4jWcdFL+VF+PGWVLFmgyEv9BKNGj rK5vi9b9BggzbY+PPim7efO5/CLuF1hBJA70PCUGZ/NR2Nlg4e9p1q1n6IviesBNr7E6eko9Go/CQ +0KpS7vRwtSpj7i5Aqd6QSTuR5I79H/0aIpfmJ8mxhO4jR2JMP+41Dtg2rhVQ1f/jDAWfOasxMbtx yWlbA21FL5y19R1Q7New==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gr1V7-0003Ss-9Y; Tue, 05 Feb 2019 14:15:01 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gr1Uv-0003Ho-Po; Tue, 05 Feb 2019 14:14:53 +0000 Received: from [192.168.178.52] ([109.104.46.226]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MfHUx-1hJjTa3b4d-00gryI; Tue, 05 Feb 2019 15:14:37 +0100 Subject: Re: [PATCH v2] i2c: bcm2835: Clear current buffer pointers and counts after a transfer To: Wolfram Sang , Paul Kocialkowski References: <20181227154225.5492-1-paul.kocialkowski@bootlin.com> <20190205120905.GB1045@kunai> From: Stefan Wahren Message-ID: <3784fe11-bdc4-5751-13b4-f50bdeeee205@i2se.com> Date: Tue, 5 Feb 2019 15:14:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190205120905.GB1045@kunai> Content-Language: en-US X-Provags-ID: V03:K1:nQmOSq0Sytf9T6z48blffv0JlWaArSj5LejxShFwdHoS44WeU+p MdNeW0T1thqMZD9avGYHMeAv8COndE32Qrtg4jonqg51J2Eh08Q6KumI+TRBQ6uyU88q1xg hWqNJCPILKg1KVTrhnfqRFHX+Q+zXBkL5vgGHbX6f51sD7akSqSSt21L1wbhr2iGrzpMYIj Ard2p4+MtZL8zm6EpTIEA== X-UI-Out-Filterresults: notjunk:1;V03:K0:5pg5KoYkHdQ=:XtBcIpjc/dtUE+Gcxf6LuU I0PSQoTfhBUDVbpFoktoWhz0n6SrQygkMmww5bLPfI3g4S6+ucbO1D6TsB8uEt66ujSu1aTv0 IyDQK/FTEGQLomrAn+6eHeYfDTJuZ15Kfb5kOOdg7+tyBKfrAeP00jyFanUHIVh+0ZBSo6neA AWuVbc77B2c78qMt4FGFE1o/c3a9CqZWNxkTCw64GlU4J9zf5wYElqQWk2M1C/o26TwkZmuwC QNEArncSnKeKmilrvWhRQcZRqs+7URtFkoRq9ZwEWKY07ZYoefZf2fWEt1B4yjBJGz/Zv0rkx 5l+D021cLAnx3VqQKgYkT611n2ZVDg6WCN/eP1S5GFki1HPcq738VI2muf3BAi6MQG+tdtkih PnUmfhiewQjCtvRkdbooQGaKpVMsJSRxoXiunaEIscdySEe+iGYnreCP8kq4MnsiZa18W9i7A EoFB5Y+TYA2ZxHNQooOWe/OFR27Vc2poeud8bYHyWWg29e4fsswv+pzBg/X5qxeC80Ee1Zwcf MGbTX+ReKdXGWqQTHkm5VJy/CM1GyG8K8hbzjdQrp3Y4AAnTIB5CMqVIEaptDdSOuGAdwWzxf rUgaF9GLQz5Bi+b07/XmZegXCtxwWGEdeXM5O8Buy61vvBU0TthkXMe6B+LWIh75t4+2pzqt9 LF6oDj5NWSizkTr1JyoAScZ2qx+PwiQ7dnhEqAo/DEE5yJ52HD2j0zaPP6z95FSXouTFk+eyT utSDjO4wa/UOopOC+ZmRiF4Y891DwJApThgH/H+Yfg13eHDZejfsLz0FJOc= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190205_061450_240439_EC411D8A X-CRM114-Status: GOOD ( 14.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Scott Branden , Eben Upton , Maxime Ripard , Ray Jui , linux-kernel@vger.kernel.org, Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 05.02.19 um 13:09 schrieb Wolfram Sang: > On Thu, Dec 27, 2018 at 04:42:25PM +0100, Paul Kocialkowski wrote: >> The driver's interrupt handler checks whether a message is currently >> being handled with the curr_msg pointer. When it is NULL, the interrupt >> is considered to be unexpected. Similarly, the i2c_start_transfer >> routine checks for the remaining number of messages to handle in >> num_msgs. >> >> However, these values are never cleared and always keep the message and >> number relevant to the latest transfer (which might be done already and >> the underlying message memory might have been freed). >> >> When an unexpected interrupt hits with the DONE bit set, the isr will >> then try to access the flags field of the curr_msg structure, leading >> to a fatal page fault. >> >> The msg_buf and msg_buf_remaining fields are also never cleared at the >> end of the transfer, which can lead to similar pitfalls. >> >> Fix these issues by introducing a cleanup function and always calling >> it after a transfer is finished. >> >> Fixes: e2474541032d ("i2c: bcm2835: Fix hang for writing messages larger than 16 bytes") >> Signed-off-by: Paul Kocialkowski > Stefan, Florian, any comment about this patch? Acked-by: Stefan Wahren Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel