Re: [PATCH 13/16] arm64: dts: allwinner: a64: Add HDMI audio

Jernej Škrabec
2020-07-08T16:03:21Z

Hi!

Dne ponedeljek, 06. julij 2020 ob 07:31:23 CEST je Maxime Ripard napisal(a):
> On Sat, Jul 04, 2020 at 01:38:59PM +0200, Clément Péron wrote:
> > From: Marcus Cooper <codekipper@gmail.com>
> >
> > Add a simple-soundcard to link audio between HDMI and I2S.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> >
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 21 +++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index
> > c662f6a170ce..6a321fdc8e90 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -102,6 +102,25 @@ de: display-engine {
> >
> > status = "disabled";
> >
> > };
> >
> > + hdmi_sound: hdmi-sound {
> > + compatible = "simple-audio-card";
> > + simple-audio-card,format = "i2s";
> > + simple-audio-card,name = "sun50i-a64-hdmi";
> > + simple-audio-card,mclk-fs = <128>;
> > + simple-audio-card,frame-inversion;
> > + status = "disabled";
> > +
> > + simple-audio-card,codec {
> > + sound-dai = <&hdmi>;
> > + };
> > +
> > + simple-audio-card,cpu {
> > + sound-dai = <&i2s2>;
> > + dai-tdm-slot-num = <2>;
> > + dai-tdm-slot-width = <32>;
> > + };
> > + };
> > +
> >
> > osc24M: osc24M_clk {
> >
> > #clock-cells = <0>;
> > compatible = "fixed-clock";
> >
> > @@ -856,6 +875,7 @@ i2s2: i2s@1c22800 {
> >
> > resets = <&ccu RST_BUS_I2S2>;
> > dma-names = "tx";
> > dmas = <&dma 27>;
> >
> > + allwinner,playback-channels = <8>;
>
> This isn't documented anywhere

This can be safely dropped. It is just leftover from multi-channel (>2) work,
which will have to be redesigned anyway.

Best regards,
Jernej