From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4B3CC4345F for ; Mon, 15 Apr 2024 21:25:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rbXIf83QkN0wkQz8qUyEDIa5smOQHwe3u1N6kE8LPfw=; b=VwuojaRob78AF0 6sKEf4dX/WBSpuPq9Umm3J/WOj0CYGMxVmbD34rNagJNC86cX51bEwaJS2qno5on9qVIGKV4iPtF4 w4+2Yk10jOSymXM2+H6wkabY3zYiYEMY9gLePimtfnp5yJcFm3vALawSNFTA4s1PNgX0qiamP9NOk U8a17Dz8HPPPekQwPyO9lIRmwAyoh6x1K5RqnZAghIIdVKfbWkfvrFvWqbn4+RR666qSbmHldpy5K GraOdFuerGKCpfHFexnv8h7AFul+hS8shKY5PNTn/qWGtGRttHxQd2V0d9mbYvoVkxbErcbWslJrp /CfbYmSnVDDiUJhHOITA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwTpj-00000009xW0-20gv; Mon, 15 Apr 2024 21:25:47 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwTph-00000009xVE-1ioK for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 21:25:46 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3455ff1339dso2516312f8f.0 for ; Mon, 15 Apr 2024 14:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713216338; x=1713821138; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I6Ar2yG1hipbO/wSAi/ZjpkXRjk4zWz8MUQpTTF6vT8=; b=lS7+FPf/6fRlH8l5+IeEYSCR+HqeqZCDACwzI4qgetpJxTxgU+bYpoBgtHtjtRLwRd MdcL0DqEdYnTug0ofviYey69Yt9sraMNFZrlDK1wlnCncLKWgKhi4xsmfle2uBMIkLu/ dw39v5nzVGOLbzkiVSPBJ2oqdtib/OCbMSl+OJaFdMupihWglCboi50S4bDkYdDMcQKD WOqMPY1I8iDK3R9Qge/RylB0vJmOK83FtD+52R25WcAuLLFjNmGs7SR5n0kp2tK3ISV9 25B+TTgFCXKJJISOGpSaPN7wgE26BY5+CiriJOAe1RERdIlhJVlOJE1vNFEJDsXQRg3y ZvyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713216338; x=1713821138; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I6Ar2yG1hipbO/wSAi/ZjpkXRjk4zWz8MUQpTTF6vT8=; b=PuA/tVPQ0SRNeZPe/n5x59jDnA7N9Jao4zVF3aq3EH7T9Jq4ANKsJZyIqd1x2Plc5U ZUCLUWTG4wyafRL6PxK/54zYmz5dhnCZP2ZskkghtXgPRKesbdXcFytj0tQlJadWvRex YBusJe9CajqIj80QXRaKDDq86RZhr1gVwj2DUPuHC0QmS+0qz5aSc7XNhyS33sVbjsbO kZ1bxdYnDLcA6tGzpRnLKhNjJwoSXYra59thdbARDNVRXLONtoRwEqa/gNNXUCR60ptY Q8QLBwcAkaZ85i5s8feNY6AASACMJ9zhynXmfiYXs9DRpmbjrcDShcuMKAlZh6qUHt73 clyw== X-Forwarded-Encrypted: i=1; AJvYcCXgo2/ocr+c1FR2TZHnTieG4TPRh1cLPSNySHoJO+3byUuiFNXlphPTzoG+Tm6nhqHiXy8hA1O/6VKKJfuMlT+laE5SuFRocLT+6aK9/Dyx+yIbZhk= X-Gm-Message-State: AOJu0YzByk9g7p+QsxlcLKMLr6aeT8ntrSOHCGbUoaPBPmWQI5Ve5C2W koRIJYIh28+3mmPh+RbBWGQUCqYSgHOTTY9DxhX0tjmbXsBGwbPY X-Google-Smtp-Source: AGHT+IHVDq4wHkTRDLnml3w8/vY76YStJGi0lNRDZ+kQK8Q3T8+RWX2Nxrxp2FGdXz1LeKjvjVxvOA== X-Received: by 2002:adf:cc89:0:b0:348:b435:273e with SMTP id p9-20020adfcc89000000b00348b435273emr161943wrj.48.1713216337895; Mon, 15 Apr 2024 14:25:37 -0700 (PDT) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id e3-20020a5d5943000000b00346c169362esm12606521wri.23.2024.04.15.14.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 14:25:37 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Maxime Ripard , Frank Oltmanns Cc: Guido =?ISO-8859-1?Q?G=FCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, stable@vger.kernel.org, Diego Roversi , Erico Nunes Subject: Re: [PATCH v4 0/5] Pinephone video out fixes (flipping between two frames) Date: Mon, 15 Apr 2024 23:25:35 +0200 Message-ID: <3799968.kQq0lBPeGt@jernej-laptop> In-Reply-To: <87frw2a2e4.fsf@oltmanns.dev> References: <20240310-pinephone-pll-fixes-v4-0-46fc80c83637@oltmanns.dev> <87frw2a2e4.fsf@oltmanns.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_142545_459258_ABD41F4B X-CRM114-Status: GOOD ( 32.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 3. april 2024 ob 17:31:47 GMT +2 je Frank Oltmanns napisal(a): > Dear clk and sunxi-ng maintainers, > > Patches 1-4 have been reviewed and there are no pending issues. If there > is something else you need me to do to get this applied, please let me > know. Sorry for late patch merge. Patch 1-2 are applied as a fix to 6.9, the rest will go to 6.10. Best regards, Jernej > > Thanks, > Frank > > On 2024-03-10 at 14:21:10 +0100, Frank Oltmanns wrote: > > On some pinephones the video output sometimes freezes (flips between two > > frames) [1]. It seems to be that the reason for this behaviour is that > > PLL-MIPI is outside its limits, and the GPU is not running at a fixed > > rate. > > > > In this patch series I propose the following changes: > > 1. sunxi-ng: Adhere to the following constraints given in the > > Allwinner A64 Manual regarding PLL-MIPI: > > * M/N <= 3 > > * (PLL_VIDEO0)/M >= 24MHz > > * 500MHz <= clockrate <= 1400MHz > > > > 2. Remove two operating points from the A64 DTS OPPs, so that the GPU > > runs at a fixed rate of 432 MHz. > > > > Note, that when pinning the GPU to 432 MHz the issue [1] completely > > disappears for me. I've searched the BSP and could not find any > > indication that supports the idea of having the three OPPs. The only > > frequency I found in the BPSs for A64 is 432 MHz, which has also proven > > stable for me. > > > > I very much appreciate your feedback! > > > > [1] https://gitlab.com/postmarketOS/pmaports/-/issues/805 > > > > Signed-off-by: Frank Oltmanns > > --- > > Changes in v4: > > - sunxi-ng: common: Address review comments. > > - Link to v3: https://lore.kernel.org/r/20240304-pinephone-pll-fixes-v3-0-94ab828f269a@oltmanns.dev > > > > Changes in v3: > > - dts: Pin GPU to 432 MHz. > > - nkm and a64: Move minimum and maximum rate handling to the common part > > of the sunxi-ng driver. > > - Removed st7703 patch from series. > > - Link to v2: https://lore.kernel.org/r/20240205-pinephone-pll-fixes-v2-0-96a46a2d8c9b@oltmanns.dev > > > > Changes in v2: > > - dts: Increase minimum GPU frequency to 192 MHz. > > - nkm and a64: Add minimum and maximum rate for PLL-MIPI. > > - nkm: Use the same approach for skipping invalid rates in > > ccu_nkm_find_best() as in ccu_nkm_find_best_with_parent_adj(). > > - nkm: Improve names for ratio struct members and hence get rid of > > describing comments. > > - nkm and a64: Correct description in the commit messages: M/N <= 3 > > - Remove patches for nm as they were not needed. > > - st7703: Rework the commit message to cover more background for the > > change. > > - Link to v1: https://lore.kernel.org/r/20231218-pinephone-pll-fixes-v1-0-e238b6ed6dc1@oltmanns.dev > > > > --- > > Frank Oltmanns (5): > > clk: sunxi-ng: common: Support minimum and maximum rate > > clk: sunxi-ng: a64: Set minimum and maximum rate for PLL-MIPI > > clk: sunxi-ng: nkm: Support constraints on m/n ratio and parent rate > > clk: sunxi-ng: a64: Add constraints on PLL-MIPI's n/m ratio and parent rate > > arm64: dts: allwinner: a64: Run GPU at 432 MHz > > > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 -------- > > drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 14 +++++++++----- > > drivers/clk/sunxi-ng/ccu_common.c | 19 +++++++++++++++++++ > > drivers/clk/sunxi-ng/ccu_common.h | 3 +++ > > drivers/clk/sunxi-ng/ccu_nkm.c | 21 +++++++++++++++++++++ > > drivers/clk/sunxi-ng/ccu_nkm.h | 2 ++ > > 6 files changed, 54 insertions(+), 13 deletions(-) > > --- > > base-commit: dcb6c8ee6acc6c347caec1e73fb900c0f4ff9806 > > change-id: 20231218-pinephone-pll-fixes-0ccdfde273e4 > > > > Best regards, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel