From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 814B1C43334 for ; Tue, 7 Jun 2022 05:05:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7t2O5426dKiJveLKAW9/jfpSCxcaNC5kL7QprOqUjV4=; b=4OnafaxsShF9PT fSWiybfF5DiiD1yDsamSDUAbLrcNEPfQgs9kYvuM0mn/+nX1OT/sS2offfRaVYqQbd3h+zvodkfJr VbDcxVCfZZUIHo8/wp7FcQ88F1/7zsTMR0wpIouqOtF/RoFWFHmbVvuNaow4So/hKvRIcPIp8hQeR 1Ulmr0oU0T/BKSWLMFfmaR9v0RjnjYjyqI1YkNo/sdZS/69d2lGq56iMqNFSxbrY6U8OcbsheT7hL g3qbVpVJagMx5JyuuTqy5TqNF8A+qeVwCH8viKYnBAdYn+rQVmKtXRicRpTFiWtgoo2MjDIeo5Ldm Gx+VdGbpfD6yvtVx8FfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyRO9-004l1s-7I; Tue, 07 Jun 2022 05:04:21 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyRO5-004kzO-N7 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 05:04:19 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25754BWT013755; Tue, 7 Jun 2022 00:04:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1654578251; bh=LuyJp6N2+OSRRSCMTgRGlAsY50dcRaUtJNXh97nhDcw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=LGQLeIUFehUMVRddXGsbBAUwn98Txzayy1mu+Htw/cWRp1SqI7xa54Z0vWJw1v8VS PoC03iinNDyZRo2HttU17al509mLTTroHnvyrlXczBgGM/in0zgvi9xB+2A1bBr5Gx 3XmqiVcpApZ2STi6dLMlVI3JcmfB5Am4WsrqMDmI= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25754Bro003108 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 7 Jun 2022 00:04:11 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 7 Jun 2022 00:04:10 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Tue, 7 Jun 2022 00:04:10 -0500 Received: from [172.24.220.119] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25753v3M120195; Tue, 7 Jun 2022 00:03:59 -0500 Message-ID: <37bbd74e-17e2-5b45-43da-f1103dd0c752@ti.com> Date: Tue, 7 Jun 2022 10:33:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4 0/6] Introduce PRU remoteproc consumer API Content-Language: en-US To: Mathieu Poirier References: <20220603121520.13730-1-p-mohan@ti.com> <20220606155612.GA809345@p14s> <20220606161518.GB809345@p14s> From: Puranjay Mohan In-Reply-To: <20220606161518.GB809345@p14s> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_220417_909689_66CF6E17 X-CRM114-Status: GOOD ( 22.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, kishon@ti.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, rogerq@kernel.org, krzysztof.kozlowski+dt@linaro.org, ssantosh@kernel.org, robh@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On 06/06/22 21:45, Mathieu Poirier wrote: > On Mon, Jun 06, 2022 at 09:56:12AM -0600, Mathieu Poirier wrote: >> I have started to review this set, comments will come over the next few days. I >> will clearly inform you when I am done reviewing. > > This patch is giving me several checkpatch warnings that should have been caught > before sending the patches out to the mailing list. As such I will not review > this work and seriously considering adding your next revision at the very bottom > of my queue. I am sorry for this. I had introduced the 6th patch in v4 and it is giving these errors. I have fixed them and sent a v5. Please don't move the v5 to the bottom of the queue. I will be extra cautious from next time. Thanks, Puranjay Mohan > >> >> Thanks, >> Mathieu >> >> On Fri, Jun 03, 2022 at 05:45:14PM +0530, Puranjay Mohan wrote: >>> This is the v4 of the patch series [1]. The v3 had some comments >>> on the DT patch that have been addressed here. The 6th patch in this >>> series was missed in the previous versions, so, it has been added now. >>> >>> I have posted two more patch series that depend on this series, one to >>> the soc tree and another to the networking tree. I had sent all the 3 >>> series, including this one as RFC [2] to get comments and to explain the >>> dependencies. >>> >>> The Programmable Real-Time Unit and Industrial Communication Subsystem >>> (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit >>> RISC cores (Programmable Real-Time Units, or PRUs) for program execution. >>> >>> There are 3 foundation components for PRUSS subsystem: the PRUSS platform >>> driver, the PRUSS INTC driver and the PRUSS remoteproc driver. All were >>> already merged and can be found under: >>> 1) drivers/soc/ti/pruss.c >>> Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml >>> 2) drivers/irqchip/irq-pruss-intc.c >>> Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml >>> 3) drivers/remoteproc/pru_rproc.c >>> Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml >>> >>> The programmable nature of the PRUs provide flexibility to implement custom >>> peripheral interfaces, fast real-time responses, or specialized data handling. >>> Example of a PRU consumer drivers will be: >>> - Software UART over PRUSS >>> - PRU-ICSS Ethernet EMAC >>> >>> In order to make usage of common PRU resources and allow the consumer drivers to >>> configure the PRU hardware for specific usage the PRU API is introduced. >>> >>> [1] https://patchwork.kernel.org/project/linux-remoteproc/cover/20220418104118.12878-1-p-mohan@ti.com/ >>> [2] https://patchwork.kernel.org/project/linux-remoteproc/cover/20220406094358.7895-1-p-mohan@ti.com/ >>> >>> Thanks and Regards, >>> Puranjay Mohan >>> >>> Roger Quadros (1): >>> remoteproc: pru: Add pru_rproc_set_ctable() function >>> >>> Suman Anna (2): >>> dt-bindings: remoteproc: Add PRU consumer bindings >>> remoteproc: pru: Make sysfs entries read-only for PRU client driven >>> boots >>> >>> Tero Kristo (3): >>> remoteproc: pru: Add APIs to get and put the PRU cores >>> remoteproc: pru: Configure firmware based on client setup >>> remoteproc: pru: add support for configuring GPMUX based on client >>> setup >>> >>> .../bindings/remoteproc/ti,pru-consumer.yaml | 69 +++++ >>> drivers/remoteproc/pru_rproc.c | 254 +++++++++++++++++- >>> include/linux/pruss.h | 78 ++++++ >>> 3 files changed, 396 insertions(+), 5 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml >>> create mode 100644 include/linux/pruss.h >>> >>> -- >>> 2.17.1 >>> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel