From: "Arnd Bergmann" <arnd@arndb.de>
To: "Vivek Yadav" <vivek.2311@samsung.com>,
rcsekar@samsung.com, krzysztof.kozlowski+dt@linaro.org,
"Wolfgang Grandegger" <wg@grandegger.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
pankaj.dubey@samsung.com, ravi.patel@samsung.com,
"Alim Akhtar" <alim.akhtar@samsung.com>,
linux-fsd@tesla.com, "Rob Herring" <robh+dt@kernel.org>
Cc: linux-can@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
aswani.reddy@samsung.com, sriranjani.p@samsung.com,
ajaykumar.rs@samsung.com
Subject: Re: [PATCH] arm64: dts: fsd: Change the reg properties from 64-bit to 32-bit
Date: Wed, 16 Nov 2022 12:16:49 +0100 [thread overview]
Message-ID: <37d42235-1960-4001-9be9-20a85de54730@app.fastmail.com> (raw)
In-Reply-To: <20221116091247.52388-1-vivek.2311@samsung.com>
On Wed, Nov 16, 2022, at 10:12, Vivek Yadav wrote:
> Change the reg properties from 64-bit to 32-bit for all IPs, as none of
> the nodes are above 32-bit range in the fsd SoC.
>
> Since dma-ranges length does not fit into 32-bit size, keep it 64-bit
> and move it to specific node where it is used instead of SoC section.
I don't think that works, the dma-ranges property is part of the
bus, not a particular device:
mdma0: dma-controller@10100000 {
compatible = "arm,pl330", "arm,primecell";
- reg = <0x0 0x10100000 0x0 0x1000>;
+ reg = <0x10100000 0x1000>;
interrupts = <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>;
#dma-cells = <1>;
clocks = <&clock_imem IMEM_DMA0_IPCLKPORT_ACLK>;
clock-names = "apb_pclk";
iommus = <&smmu_imem 0x800 0x0>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ dma-ranges = <0x0 0x0 0x0 0x10 0x0>;
};
Since the dma-controller has no children, I don't see how this has
any effect. Also, translating a 36-bit address into a 32-bit
address just means it gets truncated anyway, so there is no
point in making it appear to have a larger address range.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-16 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221116090644epcas5p3a0fa6d51819a2b2a9570f236191748ea@epcas5p3.samsung.com>
2022-11-16 9:12 ` [PATCH] arm64: dts: fsd: Change the reg properties from 64-bit to 32-bit Vivek Yadav
2022-11-16 11:16 ` Arnd Bergmann [this message]
2022-11-16 12:38 ` Robin Murphy
2022-11-16 12:44 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37d42235-1960-4001-9be9-20a85de54730@app.fastmail.com \
--to=arnd@arndb.de \
--cc=ajaykumar.rs@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=aswani.reddy@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pankaj.dubey@samsung.com \
--cc=ravi.patel@samsung.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sriranjani.p@samsung.com \
--cc=vivek.2311@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox