From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50957EEEC3B for ; Fri, 13 Sep 2024 13:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kOjAOx7ACaKkLgFxncr9EWKB/WfNidIRAWD6qd8auz0=; b=BacPFlUCELdhYrqI5b+bjgP7ff 6qZoiT7N2/SAT8Fujsif3tbEq2FScBeeMcdpI0EUlAUqLf3xl1TM38HyDQqbf+2Pn0iUCEo7aKnTK lxdzE882xHmpOhUy8oXJOFToJ6hYTM9FPnfIIgwvbDuUdzGI8xx9KTXBIqNL9OKnlchwIc1sqalS4 1uvl1AlmK1qVFbASAa18WOaeKYEkra88pSfKELpxy2Zggqo/KLMeIa7a4CDon0KA0ZZPrVNkY80p2 8W20p38Trm2YKTP/9DkTOe4nzIvmrA6+11kuvacVZ4x25viVykUAhFczPbg88XMY+aR30rWgPWx3b k2oy2oMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sp5yV-0000000Fywu-3hLX; Fri, 13 Sep 2024 13:04:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sp5xQ-0000000Fyrb-48ZW for linux-arm-kernel@lists.infradead.org; Fri, 13 Sep 2024 13:03:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6EFFD13D5; Fri, 13 Sep 2024 06:03:57 -0700 (PDT) Received: from [10.2.76.71] (e132581.arm.com [10.2.76.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2413D3F73B; Fri, 13 Sep 2024 06:03:25 -0700 (PDT) Message-ID: <37f8d0c3-f1fc-495f-b4c4-549ffa0435d1@arm.com> Date: Fri, 13 Sep 2024 14:03:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] perf cs-etm: Use new OpenCSD consistency checks To: James Clark Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan , Ben Gainey , Ruidong Tian , Benjamin Gray , Mathieu Poirier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, gankulkarni@os.amperecomputing.com, coresight@lists.linaro.org, scclevenger@os.amperecomputing.com References: <20240912151143.1264483-1-james.clark@linaro.org> <20240912151143.1264483-3-james.clark@linaro.org> <332e0654-df8c-44b1-8e55-398aeba37b08@linaro.org> Content-Language: en-US From: Leo Yan In-Reply-To: <332e0654-df8c-44b1-8e55-398aeba37b08@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240913_060329_075766_331106B5 X-CRM114-Status: UNSURE ( 8.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/13/24 13:09, James Clark wrote: [...] >> Just one question: should the flag ETM4_OPFLG_PKTDEC_AA64_OPCODE_CHK be set >> according to ETM version? E.g. it should be only set for ETMv4 or this is >> fine for ETE as well. > > I asked Mike the same question about ETMv3 and he said none of the flags > overlap and it was ok to always pass them. So I assume the same applies > to ETE as well. Thanks for confirmation. This is my review tag: Reviewed-by: Leo Yan