From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F21C35247 for ; Wed, 5 Feb 2020 19:03:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5A8521741 for ; Wed, 5 Feb 2020 19:03:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o0ks+98D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5A8521741 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VBPjg7Xmrty8o8SHaXCkCT18pVLs5KxHTZUqv5D9Ydk=; b=o0ks+98DEft+uT7spM7l3n1LY rOER5Wz6z/tOSwshDURkU7hcJ0Q5FKwxqsrXHTy2T0uqbYP2yaWFO/X/Jlr8CZPZ2fcnkdXGPMh1b AfroYivPZXwoHhQFKIxZemsQh/BTcfRcbuTd/FyIgOYm9p4dTYIdXR8tRYOJ4pKiHtsPVOCsl8jdy uc+GV9/ZRh/1Nze5fus/A1LC47SLuy5K/A/mO/kLaqkUhg9KjZtvIpm+D9YQ4Iehjion01QkS8btj 6HEKVbqQ41rVkOkWH895OIM0k87SbdPPcT6fSATZjnCfmso+nnFkxUugFNlaT3QNMQKrygfpMO4fn jHXNU9YhA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izPx6-0000pi-O7; Wed, 05 Feb 2020 19:03:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izPx3-0000p1-Nr; Wed, 05 Feb 2020 19:03:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 305051FB; Wed, 5 Feb 2020 11:03:01 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C7FD3F52E; Wed, 5 Feb 2020 11:03:00 -0800 (PST) Subject: Re: [PATCH] arm64: dts: rockchip: Fix rk3328-roc-cc sdmmcio-regulator To: Peter Geis , Adam Van Ymeren References: <87imkryz5t.fsf@vany.ca> <7b9829b3-e2d2-95b1-03cb-1af7a3c6acad@arm.com> <4a6a9d81-c831-4167-7fbf-64805940fb6f@vany.ca> <510d310b-30af-7b24-d472-907bc6b2ef46@vany.ca> <7b36198e-25c0-4f3b-d871-6bd5aaf619d8@vany.ca> <2f863743-f5fd-7702-ac22-762dbca834cb@vany.ca> From: Robin Murphy Message-ID: <382b4bd5-279d-b227-5d0c-774d9c164168@arm.com> Date: Wed, 5 Feb 2020 19:02:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200205_110305_820644_E759E156 X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:ARM/Rockchip SoC..." , Heiko Stuebner , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/02/2020 6:43 pm, Peter Geis wrote: [...] >> One thing I did notice, though, is that GPIO_MUTE seems to have some >> inherent coupling to the analog codec, as the value automatically goes >> high when starting to play audio, and low again when stopping (but can >> still be manually toggled in between). Thus unless there's some secret >> to disabling that behaviour then it might not be safe to enable analog >> audio on these ROC-CC boards for fear of messing up peoples' SD cards. > > Robin, > Do you know if that is the SOC doing that or the drivers? Ha, once again I hastily jump to a conclusion without fully investigating... I'm really not doing too well in this thread :) You're absolutely right; on closer inspection rk3328_analog_output() in the codec driver is poking GRF_SOC_CON10 directly. That should be straightforward enough to sort out, phew! Cheers, Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel