From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A145C54EBC for ; Tue, 10 Jan 2023 14:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xQSqs/t9DtWwd/87zt4Gh34jtTWyYaN72wmew69EfQE=; b=GHswcRmxFVNCzX NqWdp4kskqWMn3XJYLXuJkk5BT/1bnTR9b3mQdKshcmRbpBcKmPTzJ82hHWbl4dEmXGDazpVPmt91 TllbXuf+HATdbjzdaJEHNHHs2kIfbcmP86KyJQ8t2rnDl5LgpjwRm7qZKMrCsi4NYmhWaFSro4y+F pRi8UwVLhxNi1W8HMmyf946gzWGITq2ktpOnZme9ipKQ7P0l+p84UhbqaftXj0GCkK/l1vsDmTylc mKA2Vfj8Ha6y3FZh1YLoJMU7xAU6IIqc+M2uSPT5piKv7K+SCC77kRxT0WHCS3/8kmRWAzPGEs77j STKuXMcECKicymQHalDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFFKj-007EDe-Ao; Tue, 10 Jan 2023 14:10:33 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFFKg-007EBp-1A; Tue, 10 Jan 2023 14:10:31 +0000 Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pFFKd-000540-2v; Tue, 10 Jan 2023 15:10:27 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: wens@kernel.org Cc: pgwipeout@gmail.com, Furkan Kardame , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] arm64: dts: rockchip: add rk3566 audio nodes Date: Tue, 10 Jan 2023 15:10:26 +0100 Message-ID: <3835889.hdfAi7Kttb@diego> In-Reply-To: References: <20230109203232.45192-1-f.kardame@manjaro.org> <167335938203.2550251.9294002031370939026.b4-ty@sntech.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_061030_107040_68DAB4D9 X-CRM114-Status: GOOD ( 20.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Dienstag, 10. Januar 2023, 15:08:50 CET schrieb Chen-Yu Tsai: > On Tue, Jan 10, 2023 at 10:05 PM Heiko Stuebner wrote: > > > > On Mon, 9 Jan 2023 23:32:33 +0300, Furkan Kardame wrote: > > > This patch adds simple audio card nodes > > > Enabled i2s0_8ch as it is needed for hdmi audio > > > Added i2s1_8ch as it is needed for 3.5mm audio jack > > > > > > > > > > Applied - with remarks below! > > > > [1/1] arm64: dts: rockchip: add rk3566 audio nodes > > commit: 9ce61898b3075892b01792fd3a44507b7e459c6f > > > > > > The core i2s@fe410000 node should _not_ go into a board devicetree. > > Thankfully an identical node for the i2s controller was already > > added to the core rk356x dt, so I've just dropped the one from > > your patch. > > Shouldn't hdmi_sound also be enabled? Otherwise i2s0_8ch is enabled > for nothing. Furkan, care to send a patch for that? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel