From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B084C43381 for ; Mon, 11 Mar 2019 22:18:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54C5F20657 for ; Mon, 11 Mar 2019 22:18:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zw+CAAjV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54C5F20657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nFPyGRerJ47fKLksfOEFLDDAz34e+Z2n06Gr2MuLkNI=; b=Zw+CAAjVrUWwuEEWdu0eF/Qwq ST85IER+B6wXWaTsCYF08S4SgOBpALm21K85bcDJBzgK7h8EwRNeVkiqipoARDgh74hVIU/HpFUt8 b8O9Lg7a3ufP1cWooX7k+dqWcGeN9+EpNxEqKuyJPDLABGXrR6n2fYS1QOscwCR5v9y09Eh5GBuF/ IY0oFc07sQDN+HOzSlISDsGzgJnf2NarbGr1b3hUtmTTgFNpA87dv/Ur6l3m/GlWgXNY3cgoTg4DN H+aBiaPSd5ZpzciyjInEk2491TMqb8N7EZgt4oRD+ZEfsNrEp/yEuUxhVNnsRV07DvmgfN0yG9vUv hruQz+7qQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3TFs-0000xi-8Y; Mon, 11 Mar 2019 22:18:44 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3TFo-0000xG-FX; Mon, 11 Mar 2019 22:18:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 198C7A78; Mon, 11 Mar 2019 15:18:38 -0700 (PDT) Received: from [192.168.1.123] (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B5F4C3F59C; Mon, 11 Mar 2019 15:18:35 -0700 (PDT) Subject: Re: [PATCH v3 2/3] arm: dts: rk3288-tinker.dtsi: Enable WiFi To: David Summers , heiko@sntech.de, robh+dt@kernel.org, frowand.list@gmail.com References: <20190217121513.22965-1-beagleboard@davidjohnsummers.uk> <20190309153923.22806-1-beagleboard@davidjohnsummers.uk> <20190309153923.22806-2-beagleboard@davidjohnsummers.uk> From: Robin Murphy Message-ID: <383c9884-4885-34e1-9ef7-96e936bb211d@arm.com> Date: Mon, 11 Mar 2019 22:18:30 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20190309153923.22806-2-beagleboard@davidjohnsummers.uk> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_151840_523453_06CFC71C X-CRM114-Status: GOOD ( 23.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , devicetree@vger.kernel.org, Tony McKahan , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019-03-09 3:39 pm, David Summers wrote: > This patch adds wifi support to the ASUS Tinker Board (S) machines. > > This is provided by an wifi card (RTL8723BS) wired into the sdio interface. > > It requires certain pins pulled, to enable the WiFi. > > The schematics for these board do not show the WiFi connection, so the > connections have been taken from: > > https://github.com/TinkerBoard/debian_kernel/blob/develop/arch/arm/boot/dts/rk3288-miniarm.dts > > In particular the pulling of two pins. > > This patch is almost identical to v1. A few additional line breaks for > readability. On Armbian, they did not use sd-uhs-ddr50, so this has > been removed. It does not change functionality. The ASUS patch set > sd-uhs-sdr104;. > > Signed-off-by: David Summers > Signed-off-by: Stefan Wahren > Tested-by: Tony McKahan > Reviewed-by: Robin Murphy Erm, I don't think I did... :( Please see section 13 of Documentation/process/submitting-patches.rst for what that tag means. FWIW this is the kind of patch I might have considered formally reviewing if I had enough first-hand experience of the Tinker Board or Realtek SDIO modules to judge correctness, but sadly I have zero of either. Robin. > Test-by: TheSaint @ ArchLinux ARM > > --- > arch/arm/boot/dts/rk3288-tinker.dtsi | 40 +++++++++++++++++++++++++++- > 1 file changed, 39 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi > index ef653c3209bc..0ffab1b7c940 100644 > --- a/arch/arm/boot/dts/rk3288-tinker.dtsi > +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi > @@ -5,6 +5,7 @@ > > #include "rk3288.dtsi" > #include > +#include > > / { > chosen { > @@ -96,6 +97,17 @@ > startup-delay-us = <100000>; > vin-supply = <&vcc_io>; > }; > + > + sdio_pwrseq: sdio-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + clocks = <&rk808 RK808_CLKOUT1>; > + clock-names = "ext_clock"; > + pinctrl-names = "default"; > + pinctrl-0 = <&wifi_enable>; > + reset-gpios = <&gpio4 RK_PD3 GPIO_ACTIVE_LOW>, > + <&gpio4 RK_PD4 GPIO_ACTIVE_LOW>; > + }; > + > }; > > &cpu0 { > @@ -336,7 +348,7 @@ > > &io_domains { > status = "okay"; > - > + wifi-supply = <&vcc_18>; > sdcard-supply = <&vccio_sd>; > }; > > @@ -416,6 +428,13 @@ > rockchip,pins = <7 8 RK_FUNC_GPIO &pcfg_pull_none>; > }; > }; > + > + sdio { > + wifi_enable: wifi-enable { > + rockchip,pins = <4 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>, > + <4 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > }; > > &pwm0 { > @@ -440,6 +459,25 @@ > vqmmc-supply = <&vccio_sd>; > }; > > +&sdio0 { > + bus-width = <4>; > + cap-sd-highspeed; > + cap-sdio-irq; > + keep-power-in-suspend; > + mmc-pwrseq = <&sdio_pwrseq>; > + non-removable; > + pinctrl-names = "default"; > + pinctrl-0 = <&sdio0_bus4>, <&sdio0_cmd>, <&sdio0_clk>, <&sdio0_int>; > + max-frequency = <50000000>; > + sd-uhs-sdr12; > + sd-uhs-sdr25; > + sd-uhs-sdr50; > + vmmc-supply = <&vcc_io>; > + vqmmc-supply = <&vcc_18>; > + status = "okay"; > +}; > + > + > &tsadc { > rockchip,hw-tshut-mode = <1>; /* tshut mode 0:CRU 1:GPIO */ > rockchip,hw-tshut-polarity = <1>; /* tshut polarity 0:LOW 1:HIGH */ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel