linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl
Date: Thu, 16 Mar 2017 09:02:47 +0100	[thread overview]
Message-ID: <3841077.a8qRkotiEM@diego> (raw)
In-Reply-To: <1489572237-6649-2-git-send-email-cl@rock-chips.com>

Hi,

Am Mittwoch, 15. M?rz 2017, 18:03:51 CET schrieb cl at rock-chips.com:
> From: Chen Liang <cl@rock-chips.com>
> 
> The rk3328 soc need more pin function index for pinctrl.
> 
> Signed-off-by: Chen Liang <cl@rock-chips.com>
> ---
>  include/dt-bindings/pinctrl/rockchip.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/pinctrl/rockchip.h
> b/include/dt-bindings/pinctrl/rockchip.h index aaec8ba..bc2b6af 100644
> --- a/include/dt-bindings/pinctrl/rockchip.h
> +++ b/include/dt-bindings/pinctrl/rockchip.h
> @@ -63,5 +63,8 @@
>  #define RK_FUNC_2	2
>  #define RK_FUNC_3	3
>  #define RK_FUNC_4	4
> +#define RK_FUNC_5	5
> +#define RK_FUNC_6	6
> +#define RK_FUNC_7	7

please don't amend that function list anymore.

Only RK_FUNC_GPIO serves a real purpose but having constants FUNC_7 mapping 
simply to 7 does not help understand things better, so it's way easier to just 
have "7" as function in pinctrl entries in the devicetree.

That list is mainly a remnant to keep compatibility with old devicetrees and I 
guess I should add a deprecated notice at some point :-) .


Heiko

  reply	other threads:[~2017-03-16  8:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15 10:03 [PATCH v1 0/7] initialize dtsi file and dts file for RK3328 SoCs cl at rock-chips.com
2017-03-15 10:03 ` [PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl cl at rock-chips.com
2017-03-16  8:02   ` Heiko Stübner [this message]
2017-03-15 10:03 ` [PATCH v1 2/7] dt-bindings: iio: rockchip-saradc: add support for rk3328 cl at rock-chips.com
2017-03-16  8:28   ` Heiko Stuebner
2017-03-19 10:34     ` Jonathan Cameron
2017-03-15 10:03 ` [PATCH v1 3/7] dt-bindings: i2c: rk3x: " cl at rock-chips.com
2017-03-16  8:29   ` Heiko Stuebner
2017-03-15 10:03 ` [PATCH v1 4/7] dt-bindings: soc: rockchip: grf: " cl at rock-chips.com
2017-03-15 11:11 ` [PATCH v1 0/7] initialize dtsi file and dts file for RK3328 SoCs Heiko Stübner
2017-03-16  1:44 ` [PATCH v1 5/7] arm64: dts: rockchip: add core dtsi " cl at rock-chips.com
2017-03-16 16:15   ` Andre Przywara
2017-03-16  1:45 ` [PATCH v1 6/7] arm64: dts: rockchip: add dts file for RK3328 evaluation board cl at rock-chips.com
2017-03-16 16:18   ` Andre Przywara
2017-03-17  2:26     ` 陈亮
2017-03-17  8:45       ` Heiko Stuebner
2017-03-21  7:59         ` 陈亮
2017-03-21  8:57           ` Heiko Stübner
2017-03-16  1:45 ` [PATCH v1 7/7] dt-bindings: document rockchip rk3328-evb board cl at rock-chips.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3841077.a8qRkotiEM@diego \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).