From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: r8a7790 CCI configuration
Date: Fri, 21 Nov 2014 11:57:28 +0100 [thread overview]
Message-ID: <3843244.eEnPgu6iEl@wuerfel> (raw)
In-Reply-To: <1416542986-26846-1-git-send-email-horms+renesas@verge.net.au>
On Friday 21 November 2014 13:09:46 Simon Horman wrote:
> + writel_relaxed(readl_relaxed(p + CCI_SLAVE4 + CCI_SNOOP) | 0x3,
> + p + CCI_SLAVE4 + CCI_SNOOP); /* ca7 */
> + while (__raw_readl(p + CCI_STATUS));
> + /* wait for pending bit low */
>
Why are you using __raw_readl for the last access? I would make that
readl_relaxed() like the other ones for consistency.
Also, a better way to express waiting for the register read is to
put the ';' on the next line, or add a cpu_relax() statement:
while (readl_relaxed(p + CCI_STATUS))
cpu_relax();
Arnd
prev parent reply other threads:[~2014-11-21 10:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 4:09 [PATCH] ARM: shmobile: r8a7790 CCI configuration Simon Horman
2014-11-21 10:57 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3843244.eEnPgu6iEl@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox