From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer
Date: Thu, 17 Mar 2016 14:54:47 +0100 [thread overview]
Message-ID: <3852103.Khn1BuqerF@diego> (raw)
In-Reply-To: <1458222191-26023-1-git-send-email-peter.griffin@linaro.org>
Hi Peter,
no need to resend for that (will be lost when applying anyway), but for future
patches please consider the things below:
Am Donnerstag, 17. M?rz 2016, 13:43:11 schrieb Peter Griffin:
> This fixes the following sparse build warning:
>
> mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
please bring aling tags received in previous versions to future ones, like the
one from Lee:
Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
changes in v2:
- beautify commit message
otherwise, patch looks nice and I'll pick it up shortly
Thanks for catching this
Heiko
> arch/arm/mach-rockchip/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/platsmp.c
> b/arch/arm/mach-rockchip/platsmp.c index d42a07e..4d827a0 100644
> --- a/arch/arm/mach-rockchip/platsmp.c
> +++ b/arch/arm/mach-rockchip/platsmp.c
> @@ -65,7 +65,7 @@ static struct reset_control *rockchip_get_core_reset(int
> cpu) if (dev)
> np = dev->of_node;
> else
> - np = of_get_cpu_node(cpu, 0);
> + np = of_get_cpu_node(cpu, NULL);
>
> return of_reset_control_get(np, NULL);
> }
next prev parent reply other threads:[~2016-03-17 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 13:43 [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer Peter Griffin
2016-03-17 13:54 ` Heiko Stübner [this message]
2016-03-17 14:04 ` Peter Griffin
2016-03-19 8:31 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3852103.Khn1BuqerF@diego \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox