* [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer
@ 2016-03-17 13:43 Peter Griffin
2016-03-17 13:54 ` Heiko Stübner
2016-03-19 8:31 ` Heiko Stuebner
0 siblings, 2 replies; 4+ messages in thread
From: Peter Griffin @ 2016-03-17 13:43 UTC (permalink / raw)
To: linux-arm-kernel
This fixes the following sparse build warning:
mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/mach-rockchip/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
index d42a07e..4d827a0 100644
--- a/arch/arm/mach-rockchip/platsmp.c
+++ b/arch/arm/mach-rockchip/platsmp.c
@@ -65,7 +65,7 @@ static struct reset_control *rockchip_get_core_reset(int cpu)
if (dev)
np = dev->of_node;
else
- np = of_get_cpu_node(cpu, 0);
+ np = of_get_cpu_node(cpu, NULL);
return of_reset_control_get(np, NULL);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer
2016-03-17 13:43 [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer Peter Griffin
@ 2016-03-17 13:54 ` Heiko Stübner
2016-03-17 14:04 ` Peter Griffin
2016-03-19 8:31 ` Heiko Stuebner
1 sibling, 1 reply; 4+ messages in thread
From: Heiko Stübner @ 2016-03-17 13:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Peter,
no need to resend for that (will be lost when applying anyway), but for future
patches please consider the things below:
Am Donnerstag, 17. M?rz 2016, 13:43:11 schrieb Peter Griffin:
> This fixes the following sparse build warning:
>
> mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
please bring aling tags received in previous versions to future ones, like the
one from Lee:
Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
changes in v2:
- beautify commit message
otherwise, patch looks nice and I'll pick it up shortly
Thanks for catching this
Heiko
> arch/arm/mach-rockchip/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/platsmp.c
> b/arch/arm/mach-rockchip/platsmp.c index d42a07e..4d827a0 100644
> --- a/arch/arm/mach-rockchip/platsmp.c
> +++ b/arch/arm/mach-rockchip/platsmp.c
> @@ -65,7 +65,7 @@ static struct reset_control *rockchip_get_core_reset(int
> cpu) if (dev)
> np = dev->of_node;
> else
> - np = of_get_cpu_node(cpu, 0);
> + np = of_get_cpu_node(cpu, NULL);
>
> return of_reset_control_get(np, NULL);
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer
2016-03-17 13:54 ` Heiko Stübner
@ 2016-03-17 14:04 ` Peter Griffin
0 siblings, 0 replies; 4+ messages in thread
From: Peter Griffin @ 2016-03-17 14:04 UTC (permalink / raw)
To: linux-arm-kernel
Hi Heiko,
On Thu, 17 Mar 2016, Heiko St?bner wrote:
> Hi Peter,
>
> no need to resend for that (will be lost when applying anyway), but for future
> patches please consider the things below:
>
> Am Donnerstag, 17. M?rz 2016, 13:43:11 schrieb Peter Griffin:
> > This fixes the following sparse build warning:
> >
> > mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer
> >
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
>
> please bring aling tags received in previous versions to future ones, like the
> one from Lee:
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
Will do, I didn't notice Lee had also Acked it. I should have been paying more
attention and not re-spinning whilst in a conf call.
>
> > ---
>
> changes in v2:
> - beautify commit message
>
>
> otherwise, patch looks nice and I'll pick it up shortly
>
>
> Thanks for catching this
No problem, thanks for the feedback and taking the patch.
regards,
Peter.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer
2016-03-17 13:43 [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer Peter Griffin
2016-03-17 13:54 ` Heiko Stübner
@ 2016-03-19 8:31 ` Heiko Stuebner
1 sibling, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2016-03-19 8:31 UTC (permalink / raw)
To: linux-arm-kernel
Am Donnerstag, 17. M?rz 2016, 13:43:11 schrieb Peter Griffin:
> This fixes the following sparse build warning:
>
> mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
applied to soc32-fixes for 4.6 with Lee's Ack
Thanks
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-19 8:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 13:43 [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer Peter Griffin
2016-03-17 13:54 ` Heiko Stübner
2016-03-17 14:04 ` Peter Griffin
2016-03-19 8:31 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox